From: John Crispin <john@phrozen.org>
To: linux-mips@linux-mips.org
Subject: Re: [PATCH V3 09/10] MIPS: ralink: adds rt305x devicetree
Date: Thu, 31 Jan 2013 14:13:22 +0100 [thread overview]
Message-ID: <510A6DF2.6000509@phrozen.org> (raw)
In-Reply-To: <510A6ABB.2090800@openwrt.org>
> The specific partition mapping definitively belongs to a rt305x-eval.dts
> file and not a dtsi you would create.
I’ll split this into 2 files
>
>> +};
>> diff --git a/arch/mips/ralink/rt305x.c b/arch/mips/ralink/rt305x.c
>> index 1e24439..f4b2e4d 100644
>> --- a/arch/mips/ralink/rt305x.c
>> +++ b/arch/mips/ralink/rt305x.c
>> @@ -185,8 +185,8 @@ void __init ralink_clk_init(void)
>>
>> void __init ralink_of_remap(void)
>> {
>> - rt_sysc_membase = plat_of_remap_node("ralink,rt305x-sysc");
>> - rt_memc_membase = plat_of_remap_node("ralink,rt305x-memc");
>> + rt_sysc_membase = plat_of_remap_node("ralink,rt3052-sysc");
>> + rt_memc_membase = plat_of_remap_node("ralink,rt3052-memc");
>
> Why are you doing this? If you specify multiple compatible properties,
> such as:
> compatible = "ralink,rt3052-sysc", "ralink,rt305x-sysc" you should be
> good in any case no?
I folded that fix into the wrong patch :-)
using wild cards is discouraged for compatible strings rt3052 was the
first silicon with this sysc version.
John
next prev parent reply other threads:[~2013-01-31 13:16 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-31 11:59 [PATCH V3 00/10] MIPS: ralink: adds support for ralink platform John Crispin
2013-01-31 11:59 ` [PATCH V3 01/10] MIPS: ralink: adds include files John Crispin
2013-01-31 13:35 ` Gabor Juhos
2013-01-31 11:59 ` [PATCH V3 02/10] MIPS: ralink: adds irq code John Crispin
2013-01-31 13:36 ` Gabor Juhos
2013-01-31 11:59 ` [PATCH V3 03/10] MIPS: ralink: adds reset code John Crispin
2013-01-31 13:36 ` Gabor Juhos
2013-01-31 11:59 ` [PATCH V3 04/10] MIPS: ralink: adds prom and cmdline code John Crispin
2013-01-31 13:36 ` Gabor Juhos
2013-01-31 11:59 ` [PATCH V3 05/10] MIPS: ralink: adds clkdev code John Crispin
2013-01-31 13:37 ` Gabor Juhos
2013-01-31 11:59 ` [PATCH V3 06/10] MIPS: ralink: adds OF code John Crispin
2013-01-31 13:37 ` Gabor Juhos
2013-01-31 11:59 ` [PATCH V3 07/10] MIPS: ralink: adds early_printk support John Crispin
2013-01-31 13:37 ` Gabor Juhos
2013-01-31 11:59 ` [PATCH V3 08/10] MIPS: ralink: adds support for RT305x SoC family John Crispin
2013-01-31 13:06 ` Florian Fainelli
2013-01-31 13:08 ` John Crispin
2013-01-31 13:38 ` Gabor Juhos
2013-01-31 11:59 ` [PATCH V3 09/10] MIPS: ralink: adds rt305x devicetree John Crispin
2013-01-31 12:59 ` Florian Fainelli
2013-01-31 13:13 ` John Crispin [this message]
2013-01-31 14:11 ` Gabor Juhos
2013-01-31 11:59 ` [PATCH V3 10/10] MIPS: ralink: adds Kbuild files John Crispin
2013-01-31 12:56 ` Florian Fainelli
2013-01-31 12:57 ` John Crispin
2013-01-31 13:39 ` Gabor Juhos
2013-02-01 11:40 ` [PATCH V3 00/10] MIPS: ralink: adds support for ralink platform Florian Fainelli
2013-02-01 11:47 ` John Crispin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=510A6DF2.6000509@phrozen.org \
--to=john@phrozen.org \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox