* [PATCH] MIPS: Alchemy: Fix typo "CONFIG_DEBUG_PCI"
@ 2013-04-04 11:25 Paul Bolle
2013-04-04 11:53 ` Sergei Shtylyov
0 siblings, 1 reply; 3+ messages in thread
From: Paul Bolle @ 2013-04-04 11:25 UTC (permalink / raw)
To: Ralf Baechle; +Cc: linux-mips, linux-kernel
Also add a newline to a debugging printk that this fix enables.
Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
0) Entirely untested. Adding the newline adds a checkpatch warning for
over 80 characters lines.
1) Typo was added in v3.2, through commit
7517de348663b08a808aff44b5300e817157a568 ("MIPS: Alchemy: Redo PCI as
platform driver").
arch/mips/pci/pci-alchemy.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/mips/pci/pci-alchemy.c b/arch/mips/pci/pci-alchemy.c
index 38a80c8..d1faece 100644
--- a/arch/mips/pci/pci-alchemy.c
+++ b/arch/mips/pci/pci-alchemy.c
@@ -19,7 +19,7 @@
#include <asm/mach-au1x00/au1000.h>
#include <asm/tlbmisc.h>
-#ifdef CONFIG_DEBUG_PCI
+#ifdef CONFIG_PCI_DEBUG
#define DBG(x...) printk(KERN_DEBUG x)
#else
#define DBG(x...) do {} while (0)
@@ -162,7 +162,7 @@ static int config_access(unsigned char access_type, struct pci_bus *bus,
if (status & (1 << 29)) {
*data = 0xffffffff;
error = -1;
- DBG("alchemy-pci: master abort on cfg access %d bus %d dev %d",
+ DBG("alchemy-pci: master abort on cfg access %d bus %d dev %d\n",
access_type, bus->number, device);
} else if ((status >> 28) & 0xf) {
DBG("alchemy-pci: PCI ERR detected: dev %d, status %lx\n",
--
1.7.11.7v
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] MIPS: Alchemy: Fix typo "CONFIG_DEBUG_PCI"
2013-04-04 11:25 [PATCH] MIPS: Alchemy: Fix typo "CONFIG_DEBUG_PCI" Paul Bolle
@ 2013-04-04 11:53 ` Sergei Shtylyov
2013-04-04 13:47 ` [PATCH v2] " Paul Bolle
0 siblings, 1 reply; 3+ messages in thread
From: Sergei Shtylyov @ 2013-04-04 11:53 UTC (permalink / raw)
To: Paul Bolle; +Cc: Ralf Baechle, linux-mips, linux-kernel
Hello.
On 04-04-2013 15:25, Paul Bolle wrote:
> Also add a newline to a debugging printk that this fix enables.
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> ---
> 0) Entirely untested. Adding the newline adds a checkpatch warning for
> over 80 characters lines.
> 1) Typo was added in v3.2, through commit
> 7517de348663b08a808aff44b5300e817157a568 ("MIPS: Alchemy: Redo PCI as
> platform driver").
This is the information for the changelog.
WBR, Sergei
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH v2] MIPS: Alchemy: Fix typo "CONFIG_DEBUG_PCI"
2013-04-04 11:53 ` Sergei Shtylyov
@ 2013-04-04 13:47 ` Paul Bolle
0 siblings, 0 replies; 3+ messages in thread
From: Paul Bolle @ 2013-04-04 13:47 UTC (permalink / raw)
To: Ralf Baechle; +Cc: Sergei Shtylyov, linux-mips, linux-kernel
Commit 7517de348663b08a808aff44b5300e817157a568 ("MIPS: Alchemy: Redo
PCI as platform driver") added a reference to CONFIG_DEBUG_PCI. Change
it to CONFIG_PCI_DEBUG, as that is a valid Kconfig macro.
Also add a newline to a debugging printk that this fix enables.
Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
This version has a verbose commit explanation, as Sergei requested.
Still entirely untested.
arch/mips/pci/pci-alchemy.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/mips/pci/pci-alchemy.c b/arch/mips/pci/pci-alchemy.c
index 38a80c8..d1faece 100644
--- a/arch/mips/pci/pci-alchemy.c
+++ b/arch/mips/pci/pci-alchemy.c
@@ -19,7 +19,7 @@
#include <asm/mach-au1x00/au1000.h>
#include <asm/tlbmisc.h>
-#ifdef CONFIG_DEBUG_PCI
+#ifdef CONFIG_PCI_DEBUG
#define DBG(x...) printk(KERN_DEBUG x)
#else
#define DBG(x...) do {} while (0)
@@ -162,7 +162,7 @@ static int config_access(unsigned char access_type, struct pci_bus *bus,
if (status & (1 << 29)) {
*data = 0xffffffff;
error = -1;
- DBG("alchemy-pci: master abort on cfg access %d bus %d dev %d",
+ DBG("alchemy-pci: master abort on cfg access %d bus %d dev %d\n",
access_type, bus->number, device);
} else if ((status >> 28) & 0xf) {
DBG("alchemy-pci: PCI ERR detected: dev %d, status %lx\n",
--
1.7.11.7
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-04-04 13:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-04 11:25 [PATCH] MIPS: Alchemy: Fix typo "CONFIG_DEBUG_PCI" Paul Bolle
2013-04-04 11:53 ` Sergei Shtylyov
2013-04-04 13:47 ` [PATCH v2] " Paul Bolle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox