From: John Crispin <blogic@openwrt.org>
To: unlisted-recipients:; (no To-header on input)
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH] arch: mips: ralink: using strlcpy() instead of strncpy()
Date: Mon, 27 May 2013 12:37:59 +0200 [thread overview]
Message-ID: <51A33787.8080301@openwrt.org> (raw)
In-Reply-To: <51A1C16A.6050808@asianux.com>
On 26/05/13 10:01, Chen Gang wrote:
> 'compatible' is used by strlen() in __of_device_is_compatible().
>
> So for NUL terminated string, need always be sure of ended by zero.
>
> 'of_ids' is not a structure in "include/uapi/*", so not need initialize
> all bytes, just use strlcpy() instead of strncpy().
>
>
> Signed-off-by: Chen Gang<gang.chen@asianux.com>
Acked-by: John Crispin <blogic@openwrt.org>
WARNING: multiple messages have this Message-ID (diff)
From: John Crispin <blogic@openwrt.org>
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH] arch: mips: ralink: using strlcpy() instead of strncpy()
Date: Mon, 27 May 2013 12:37:59 +0200 [thread overview]
Message-ID: <51A33787.8080301@openwrt.org> (raw)
Message-ID: <20130527103759.3skvpCs-PNtfYFtgAwBACOZ-DhYyIEAFmTw3bAMc4jA@z> (raw)
In-Reply-To: <51A1C16A.6050808@asianux.com>
On 26/05/13 10:01, Chen Gang wrote:
> 'compatible' is used by strlen() in __of_device_is_compatible().
>
> So for NUL terminated string, need always be sure of ended by zero.
>
> 'of_ids' is not a structure in "include/uapi/*", so not need initialize
> all bytes, just use strlcpy() instead of strncpy().
>
>
> Signed-off-by: Chen Gang<gang.chen@asianux.com>
Acked-by: John Crispin <blogic@openwrt.org>
next prev parent reply other threads:[~2013-05-27 10:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-26 8:01 [PATCH] arch: mips: ralink: using strlcpy() instead of strncpy() Chen Gang
2013-05-27 10:37 ` John Crispin [this message]
2013-05-27 10:37 ` John Crispin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51A33787.8080301@openwrt.org \
--to=blogic@openwrt.org \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox