Re: [PATCH v6] MIPS: micromips: Fix improper definition of ISA exception bit.

[Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>]

On 06/06/2013 01:07 AM, David Daney wrote:
> On 06/05/2013 01:01 PM, Sergei Shtylyov wrote:
>> Hello.
>>
>> On 06/05/2013 11:49 PM, Steven J. Hill wrote:
>>
>>> The ISA exception bit selects whether exceptions are taken in classic
>>> or microMIPS mode. This bit is Config3.ISAOnExc and was improperly
>>> defined as bits 16 and 17 instead of just bit 16. A new function was
>>> added so that platforms could set this bit when running a kernel
>>> compiled with only microMIPS instructions.
>>
>>      Ahem, isn't that function a material for another patch?
>
>
> I think you might be going overboard.  The entire patch relates to 
> exactly one bit a config register, can't you let it be a single patch?

    The purpose of the patch declared in its subject is just to fix the 
bit itself.
Instead the patch does zillion other things, which IMHO not even always 
can be
considered fixes, so no, I'm not feeling like I'm going overboard with this.

> David Daney

WBR, Sergei