From: "Steven J. Hill" <Steven.Hill@imgtec.com>
To: Jonas Gorski <jogo@openwrt.org>
Cc: David Daney <ddaney.cavm@gmail.com>, <linux-mips@linux-mips.org>
Subject: Re: [PATCH v6] MIPS: micromips: Fix improper definition of ISA exception bit.
Date: Wed, 5 Jun 2013 16:36:28 -0500 [thread overview]
Message-ID: <51AFAF5C.3020109@imgtec.com> (raw)
In-Reply-To: <CAOiHx=mFqC=GN0jmb9PXpt+JapfWoP3Pu5NM0sp=F_uAZuwUEA@mail.gmail.com>
On 06/05/2013 04:23 PM, Jonas Gorski wrote:
>
> if (cpu_has_mmips) {
> unsigned int config3 = read_c0_config3();
>
> if (IS_ENABLED(CONFIG_CPU_MICROMIPS))
> write_c0_config3(config3 | MIPS_CONF3_ISA_OE);
> else
> write_c0_config3(config3 & ~MIPS_CONF3_ISA_OE);
> }
>
>
I like this being in 'trap_init' instead. Any objections?
WARNING: multiple messages have this Message-ID (diff)
From: "Steven J. Hill" <Steven.Hill@imgtec.com>
To: Jonas Gorski <jogo@openwrt.org>
Cc: David Daney <ddaney.cavm@gmail.com>, linux-mips@linux-mips.org
Subject: Re: [PATCH v6] MIPS: micromips: Fix improper definition of ISA exception bit.
Date: Wed, 5 Jun 2013 16:36:28 -0500 [thread overview]
Message-ID: <51AFAF5C.3020109@imgtec.com> (raw)
Message-ID: <20130605213628.10wqNUzh1O93EjqGKLv6qUbPEJlLyaZeSu7yiqQ2vxU@z> (raw)
In-Reply-To: <CAOiHx=mFqC=GN0jmb9PXpt+JapfWoP3Pu5NM0sp=F_uAZuwUEA@mail.gmail.com>
On 06/05/2013 04:23 PM, Jonas Gorski wrote:
>
> if (cpu_has_mmips) {
> unsigned int config3 = read_c0_config3();
>
> if (IS_ENABLED(CONFIG_CPU_MICROMIPS))
> write_c0_config3(config3 | MIPS_CONF3_ISA_OE);
> else
> write_c0_config3(config3 & ~MIPS_CONF3_ISA_OE);
> }
>
>
I like this being in 'trap_init' instead. Any objections?
next prev parent reply other threads:[~2013-06-05 21:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-05 19:49 [PATCH v6] MIPS: micromips: Fix improper definition of ISA exception bit Steven J. Hill
2013-06-05 20:01 ` Sergei Shtylyov
2013-06-05 21:07 ` David Daney
2013-06-05 21:30 ` Sergei Shtylyov
2013-06-05 20:53 ` David Daney
2013-06-05 21:15 ` Steven J. Hill
2013-06-05 21:15 ` Steven J. Hill
2013-06-05 21:23 ` Jonas Gorski
2013-06-05 21:27 ` David Daney
2013-06-05 21:36 ` Steven J. Hill [this message]
2013-06-05 21:36 ` Steven J. Hill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51AFAF5C.3020109@imgtec.com \
--to=steven.hill@imgtec.com \
--cc=ddaney.cavm@gmail.com \
--cc=jogo@openwrt.org \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox