* [PATCH] MIPS: ralink: add missing SZ_1M multiplier
@ 2013-06-06 13:55 John Crispin
2013-06-06 14:27 ` Florian Fainelli
0 siblings, 1 reply; 3+ messages in thread
From: John Crispin @ 2013-06-06 13:55 UTC (permalink / raw)
To: ralf; +Cc: linux-mips, John Crispin
On RT5350 the memory size is set to Bytes and not MegaBytes due to a missing
multiplier.
Signed-off-by: John Crispin <blogic@openwrt.org>
---
arch/mips/ralink/of.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/mips/ralink/of.c b/arch/mips/ralink/of.c
index f916774..b25c1f2 100644
--- a/arch/mips/ralink/of.c
+++ b/arch/mips/ralink/of.c
@@ -88,7 +88,7 @@ void __init plat_mem_setup(void)
__dt_setup_arch(&__dtb_start);
if (soc_info.mem_size)
- add_memory_region(soc_info.mem_base, soc_info.mem_size,
+ add_memory_region(soc_info.mem_base, soc_info.mem_size * SZ_1M,
BOOT_MEM_RAM);
else
detect_memory_region(soc_info.mem_base,
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] MIPS: ralink: add missing SZ_1M multiplier
2013-06-06 13:55 [PATCH] MIPS: ralink: add missing SZ_1M multiplier John Crispin
@ 2013-06-06 14:27 ` Florian Fainelli
2013-06-06 16:07 ` John Crispin
0 siblings, 1 reply; 3+ messages in thread
From: Florian Fainelli @ 2013-06-06 14:27 UTC (permalink / raw)
To: John Crispin; +Cc: ralf, Linux-MIPS
2013/6/6 John Crispin <blogic@openwrt.org>:
> On RT5350 the memory size is set to Bytes and not MegaBytes due to a missing
> multiplier.
You might want to mention that the regression got introduced in
dd63b008 ("MIPS: ralink: make use of the new memory detection code").
This also needs to be in a future 3.10-rc pull request to Linus.
Cheers
>
> Signed-off-by: John Crispin <blogic@openwrt.org>
> ---
> arch/mips/ralink/of.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/ralink/of.c b/arch/mips/ralink/of.c
> index f916774..b25c1f2 100644
> --- a/arch/mips/ralink/of.c
> +++ b/arch/mips/ralink/of.c
> @@ -88,7 +88,7 @@ void __init plat_mem_setup(void)
> __dt_setup_arch(&__dtb_start);
>
> if (soc_info.mem_size)
> - add_memory_region(soc_info.mem_base, soc_info.mem_size,
> + add_memory_region(soc_info.mem_base, soc_info.mem_size * SZ_1M,
> BOOT_MEM_RAM);
> else
> detect_memory_region(soc_info.mem_base,
> --
> 1.7.10.4
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] MIPS: ralink: add missing SZ_1M multiplier
2013-06-06 14:27 ` Florian Fainelli
@ 2013-06-06 16:07 ` John Crispin
0 siblings, 0 replies; 3+ messages in thread
From: John Crispin @ 2013-06-06 16:07 UTC (permalink / raw)
To: Florian Fainelli; +Cc: ralf, Linux-MIPS
On 06/06/13 16:27, Florian Fainelli wrote:
> 2013/6/6 John Crispin<blogic@openwrt.org>:
>> On RT5350 the memory size is set to Bytes and not MegaBytes due to a missing
>> multiplier.
> You might want to mention that the regression got introduced in
> dd63b008 ("MIPS: ralink: make use of the new memory detection code").
> This also needs to be in a future 3.10-rc pull request to Linus.
>
> Cheers
Hi Florian
correct !
i mailed it as ralf is preparing a 3.10-rc pull request and i wanted
this to make it ....
i will ping ralf on irc and ask him to fold the "dd63b008 ("MIPS:
ralink: make use of the new memory detection code")." bit into the comment
Thanks,
John
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-06-06 16:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-06 13:55 [PATCH] MIPS: ralink: add missing SZ_1M multiplier John Crispin
2013-06-06 14:27 ` Florian Fainelli
2013-06-06 16:07 ` John Crispin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox