From: Markos Chandras <Markos.Chandras@imgtec.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: <linux-mips@linux-mips.org>, "Steven J. Hill" <Steven.Hill@imgtec.com>
Subject: Re: [PATCH] MIPS: include: mmu_context.h: Replace VIRTUALIZATION with KVM
Date: Mon, 10 Jun 2013 13:51:59 +0100 [thread overview]
Message-ID: <51B5CBEF.7040202@imgtec.com> (raw)
In-Reply-To: <51B5BD5F.8090604@cogentembedded.com>
On 06/10/13 12:49, Sergei Shtylyov wrote:
> hello.
>
> On 10-06-2013 15:42, Markos Chandras wrote:
>
>> The kvm_* symbols are only available if KVM is selected.
>
>> Fixes the following linking problem on a randconfig:
>
>> arch/mips/built-in.o: In function `local_flush_tlb_mm':
>> (.text+0x18a94): undefined reference to `kvm_local_flush_tlb_all'
>> arch/mips/built-in.o: In function `local_flush_tlb_range':
>> (.text+0x18d0c): undefined reference to `kvm_local_flush_tlb_all'
>> kernel/built-in.o: In function `__schedule':
>> core.c:(.sched.text+0x2a00): undefined reference to
>> `kvm_local_flush_tlb_all'
>> mm/built-in.o: In function `use_mm':
>> (.text+0x30214): undefined reference to `kvm_local_flush_tlb_all'
>> fs/built-in.o: In function `flush_old_exec':
>> (.text+0xf0a0): undefined reference to `kvm_local_flush_tlb_all'
>> make: *** [vmlinux] Error 1
>
>> Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
>> Signed-off-by: Steven J. Hill <Steven.Hill@imgtec.com>
>> ---
>> arch/mips/include/asm/mmu_context.h | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>
>> diff --git a/arch/mips/include/asm/mmu_context.h
>> b/arch/mips/include/asm/mmu_context.h
>> index 8201160..ee5a93b 100644
>> --- a/arch/mips/include/asm/mmu_context.h
>> +++ b/arch/mips/include/asm/mmu_context.h
>> @@ -111,13 +111,15 @@ static inline void enter_lazy_tlb(struct
>> mm_struct *mm, struct task_struct *tsk)
>> static inline void
>> get_new_mmu_context(struct mm_struct *mm, unsigned long cpu)
>> {
>> +#ifdef CONFIG_KVM
>> extern void kvm_local_flush_tlb_all(void);
>> +#endif
>
> #ifdef should not be needed around declaration.
>
> WBR, Sergei
>
Hi Sergei,
You are right. I will send a new version of this patch.
--
markos
WARNING: multiple messages have this Message-ID (diff)
From: Markos Chandras <Markos.Chandras@imgtec.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: linux-mips@linux-mips.org, "Steven J. Hill" <Steven.Hill@imgtec.com>
Subject: Re: [PATCH] MIPS: include: mmu_context.h: Replace VIRTUALIZATION with KVM
Date: Mon, 10 Jun 2013 13:51:59 +0100 [thread overview]
Message-ID: <51B5CBEF.7040202@imgtec.com> (raw)
Message-ID: <20130610125159.1cVT05Pt0PMfKHqNcVg_IuUuSt9sjCW49RPqUH3iRaM@z> (raw)
In-Reply-To: <51B5BD5F.8090604@cogentembedded.com>
On 06/10/13 12:49, Sergei Shtylyov wrote:
> hello.
>
> On 10-06-2013 15:42, Markos Chandras wrote:
>
>> The kvm_* symbols are only available if KVM is selected.
>
>> Fixes the following linking problem on a randconfig:
>
>> arch/mips/built-in.o: In function `local_flush_tlb_mm':
>> (.text+0x18a94): undefined reference to `kvm_local_flush_tlb_all'
>> arch/mips/built-in.o: In function `local_flush_tlb_range':
>> (.text+0x18d0c): undefined reference to `kvm_local_flush_tlb_all'
>> kernel/built-in.o: In function `__schedule':
>> core.c:(.sched.text+0x2a00): undefined reference to
>> `kvm_local_flush_tlb_all'
>> mm/built-in.o: In function `use_mm':
>> (.text+0x30214): undefined reference to `kvm_local_flush_tlb_all'
>> fs/built-in.o: In function `flush_old_exec':
>> (.text+0xf0a0): undefined reference to `kvm_local_flush_tlb_all'
>> make: *** [vmlinux] Error 1
>
>> Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
>> Signed-off-by: Steven J. Hill <Steven.Hill@imgtec.com>
>> ---
>> arch/mips/include/asm/mmu_context.h | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>
>> diff --git a/arch/mips/include/asm/mmu_context.h
>> b/arch/mips/include/asm/mmu_context.h
>> index 8201160..ee5a93b 100644
>> --- a/arch/mips/include/asm/mmu_context.h
>> +++ b/arch/mips/include/asm/mmu_context.h
>> @@ -111,13 +111,15 @@ static inline void enter_lazy_tlb(struct
>> mm_struct *mm, struct task_struct *tsk)
>> static inline void
>> get_new_mmu_context(struct mm_struct *mm, unsigned long cpu)
>> {
>> +#ifdef CONFIG_KVM
>> extern void kvm_local_flush_tlb_all(void);
>> +#endif
>
> #ifdef should not be needed around declaration.
>
> WBR, Sergei
>
Hi Sergei,
You are right. I will send a new version of this patch.
--
markos
next prev parent reply other threads:[~2013-06-10 12:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-10 11:42 [PATCH] MIPS: include: mmu_context.h: Replace VIRTUALIZATION with KVM Markos Chandras
2013-06-10 11:42 ` Markos Chandras
2013-06-10 11:49 ` Sergei Shtylyov
2013-06-10 12:51 ` Markos Chandras [this message]
2013-06-10 12:51 ` Markos Chandras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51B5CBEF.7040202@imgtec.com \
--to=markos.chandras@imgtec.com \
--cc=Steven.Hill@imgtec.com \
--cc=linux-mips@linux-mips.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox