* [PATCH 00/27] devm cleanup, part #1, take #3
@ 2013-07-23 18:01 Wolfram Sang
2013-07-23 18:01 ` [PATCH 01/27] arch/mips/lantiq/xway: don't check resource with devm_ioremap_resource Wolfram Sang
0 siblings, 1 reply; 3+ messages in thread
From: Wolfram Sang @ 2013-07-23 18:01 UTC (permalink / raw)
To: linux-kernel
Cc: Wolfram Sang, alsa-devel, Bjorn Helgaas, Daniel Lezcano,
Dan Williams, David Woodhouse, devel, Dmitry Torokhov, dri-devel,
Eduardo Valentin, Eric Miao, Felipe Balbi, Giuseppe Cavallaro,
Grant Likely, Greg Kroah-Hartman, Haojian Zhuang,
James E.J. Bottomley, Jaroslav Kysela, Liam Girdwood,
Linus Walleij, linux-arm-kernel, linux-i2c, linux-input,
linux-media, linux-mips, linux-mtd, linux-pci, linux-pm,
linux-pwm, linux-rpi-kernel, linux-scsi, linux-spi, linux-tegra,
linux-usb, linux-watchdog, Mark Brown, Mauro Carvalho Chehab,
netdev, Rafael J. Wysocki, Ralf Baechle, Russell King, Santosh Y,
Stephen Warren, Takashi Iwai, Terje Bergström,
Thierry Reding, Vinayak Holikatti, Vinod Koul, Wan ZongShun,
Wim Van Sebroeck, Zhang Rui
Here is another bit of cleaning up the devm usage. It is again removing the
resource check with devm_ioremap_resource, because a) new drivers came in and
b) coccinelle had a bug and missed to find a couple of occasions. Unlike last
time, I think it is better if these patches go in via the subsystem trees to
reduce merge conflicts. And there is one driver which I fixed manually because
the original code needed some bigger update. All is based on v3.11-rc2 and the
branch can be found at:
git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git devm_no_resource_check
Other things which happened: I wanted to get rid of devm_request_and_ioremap,
luckily other people are already working on it. Hooray! I already sent a patch
series picking another low hanging fruit, i.e. drivers can skip devm_pinctrl
handling if they are using only the default pin setup. And not devm related,
there is still my proposal to rename INIT_COMPLETION to reinit_completion, that
probably needs some more persistence... Yay, so much to clean up \o/
Regards,
Wolfram
Wolfram Sang (27):
arch/mips/lantiq/xway: don't check resource with
devm_ioremap_resource
drivers/amba: don't check resource with devm_ioremap_resource
drivers/cpuidle: don't check resource with devm_ioremap_resource
drivers/dma: don't check resource with devm_ioremap_resource
drivers/gpu/host1x/drm: don't check resource with
devm_ioremap_resource
drivers/i2c/busses: don't check resource with devm_ioremap_resource
drivers/input/serio: don't check resource with devm_ioremap_resource
drivers/iommu: don't check resource with devm_ioremap_resource
drivers/media/platform: don't check resource with
devm_ioremap_resource
drivers/memory: don't check resource with devm_ioremap_resource
drivers/mtd/nand: don't check resource with devm_ioremap_resource
drivers/net/ethernet/stmicro/stmmac: don't check resource with
devm_ioremap_resource
drivers/pci/host: don't check resource with devm_ioremap_resource
drivers/pinctrl: don't check resource with devm_ioremap_resource
drivers/pwm: don't check resource with devm_ioremap_resource
drivers/scsi/ufs: don't check resource with devm_ioremap_resource
drivers/spi: don't check resource with devm_ioremap_resource
drivers/staging/imx-drm: don't check resource with
devm_ioremap_resource
drivers/usb/phy: don't check resource with devm_ioremap_resource
drivers/watchdog: don't check resource with devm_ioremap_resource
sound/soc/au1x: don't check resource with devm_ioremap_resource
sound/soc/cirrus: don't check resource with devm_ioremap_resource
sound/soc/nuc900: don't check resource with devm_ioremap_resource
sound/soc/pxa: don't check resource with devm_ioremap_resource
sound/soc/tegra: don't check resource with devm_ioremap_resource
sound/soc/txx9: don't check resource with devm_ioremap_resource
thermal: ti-bandgap: cleanup resource allocation
arch/mips/lantiq/xway/dma.c | 4 ----
drivers/amba/tegra-ahb.c | 2 --
drivers/cpuidle/cpuidle-kirkwood.c | 3 ---
drivers/dma/mmp_pdma.c | 3 ---
drivers/dma/mmp_tdma.c | 3 ---
drivers/gpu/host1x/drm/hdmi.c | 3 ---
drivers/i2c/busses/i2c-stu300.c | 3 ---
drivers/input/serio/olpc_apsp.c | 3 ---
drivers/iommu/tegra-smmu.c | 2 --
drivers/media/platform/coda.c | 5 -----
drivers/memory/tegra20-mc.c | 2 --
drivers/memory/tegra30-mc.c | 2 --
drivers/mtd/nand/mxc_nand.c | 5 -----
.../net/ethernet/stmicro/stmmac/stmmac_platform.c | 3 ---
drivers/pci/host/pcie-designware.c | 12 ------------
drivers/pinctrl/pinctrl-imx.c | 3 ---
drivers/pinctrl/pinctrl-rockchip.c | 5 -----
drivers/pinctrl/pinctrl-u300.c | 3 ---
drivers/pwm/pwm-lpc32xx.c | 3 ---
drivers/pwm/pwm-renesas-tpu.c | 5 -----
drivers/scsi/ufs/ufshcd-pltfrm.c | 6 ------
drivers/spi/spi-bcm2835.c | 6 ------
drivers/staging/imx-drm/imx-tve.c | 5 -----
drivers/thermal/ti-soc-thermal/ti-bandgap.c | 20 ++++----------------
drivers/usb/phy/phy-rcar-usb.c | 5 -----
drivers/watchdog/nuc900_wdt.c | 5 -----
drivers/watchdog/ts72xx_wdt.c | 10 ----------
sound/soc/au1x/psc-ac97.c | 3 ---
sound/soc/cirrus/ep93xx-ac97.c | 3 ---
sound/soc/cirrus/ep93xx-i2s.c | 3 ---
sound/soc/nuc900/nuc900-ac97.c | 3 ---
sound/soc/pxa/mmp-sspa.c | 3 ---
sound/soc/tegra/tegra20_ac97.c | 7 -------
sound/soc/txx9/txx9aclc-ac97.c | 3 ---
34 files changed, 4 insertions(+), 152 deletions(-)
--
1.7.10.4
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 01/27] arch/mips/lantiq/xway: don't check resource with devm_ioremap_resource
2013-07-23 18:01 [PATCH 00/27] devm cleanup, part #1, take #3 Wolfram Sang
@ 2013-07-23 18:01 ` Wolfram Sang
2013-07-23 18:02 ` John Crispin
0 siblings, 1 reply; 3+ messages in thread
From: Wolfram Sang @ 2013-07-23 18:01 UTC (permalink / raw)
To: linux-kernel; +Cc: Wolfram Sang, Ralf Baechle, linux-mips
devm_ioremap_resource does sanity checks on the given resource. No need to
duplicate this in the driver.
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
---
Please apply via the subsystem-tree.
arch/mips/lantiq/xway/dma.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/arch/mips/lantiq/xway/dma.c b/arch/mips/lantiq/xway/dma.c
index 08f7ebd..78a91fa 100644
--- a/arch/mips/lantiq/xway/dma.c
+++ b/arch/mips/lantiq/xway/dma.c
@@ -220,10 +220,6 @@ ltq_dma_init(struct platform_device *pdev)
int i;
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- if (!res)
- panic("Failed to get dma resource");
-
- /* remap dma register range */
ltq_dma_membase = devm_ioremap_resource(&pdev->dev, res);
if (IS_ERR(ltq_dma_membase))
panic("Failed to remap dma resource");
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 01/27] arch/mips/lantiq/xway: don't check resource with devm_ioremap_resource
2013-07-23 18:01 ` [PATCH 01/27] arch/mips/lantiq/xway: don't check resource with devm_ioremap_resource Wolfram Sang
@ 2013-07-23 18:02 ` John Crispin
0 siblings, 0 replies; 3+ messages in thread
From: John Crispin @ 2013-07-23 18:02 UTC (permalink / raw)
To: Wolfram Sang; +Cc: linux-kernel, Ralf Baechle, linux-mips
On 23/07/13 20:01, Wolfram Sang wrote:
> devm_ioremap_resource does sanity checks on the given resource. No need to
> duplicate this in the driver.
>
> Signed-off-by: Wolfram Sang<wsa@the-dreams.de>
Acked-by: John Crispin <blogic@openwrt.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-07-23 18:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-23 18:01 [PATCH 00/27] devm cleanup, part #1, take #3 Wolfram Sang
2013-07-23 18:01 ` [PATCH 01/27] arch/mips/lantiq/xway: don't check resource with devm_ioremap_resource Wolfram Sang
2013-07-23 18:02 ` John Crispin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox