From: James Hogan <james.hogan@imgtec.com>
To: John Crispin <blogic@openwrt.org>
Cc: Ralf Baechle <ralf@linux-mips.org>, <linux-mips@linux-mips.org>
Subject: Re: [PATCH] MIPS: ralink: add support for periodic timer irq
Date: Thu, 8 Aug 2013 12:18:48 +0100 [thread overview]
Message-ID: <52037E98.2040902@imgtec.com> (raw)
In-Reply-To: <1375959950-31024-1-git-send-email-blogic@openwrt.org>
Hi John,
On 08/08/13 12:05, John Crispin wrote:
> +static int rt_timer_probe(struct platform_device *pdev)
> +{
> + struct resource *res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> + struct rt_timer *rt;
> + struct clk *clk;
> +
> + if (!res) {
> + dev_err(&pdev->dev, "no memory resource found\n");
> + return -EINVAL;
> + }
devm_request_and_ioremap already error checks res so you don't need to
check it yourself (see devm_request_and_ioremap kerneldoc comment in
lib/devres.c).
> +
> + rt = devm_kzalloc(&pdev->dev, sizeof(*rt), GFP_KERNEL);
> + if (!rt) {
> + dev_err(&pdev->dev, "failed to allocate memory\n");
> + return -ENOMEM;
> + }
> +
> + rt->irq = platform_get_irq(pdev, 0);
> + if (!rt->irq) {
> + dev_err(&pdev->dev, "failed to load irq\n");
> + return -ENOENT;
> + }
> +
> + rt->membase = devm_request_and_ioremap(&pdev->dev, res);
> + if (!rt->membase) {
> + dev_err(&pdev->dev, "failed to ioremap\n");
> + return -ENOMEM;
> + }
Cheers
James
WARNING: multiple messages have this Message-ID (diff)
From: James Hogan <james.hogan@imgtec.com>
To: John Crispin <blogic@openwrt.org>
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org
Subject: Re: [PATCH] MIPS: ralink: add support for periodic timer irq
Date: Thu, 8 Aug 2013 12:18:48 +0100 [thread overview]
Message-ID: <52037E98.2040902@imgtec.com> (raw)
Message-ID: <20130808111848.Hr4FjmAAi7XQujAZUwYmUPiMvhv1Mrw8O6qDJ9D-K-8@z> (raw)
In-Reply-To: <1375959950-31024-1-git-send-email-blogic@openwrt.org>
Hi John,
On 08/08/13 12:05, John Crispin wrote:
> +static int rt_timer_probe(struct platform_device *pdev)
> +{
> + struct resource *res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> + struct rt_timer *rt;
> + struct clk *clk;
> +
> + if (!res) {
> + dev_err(&pdev->dev, "no memory resource found\n");
> + return -EINVAL;
> + }
devm_request_and_ioremap already error checks res so you don't need to
check it yourself (see devm_request_and_ioremap kerneldoc comment in
lib/devres.c).
> +
> + rt = devm_kzalloc(&pdev->dev, sizeof(*rt), GFP_KERNEL);
> + if (!rt) {
> + dev_err(&pdev->dev, "failed to allocate memory\n");
> + return -ENOMEM;
> + }
> +
> + rt->irq = platform_get_irq(pdev, 0);
> + if (!rt->irq) {
> + dev_err(&pdev->dev, "failed to load irq\n");
> + return -ENOENT;
> + }
> +
> + rt->membase = devm_request_and_ioremap(&pdev->dev, res);
> + if (!rt->membase) {
> + dev_err(&pdev->dev, "failed to ioremap\n");
> + return -ENOMEM;
> + }
Cheers
James
next prev parent reply other threads:[~2013-08-08 11:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-08 11:05 [PATCH] MIPS: ralink: add support for periodic timer irq John Crispin
2013-08-08 11:05 ` [PATCH] MIPS: ralink: add support for reset-controller API John Crispin
2013-08-08 11:18 ` James Hogan [this message]
2013-08-08 11:18 ` [PATCH] MIPS: ralink: add support for periodic timer irq James Hogan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52037E98.2040902@imgtec.com \
--to=james.hogan@imgtec.com \
--cc=blogic@openwrt.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox