From: David Daney <ddaney.cavm@gmail.com>
To: Felix Fietkau <nbd@openwrt.org>
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH 2/2] MIPS: partially inline dma ops
Date: Mon, 12 Aug 2013 10:08:47 -0700 [thread overview]
Message-ID: <5209169F.5070709@gmail.com> (raw)
In-Reply-To: <1376306569-83278-2-git-send-email-nbd@openwrt.org>
On 08/12/2013 04:22 AM, Felix Fietkau wrote:
> Several DMA ops are no-op on many platforms, and the indirection through
> the mips_dma_map_ops function table is causing the compiler to emit
> unnecessary code.
>
> Inlining visibly improves network performance in my tests (on a 24Kc
> based system), and also slightly reduces code size of a few drivers.
>
> Signed-off-by: Felix Fietkau <nbd@openwrt.org>
> ---
> arch/mips/Kconfig | 4 +
> arch/mips/include/asm/dma-mapping.h | 360 +++++++++++++++++++++++++++++++++++-
> arch/mips/mm/dma-default.c | 161 ++--------------
> 3 files changed, 372 insertions(+), 153 deletions(-)
>
That is not a very pleasing diffstat.
David
next prev parent reply other threads:[~2013-08-12 17:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-12 11:22 [PATCH 1/2] MIPS: remove unnecessary platform dma helper functions Felix Fietkau
2013-08-12 11:22 ` [PATCH 2/2] MIPS: partially inline dma ops Felix Fietkau
2013-08-12 17:08 ` David Daney [this message]
2013-08-12 17:22 ` Felix Fietkau
2013-08-12 17:04 ` [PATCH 1/2] MIPS: remove unnecessary platform dma helper functions David Daney
2013-08-12 17:16 ` Felix Fietkau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5209169F.5070709@gmail.com \
--to=ddaney.cavm@gmail.com \
--cc=linux-mips@linux-mips.org \
--cc=nbd@openwrt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox