From: Felix Fietkau <nbd@openwrt.org>
To: David Daney <ddaney.cavm@gmail.com>
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH 1/2] MIPS: remove unnecessary platform dma helper functions
Date: Mon, 12 Aug 2013 19:16:17 +0200 [thread overview]
Message-ID: <52091861.4040707@openwrt.org> (raw)
In-Reply-To: <5209159D.7040301@gmail.com>
On 2013-08-12 7:04 PM, David Daney wrote:
> That's a mighty thin changelog there.
I thought it was obvious that the lines I removed contain no useful code
at all :)
> You are changing the semantics in the
> asm/mach-cavium-octeon/dma-coherence.h case.
I'm just removing a fallback BUG() that could never be reached before my
change either. As for the other platforms, I verified that there's no
useful code in these functions anywhere in the tree.
> Have you verified that all in-tree cases really are NOPs?
Yes.
- Felix
prev parent reply other threads:[~2013-08-12 17:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-12 11:22 [PATCH 1/2] MIPS: remove unnecessary platform dma helper functions Felix Fietkau
2013-08-12 11:22 ` [PATCH 2/2] MIPS: partially inline dma ops Felix Fietkau
2013-08-12 17:08 ` David Daney
2013-08-12 17:22 ` Felix Fietkau
2013-08-12 17:04 ` [PATCH 1/2] MIPS: remove unnecessary platform dma helper functions David Daney
2013-08-12 17:16 ` Felix Fietkau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52091861.4040707@openwrt.org \
--to=nbd@openwrt.org \
--cc=ddaney.cavm@gmail.com \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox