From: James Hogan <james.hogan@imgtec.com>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: <linux-mips@linux-mips.org>, <ralf@linux-mips.org>,
<blogic@openwrt.org>, <richard@nod.at>
Subject: Re: [PATCH] MIPS: do not allow building vmlinuz when !ZBOOT
Date: Thu, 29 Aug 2013 13:54:01 +0100 [thread overview]
Message-ID: <521F4469.6020507@imgtec.com> (raw)
In-Reply-To: <1377704569-21331-1-git-send-email-f.fainelli@gmail.com>
Hi Florian,
On 28/08/13 16:42, Florian Fainelli wrote:
> +ifdef CONFIG_SYS_SUPPORTS_ZBOOT
> # boot/compressed
> vmlinuz vmlinuz.bin vmlinuz.ecoff vmlinuz.srec: $(vmlinux-32) FORCE
> $(Q)$(MAKE) $(build)=arch/mips/boot/compressed \
> VMLINUX_LOAD_ADDRESS=$(load-y) 32bit-bfd=$(32bit-bfd) $@
> +else
> +vmlinuz:
Does this need a dependency on FORCE so that if you switched config and
had a valid vmlinuz lying around it doesn't do nothing as a result of
vmlinuz having no dependencies and existing?
> + @echo ' CONFIG_SYS_SUPPORTS_ZBOOT is not enabled'
Also it may be worth adding false here too so that make's exit code
reports failure correctly.
Cheers
James
WARNING: multiple messages have this Message-ID (diff)
From: James Hogan <james.hogan@imgtec.com>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org,
blogic@openwrt.org, richard@nod.at
Subject: Re: [PATCH] MIPS: do not allow building vmlinuz when !ZBOOT
Date: Thu, 29 Aug 2013 13:54:01 +0100 [thread overview]
Message-ID: <521F4469.6020507@imgtec.com> (raw)
Message-ID: <20130829125401.gaAaE7dVorm3tioariLAztlAUcpa9YbejJcUR5aahYQ@z> (raw)
In-Reply-To: <1377704569-21331-1-git-send-email-f.fainelli@gmail.com>
Hi Florian,
On 28/08/13 16:42, Florian Fainelli wrote:
> +ifdef CONFIG_SYS_SUPPORTS_ZBOOT
> # boot/compressed
> vmlinuz vmlinuz.bin vmlinuz.ecoff vmlinuz.srec: $(vmlinux-32) FORCE
> $(Q)$(MAKE) $(build)=arch/mips/boot/compressed \
> VMLINUX_LOAD_ADDRESS=$(load-y) 32bit-bfd=$(32bit-bfd) $@
> +else
> +vmlinuz:
Does this need a dependency on FORCE so that if you switched config and
had a valid vmlinuz lying around it doesn't do nothing as a result of
vmlinuz having no dependencies and existing?
> + @echo ' CONFIG_SYS_SUPPORTS_ZBOOT is not enabled'
Also it may be worth adding false here too so that make's exit code
reports failure correctly.
Cheers
James
next prev parent reply other threads:[~2013-08-29 12:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-28 15:42 [PATCH] MIPS: do not allow building vmlinuz when !ZBOOT Florian Fainelli
2013-08-29 12:54 ` James Hogan [this message]
2013-08-29 12:54 ` James Hogan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=521F4469.6020507@imgtec.com \
--to=james.hogan@imgtec.com \
--cc=blogic@openwrt.org \
--cc=f.fainelli@gmail.com \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox