From: David Daney <ddaney@caviumnetworks.com>
To: Aaro Koskinen <aaro.koskinen@iki.fi>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
<devel@driverdev.osuosl.org>, <linux-mips@linux-mips.org>,
David Daney <david.daney@cavium.com>,
"Jason A. Donenfeld" <Jason@zx2c4.com>, <richard@nod.at>
Subject: Re: [PATCH 1/3] staging: octeon-ethernet: make dropped packets to consume NAPI budget
Date: Thu, 5 Sep 2013 11:55:51 -0700 [thread overview]
Message-ID: <5228D3B7.505@caviumnetworks.com> (raw)
In-Reply-To: <1378406641-16530-2-git-send-email-aaro.koskinen@iki.fi>
On 09/05/2013 11:43 AM, Aaro Koskinen wrote:
> We should count also dropped packets, otherwise the NAPI handler may
> end up running too long.
Is this actually a problem?
If so ... the patch looks sane and you and add Acked-by me.
>
> Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
> ---
> drivers/staging/octeon/ethernet-rx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/octeon/ethernet-rx.c b/drivers/staging/octeon/ethernet-rx.c
> index 34afc16..10e5416 100644
> --- a/drivers/staging/octeon/ethernet-rx.c
> +++ b/drivers/staging/octeon/ethernet-rx.c
> @@ -303,6 +303,7 @@ static int cvm_oct_napi_poll(struct napi_struct *napi, int budget)
> if (backlog > budget * cores_in_use && napi != NULL)
> cvm_oct_enable_one_cpu();
> }
> + rx_count++;
>
> skb_in_hw = USE_SKBUFFS_IN_HW && work->word2.s.bufs == 1;
> if (likely(skb_in_hw)) {
> @@ -429,7 +430,6 @@ static int cvm_oct_napi_poll(struct napi_struct *napi, int budget)
> #endif
> }
> netif_receive_skb(skb);
> - rx_count++;
> } else {
> /* Drop any packet received for a device that isn't up */
> /*
>
WARNING: multiple messages have this Message-ID (diff)
From: David Daney <ddaney@caviumnetworks.com>
To: Aaro Koskinen <aaro.koskinen@iki.fi>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, linux-mips@linux-mips.org,
David Daney <david.daney@cavium.com>,
"Jason A. Donenfeld" <Jason@zx2c4.com>,
richard@nod.at
Subject: Re: [PATCH 1/3] staging: octeon-ethernet: make dropped packets to consume NAPI budget
Date: Thu, 5 Sep 2013 11:55:51 -0700 [thread overview]
Message-ID: <5228D3B7.505@caviumnetworks.com> (raw)
Message-ID: <20130905185551.JyRNh_7sv92D4dkPjnqGMqqtKOKFLohfnjDb2WsIamg@z> (raw)
In-Reply-To: <1378406641-16530-2-git-send-email-aaro.koskinen@iki.fi>
On 09/05/2013 11:43 AM, Aaro Koskinen wrote:
> We should count also dropped packets, otherwise the NAPI handler may
> end up running too long.
Is this actually a problem?
If so ... the patch looks sane and you and add Acked-by me.
>
> Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
> ---
> drivers/staging/octeon/ethernet-rx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/octeon/ethernet-rx.c b/drivers/staging/octeon/ethernet-rx.c
> index 34afc16..10e5416 100644
> --- a/drivers/staging/octeon/ethernet-rx.c
> +++ b/drivers/staging/octeon/ethernet-rx.c
> @@ -303,6 +303,7 @@ static int cvm_oct_napi_poll(struct napi_struct *napi, int budget)
> if (backlog > budget * cores_in_use && napi != NULL)
> cvm_oct_enable_one_cpu();
> }
> + rx_count++;
>
> skb_in_hw = USE_SKBUFFS_IN_HW && work->word2.s.bufs == 1;
> if (likely(skb_in_hw)) {
> @@ -429,7 +430,6 @@ static int cvm_oct_napi_poll(struct napi_struct *napi, int budget)
> #endif
> }
> netif_receive_skb(skb);
> - rx_count++;
> } else {
> /* Drop any packet received for a device that isn't up */
> /*
>
next prev parent reply other threads:[~2013-09-05 18:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-05 18:43 octeon-ethernet: bug fixes Aaro Koskinen
2013-09-05 18:43 ` [PATCH 1/3] staging: octeon-ethernet: make dropped packets to consume NAPI budget Aaro Koskinen
2013-09-05 18:55 ` David Daney [this message]
2013-09-05 18:55 ` David Daney
2013-09-05 18:44 ` [PATCH 2/3] staging: octeon-ethernet: remove skb alloc failure warnings Aaro Koskinen
2013-09-05 18:57 ` David Daney
2013-09-05 18:44 ` [PATCH 3/3] staging: octeon-ethernet: rgmii: enable interrupts that we can handle Aaro Koskinen
2013-09-05 19:00 ` David Daney
2013-09-05 19:00 ` David Daney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5228D3B7.505@caviumnetworks.com \
--to=ddaney@caviumnetworks.com \
--cc=Jason@zx2c4.com \
--cc=aaro.koskinen@iki.fi \
--cc=david.daney@cavium.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-mips@linux-mips.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox