Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: Markos Chandras <Markos.Chandras@imgtec.com>
To: <linux-mips@linux-mips.org>
Subject: Re: [PATCH] MIPS: fix mapstart when using initrd
Date: Mon, 7 Oct 2013 17:10:19 +0100	[thread overview]
Message-ID: <5252DCEB.8070909@imgtec.com> (raw)
In-Reply-To: <20131007160821.GA1615@linux-mips.org>

On 10/07/13 17:08, Ralf Baechle wrote:
> On Mon, Sep 23, 2013 at 07:40:26PM +0530, Ashok Kumar wrote:
>> Date:   Mon, 23 Sep 2013 19:40:26 +0530
>> From: Ashok Kumar <ashoks@broadcom.com>
>> To: linux-mips@linux-mips.org, gerg@uclinux.org
>> cc: ralf@linux-mips.org, Ashok Kumar <ashoks@broadcom.com>
>> Subject: [PATCH] MIPS: fix mapstart when using initrd
>> Content-Type: text/plain
>>
>> When initrd is present in the PFN right after the _end, bootmem
>> bitmap(mapstart) overwrites it. So check for initrd_end in
>> mapstart calculation.
>>
>> Signed-off-by: Ashok Kumar <ashoks@broadcom.com>
>> ---
>> This is seen after the commit
>> "mips: fix start of free memory when using initrd"
>> in git://git.linux-mips.org/pub/scm/ralf/upstream-sfr.git branch
>>
>> Tested the image on MIPS platform creating the above
>> said scenario and initrd was corrupted.
>
> And it gloriously breaks the build if CONFIG_BLK_DEV_INITRD is disabled.
> Now most configurations will fail with something like:
>
> [...]
>    LD      vmlinux
> arch/mips/built-in.o: In function `setup_arch':
> (.init.text+0xff8): undefined reference to `initrd_end'
> arch/mips/built-in.o: In function `setup_arch':
> (.init.text+0xffc): undefined reference to `initrd_end'
> make[2]: *** [vmlinux] Error 1
> make[1]: *** [sub-make] Error 2
> make: *** [all] Error 2
> make: Leaving directory `/home/ralf/src/linux/obj/lasat-build'
>
>    Ralf
>
Hi Ralf,

I just sent a patch for that

http://patchwork.linux-mips.org/patch/6028/

WARNING: multiple messages have this Message-ID (diff)
From: Markos Chandras <Markos.Chandras@imgtec.com>
To: linux-mips@linux-mips.org
Subject: Re: [PATCH] MIPS: fix mapstart when using initrd
Date: Mon, 7 Oct 2013 17:10:19 +0100	[thread overview]
Message-ID: <5252DCEB.8070909@imgtec.com> (raw)
Message-ID: <20131007161019.Z6s9uPhHj_ffXf9VOwTiwH1Q6ZKjF9Bp8q-DiVVRToE@z> (raw)
In-Reply-To: <20131007160821.GA1615@linux-mips.org>

On 10/07/13 17:08, Ralf Baechle wrote:
> On Mon, Sep 23, 2013 at 07:40:26PM +0530, Ashok Kumar wrote:
>> Date:   Mon, 23 Sep 2013 19:40:26 +0530
>> From: Ashok Kumar <ashoks@broadcom.com>
>> To: linux-mips@linux-mips.org, gerg@uclinux.org
>> cc: ralf@linux-mips.org, Ashok Kumar <ashoks@broadcom.com>
>> Subject: [PATCH] MIPS: fix mapstart when using initrd
>> Content-Type: text/plain
>>
>> When initrd is present in the PFN right after the _end, bootmem
>> bitmap(mapstart) overwrites it. So check for initrd_end in
>> mapstart calculation.
>>
>> Signed-off-by: Ashok Kumar <ashoks@broadcom.com>
>> ---
>> This is seen after the commit
>> "mips: fix start of free memory when using initrd"
>> in git://git.linux-mips.org/pub/scm/ralf/upstream-sfr.git branch
>>
>> Tested the image on MIPS platform creating the above
>> said scenario and initrd was corrupted.
>
> And it gloriously breaks the build if CONFIG_BLK_DEV_INITRD is disabled.
> Now most configurations will fail with something like:
>
> [...]
>    LD      vmlinux
> arch/mips/built-in.o: In function `setup_arch':
> (.init.text+0xff8): undefined reference to `initrd_end'
> arch/mips/built-in.o: In function `setup_arch':
> (.init.text+0xffc): undefined reference to `initrd_end'
> make[2]: *** [vmlinux] Error 1
> make[1]: *** [sub-make] Error 2
> make: *** [all] Error 2
> make: Leaving directory `/home/ralf/src/linux/obj/lasat-build'
>
>    Ralf
>
Hi Ralf,

I just sent a patch for that

http://patchwork.linux-mips.org/patch/6028/

  reply	other threads:[~2013-10-07 16:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-23 14:10 [PATCH] MIPS: fix mapstart when using initrd Ashok Kumar
2013-10-07 16:08 ` Ralf Baechle
2013-10-07 16:10   ` Markos Chandras [this message]
2013-10-07 16:10     ` Markos Chandras
2013-10-07 16:29     ` Ralf Baechle
2013-10-14 12:05 ` Jonas Gorski
2013-10-15 10:19   ` Ashok Kumar
     [not found]   ` <525d1725.85680e0a.0dea.4371SMTPIN_ADDED_BROKEN@mx.google.com>
2013-10-15 10:57     ` Jonas Gorski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5252DCEB.8070909@imgtec.com \
    --to=markos.chandras@imgtec.com \
    --cc=linux-mips@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox