From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Jayachandran C <jchandra@broadcom.com>
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org
Subject: Re: [PATCH 17/18] MIPS: Netlogic: XLP9XX PIC OF support
Date: Tue, 15 Oct 2013 16:28:36 +0400 [thread overview]
Message-ID: <525D34F4.80807@cogentembedded.com> (raw)
In-Reply-To: <1381756874-22616-18-git-send-email-jchandra@broadcom.com>
Hello.
On 14-10-2013 17:21, Jayachandran C wrote:
> Support for adding legacy IRQ domain for XLP9XX. The node id of the
> PIC has to be calulated differently for XLP9XX.
> Signed-off-by: Jayachandran C <jchandra@broadcom.com>
> ---
> arch/mips/netlogic/common/irq.c | 28 ++++++++++++++++++++++++----
> 1 file changed, 24 insertions(+), 4 deletions(-)
> diff --git a/arch/mips/netlogic/common/irq.c b/arch/mips/netlogic/common/irq.c
> index 8092bb3..34be9bb 100644
> --- a/arch/mips/netlogic/common/irq.c
> +++ b/arch/mips/netlogic/common/irq.c
[...]
> @@ -293,7 +292,28 @@ static int __init xlp_of_pic_init(struct device_node *node,
> pr_err("PIC %s: reg property not found!\n", node->name);
> return -EINVAL;
> }
> - socid = (res.start >> 18) & 0x3;
> +
> + if (cpu_is_xlp9xx()) {
> + bus = (res.start >> 20) & 0xf;
> + for (socid = 0; socid < NLM_NR_NODES; socid++) {
> + if (!nlm_node_present(socid))
> + continue;
> + if (nlm_get_node(socid)->socbus == bus)
> + break;
> + }
> + if (socid == NLM_NR_NODES) {
> + pr_err("PIC %s: Node mapping for bus %d not found!n",
> + node->name, bus);
> + return -EINVAL;
> + }
> + } else
> + socid = (res.start >> 18) & 0x3;
Both arms of the *if* statement should have {} if one arm has it,
according to Documentation/CodingStyle.
WBR, Sergei
next prev parent reply other threads:[~2013-10-15 12:29 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-14 13:20 [PATCH 00/18] Broadcom XLP Updates Jayachandran C
2013-10-14 13:20 ` [PATCH 01/18] MIPS: Netlogic: Add MSI support for XLP Jayachandran C
2013-10-14 13:20 ` [PATCH 02/18] MIPS: Netlogic: Add topology.h for XLP family Jayachandran C
2013-10-14 13:20 ` [PATCH 03/18] MIPS: Netlogic: Some cleanups for assembly code Jayachandran C
2013-10-14 13:21 ` [PATCH 04/18] MIPS: Netlogic: L1D cacheflush before thread enable on XLPII Jayachandran C
2013-10-14 13:21 ` [PATCH 05/18] MIPS: Netlogic: Add macro for node present Jayachandran C
2013-10-14 13:21 ` [PATCH 06/18] MIPS: Netlogic: Get coremask from FUSE register Jayachandran C
2013-10-15 12:09 ` Sergei Shtylyov
2013-10-22 11:19 ` [PATCH 06/18 UPDATED] " Jayachandran C
2013-10-14 13:21 ` [PATCH 07/18] MIPS: Netlogic: Core wakeup improvements Jayachandran C
2013-10-14 13:21 ` [PATCH 08/18] MIPS: Netlogic: Identify XLP 9XX chip Jayachandran C
2013-10-14 13:21 ` [PATCH 09/18] MIPS: Netlogic: update iomap.h for XLP9XX Jayachandran C
2013-10-14 13:21 ` [PATCH 10/18] MIPS: Netlogic: XLP9XX PIC updates Jayachandran C
2013-10-14 13:21 ` [PATCH 11/18] MIPS: Netlogic: SYS block updates of XLP9XX Jayachandran C
2013-10-22 11:20 ` [PATCH 11/18 UPDATED] " Jayachandran C
2013-10-14 13:21 ` [PATCH 12/18] MIPS: Netlogic: XLP9XX UART offset Jayachandran C
2013-10-14 13:21 ` [PATCH 13/18] MIPS: Netlogic: XLP9XX bridge and DRAM code Jayachandran C
2013-10-14 13:21 ` [PATCH 14/18] MIPS: Netlogic: Add cpu to node mapping for XLP9XX Jayachandran C
2013-10-14 13:21 ` [PATCH 15/18] MIPS: PCI: Netlogic XLP9XX support Jayachandran C
2013-10-22 11:22 ` [PATCH 11/18 UPDATED] MIPS: Netlogic: SYS block updates of XLP9XX Jayachandran C
2013-10-22 11:26 ` [PATCH 15/18 UPDATED] MIPS: PCI: Netlogic XLP9XX support Jayachandran C
2013-10-14 13:21 ` [PATCH 16/18] MIPS: Netlogic: XLP9XX USB support Jayachandran C
2013-10-14 13:21 ` [PATCH 17/18] MIPS: Netlogic: XLP9XX PIC OF support Jayachandran C
2013-10-15 12:28 ` Sergei Shtylyov [this message]
2013-10-22 11:23 ` Jayachandran C
2013-10-14 13:21 ` [PATCH 18/18] MIPS: Netlogic: Add default DTB for XLP9XX SoC Jayachandran C
2013-10-25 8:52 ` [PATCH 18/18 UPDATED] " Jayachandran C
-- strict thread matches above, loose matches on Subject: below --
2013-12-21 11:22 [PATCH 00/18] Broadcom XLP Updates for 3.14 Jayachandran C
2013-12-21 11:22 ` [PATCH 17/18] MIPS: Netlogic: XLP9XX PIC OF support Jayachandran C
2013-12-21 11:22 ` Jayachandran C
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=525D34F4.80807@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=jchandra@broadcom.com \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox