From: "Steven J. Hill" <Steven.Hill@imgtec.com>
To: David Daney <ddaney.cavm@gmail.com>
Cc: <linux-mips@linux-mips.org>, <ralf@linux-mips.org>
Subject: Re: [PATCH 6/6] MIPS: APRP: Code formatting clean-ups.
Date: Thu, 17 Oct 2013 13:26:22 -0500 [thread overview]
Message-ID: <52602BCE.7050407@imgtec.com> (raw)
In-Reply-To: <52602368.3000901@gmail.com>
On 10/17/2013 12:50 PM, David Daney wrote:
> On 10/16/2013 07:14 PM, Steven J. Hill wrote:
>> From: "Steven J. Hill" <Steven.Hill@imgtec.com>
>>
>> Clean-up code according to the 'checkpatch.pl' script.
>
> This should probably be the first patch, so you don't end up making
> poorly formatted additions, and then later clean them up.
>
Noted, but I am not inclined to change the order of the patches right now.
> Also the change log text is not at all true, please make it reflect
> reality.
>
Yes, the changelog should be updated to note copyright clean-ups and
other formatting changes. I will update that.
Steve
WARNING: multiple messages have this Message-ID (diff)
From: "Steven J. Hill" <Steven.Hill@imgtec.com>
To: David Daney <ddaney.cavm@gmail.com>
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org
Subject: Re: [PATCH 6/6] MIPS: APRP: Code formatting clean-ups.
Date: Thu, 17 Oct 2013 13:26:22 -0500 [thread overview]
Message-ID: <52602BCE.7050407@imgtec.com> (raw)
Message-ID: <20131017182622.SvGU2QCuf2K0nLhlQDXefNVDa2wHN4yq5zsJIfrbeps@z> (raw)
In-Reply-To: <52602368.3000901@gmail.com>
On 10/17/2013 12:50 PM, David Daney wrote:
> On 10/16/2013 07:14 PM, Steven J. Hill wrote:
>> From: "Steven J. Hill" <Steven.Hill@imgtec.com>
>>
>> Clean-up code according to the 'checkpatch.pl' script.
>
> This should probably be the first patch, so you don't end up making
> poorly formatted additions, and then later clean them up.
>
Noted, but I am not inclined to change the order of the patches right now.
> Also the change log text is not at all true, please make it reflect
> reality.
>
Yes, the changelog should be updated to note copyright clean-ups and
other formatting changes. I will update that.
Steve
next prev parent reply other threads:[~2013-10-17 18:26 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-17 2:14 [PATCH 0/6] MIPS: APRP: Enable APRP for platforms with a CM Steven J. Hill
2013-10-17 2:14 ` [PATCH 1/6] MIPS: APRP: Split VPE loader into separate files Steven J. Hill
2013-10-17 2:14 ` [PATCH 2/6] MIPS: APRP: Add VPE loader support for CMP platforms Steven J. Hill
2013-10-17 17:40 ` David Daney
2013-10-17 22:00 ` Deng-Cheng Zhu
2013-10-17 22:00 ` Deng-Cheng Zhu
2013-10-17 22:11 ` David Daney
2013-10-17 22:38 ` Deng-Cheng Zhu
2013-10-17 22:38 ` Deng-Cheng Zhu
2013-10-17 22:54 ` David Daney
2013-10-17 23:13 ` Deng-Cheng Zhu
2013-10-17 23:13 ` Deng-Cheng Zhu
2013-10-17 2:14 ` [PATCH 3/6] MIPS: APRP: Split RTLX support into separate files Steven J. Hill
2013-10-17 2:14 ` [PATCH 4/6] MIPS: APRP: Add RTLX API support for CMP platforms Steven J. Hill
2013-10-17 2:14 ` [PATCH 5/6] MIPS: APRP: Malta Add support for Malta CMP platform Steven J. Hill
2013-10-17 2:14 ` [PATCH 6/6] MIPS: APRP: Code formatting clean-ups Steven J. Hill
2013-10-17 17:50 ` David Daney
2013-10-17 18:26 ` Steven J. Hill [this message]
2013-10-17 18:26 ` Steven J. Hill
-- strict thread matches above, loose matches on Subject: below --
2013-10-30 20:52 [PATCH v2 0/6] MIPS: APRP: Enable APRP for platforms with a CM Steven J. Hill
2013-10-30 20:52 ` [PATCH 6/6] MIPS: APRP: Code formatting clean-ups Steven J. Hill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52602BCE.7050407@imgtec.com \
--to=steven.hill@imgtec.com \
--cc=ddaney.cavm@gmail.com \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox