From: Markos Chandras <Markos.Chandras@imgtec.com>
To: Florian Fainelli <f.fainelli@gmail.com>, <linux-mips@linux-mips.org>
Cc: <ralf@linux-mips.org>, <blogic@openwrt.org>,
<Leonid.Yegoshin@imgtec.com>, <jim2101024@gmail.com>
Subject: Re: [PATCH mips-for-linux-next] MIPS: fix genex.S build for non MIPS32r2 class processors
Date: Mon, 28 Oct 2013 14:36:35 +0000 [thread overview]
Message-ID: <526E7673.6050308@imgtec.com> (raw)
In-Reply-To: <1382725617-32561-1-git-send-email-f.fainelli@gmail.com>
On 25/10/2013 07:26 μμ, Florian Fainelli wrote:
> Commit d712357d ("MIPS: Print correct PC in trace dump after NMI
> exception") introduced assembly code which uses the "ehb" instruction,
> which is only available in MIPS32r2 class processors and causes such
> build errors on MIPS32r1 processors:
>
> AS arch/mips/kernel/genex.o
> arch/mips/kernel/genex.S: Assembler messages:
> arch/mips/kernel/genex.S:386: Error: opcode not supported on this
> processor: mips32 (mips32) `ehb'
> make[2]: *** [arch/mips/kernel/genex.o] Error 1
> make[1]: *** [arch/mips/kernel] Error 2
> make[1]: *** Waiting for unfinished jobs....
>
> Use _ehb which properly substitutes to a nop or a real ehb depending on
> the processor we are building for.
>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
Yep that looks good to me. Thanks for fixing it
Reviewed-by: Markos Chandras <markos.chandras@imgtec.com>
--
markos
WARNING: multiple messages have this Message-ID (diff)
From: Markos Chandras <Markos.Chandras@imgtec.com>
To: Florian Fainelli <f.fainelli@gmail.com>, linux-mips@linux-mips.org
Cc: ralf@linux-mips.org, blogic@openwrt.org,
Leonid.Yegoshin@imgtec.com, jim2101024@gmail.com
Subject: Re: [PATCH mips-for-linux-next] MIPS: fix genex.S build for non MIPS32r2 class processors
Date: Mon, 28 Oct 2013 14:36:35 +0000 [thread overview]
Message-ID: <526E7673.6050308@imgtec.com> (raw)
Message-ID: <20131028143635.5hls9NWYLWqxALUgfBkUlfrdrUtw0AFcLdb_xGq68c0@z> (raw)
In-Reply-To: <1382725617-32561-1-git-send-email-f.fainelli@gmail.com>
On 25/10/2013 07:26 μμ, Florian Fainelli wrote:
> Commit d712357d ("MIPS: Print correct PC in trace dump after NMI
> exception") introduced assembly code which uses the "ehb" instruction,
> which is only available in MIPS32r2 class processors and causes such
> build errors on MIPS32r1 processors:
>
> AS arch/mips/kernel/genex.o
> arch/mips/kernel/genex.S: Assembler messages:
> arch/mips/kernel/genex.S:386: Error: opcode not supported on this
> processor: mips32 (mips32) `ehb'
> make[2]: *** [arch/mips/kernel/genex.o] Error 1
> make[1]: *** [arch/mips/kernel] Error 2
> make[1]: *** Waiting for unfinished jobs....
>
> Use _ehb which properly substitutes to a nop or a real ehb depending on
> the processor we are building for.
>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
Yep that looks good to me. Thanks for fixing it
Reviewed-by: Markos Chandras <markos.chandras@imgtec.com>
--
markos
next prev parent reply other threads:[~2013-10-28 14:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-25 18:26 [PATCH mips-for-linux-next] MIPS: fix genex.S build for non MIPS32r2 class processors Florian Fainelli
2013-10-28 14:36 ` Markos Chandras [this message]
2013-10-28 14:36 ` Markos Chandras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=526E7673.6050308@imgtec.com \
--to=markos.chandras@imgtec.com \
--cc=Leonid.Yegoshin@imgtec.com \
--cc=blogic@openwrt.org \
--cc=f.fainelli@gmail.com \
--cc=jim2101024@gmail.com \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox