Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: Markos Chandras <Markos.Chandras@imgtec.com>
To: David Daney <ddaney.cavm@gmail.com>
Cc: <linux-mips@linux-mips.org>,
	Leonid Yegoshin <Leonid.Yegoshin@imgtec.com>
Subject: Re: [PATCH 4/6] MIPS: mm: Use the TLBINVF instruction to flush the VTLB
Date: Tue, 12 Nov 2013 09:40:08 +0000	[thread overview]
Message-ID: <5281F778.2050004@imgtec.com> (raw)
In-Reply-To: <528139B1.9010909@gmail.com>

On 11/11/2013 08:10 PM, David Daney wrote:
> On 11/07/2013 09:08 AM, Markos Chandras wrote:
>> From: Leonid Yegoshin <Leonid.Yegoshin@imgtec.com>
>>
>> The TLBINVF instruction can be used to flush the entire VTLB.
>> This eliminates the need for the TLBWI loop and improves performance.
>>
>> Reviewed-by: Paul Burton <paul.burton@imgtec.com>
>> Signed-off-by: Leonid Yegoshin <Leonid.Yegoshin@imgtec.com>
>> Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
>
>
> This should be split into two patches.  One for each file.
>
> Also...

Hi David,

But it is a single functional change. I believe it makes sense
to have it in a single commit.

-- 
markos

WARNING: multiple messages have this Message-ID (diff)
From: Markos Chandras <Markos.Chandras@imgtec.com>
To: David Daney <ddaney.cavm@gmail.com>
Cc: linux-mips@linux-mips.org, Leonid Yegoshin <Leonid.Yegoshin@imgtec.com>
Subject: Re: [PATCH 4/6] MIPS: mm: Use the TLBINVF instruction to flush the VTLB
Date: Tue, 12 Nov 2013 09:40:08 +0000	[thread overview]
Message-ID: <5281F778.2050004@imgtec.com> (raw)
Message-ID: <20131112094008.2JkOSippqEADGJZxhu5os0cF288Hgnl8k3PPAqSJhNk@z> (raw)
In-Reply-To: <528139B1.9010909@gmail.com>

On 11/11/2013 08:10 PM, David Daney wrote:
> On 11/07/2013 09:08 AM, Markos Chandras wrote:
>> From: Leonid Yegoshin <Leonid.Yegoshin@imgtec.com>
>>
>> The TLBINVF instruction can be used to flush the entire VTLB.
>> This eliminates the need for the TLBWI loop and improves performance.
>>
>> Reviewed-by: Paul Burton <paul.burton@imgtec.com>
>> Signed-off-by: Leonid Yegoshin <Leonid.Yegoshin@imgtec.com>
>> Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
>
>
> This should be split into two patches.  One for each file.
>
> Also...

Hi David,

But it is a single functional change. I believe it makes sense
to have it in a single commit.

-- 
markos

  parent reply	other threads:[~2013-11-12  9:40 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-07 17:08 [PATCH 0/6] Add support for the proAptiv core Markos Chandras
2013-11-07 17:08 ` Markos Chandras
2013-11-07 17:08 ` [PATCH 1/6] MIPS: Add missing bits for Config registers Markos Chandras
2013-11-07 17:08   ` Markos Chandras
2013-11-11 20:00   ` David Daney
2013-11-07 17:08 ` [PATCH 2/6] MIPS: mm: Move UNIQUE_ENTRYHI macro to a header file Markos Chandras
2013-11-07 17:08   ` Markos Chandras
2013-11-07 17:08 ` [PATCH 3/6] MIPS: Add support for the proAptiv cores Markos Chandras
2013-11-07 17:08   ` Markos Chandras
2013-11-11 19:59   ` David Daney
2013-11-12  9:41     ` Markos Chandras
2013-11-12  9:41       ` Markos Chandras
2013-11-07 17:08 ` [PATCH 4/6] MIPS: mm: Use the TLBINVF instruction to flush the VTLB Markos Chandras
2013-11-07 17:08   ` Markos Chandras
2013-11-11 20:10   ` David Daney
2013-11-11 20:55     ` Leonid Yegoshin
2013-11-11 20:55       ` Leonid Yegoshin
2013-11-12  9:40     ` Markos Chandras [this message]
2013-11-12  9:40       ` Markos Chandras
2013-11-07 17:08 ` [PATCH 5/6] MIPS: Add support for FTLBs Markos Chandras
2013-11-07 17:08   ` Markos Chandras
2013-11-07 17:08 ` [PATCH 6/6] MIPS: Add debugfs file to print the segmentation control registers Markos Chandras
2013-11-07 17:08   ` Markos Chandras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5281F778.2050004@imgtec.com \
    --to=markos.chandras@imgtec.com \
    --cc=Leonid.Yegoshin@imgtec.com \
    --cc=ddaney.cavm@gmail.com \
    --cc=linux-mips@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox