[PATCH 1/7] arch/mips/lantiq/xway: don't check resource with devm_ioremap_resource

[PATCH 1/7] arch/mips/lantiq/xway: don't check resource with devm_ioremap_resource

[Wolfram Sang]

devm_ioremap_resource does sanity checks on the given resource. No need to
duplicate this in the driver.

Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
Acked-by: John Crispin <blogic@openwrt.org>
---

Should go via subsystem tree

 arch/mips/lantiq/xway/dma.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/arch/mips/lantiq/xway/dma.c b/arch/mips/lantiq/xway/dma.c
index 08f7ebd..78a91fa 100644
--- a/arch/mips/lantiq/xway/dma.c
+++ b/arch/mips/lantiq/xway/dma.c
@@ -220,10 +220,6 @@ ltq_dma_init(struct platform_device *pdev)
 	int i;
 
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	if (!res)
-		panic("Failed to get dma resource");
-
-	/* remap dma register range */
 	ltq_dma_membase = devm_ioremap_resource(&pdev->dev, res);
 	if (IS_ERR(ltq_dma_membase))
 		panic("Failed to remap dma resource");
-- 
1.8.5.1

[PATCH 6/7] arch/mips/pci: don't check resource with devm_ioremap_resource

[Wolfram Sang]

devm_ioremap_resource does sanity checks on the given resource. No need to
duplicate this in the driver.

Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
---

Should go via subsystem tree

 arch/mips/pci/pci-rt3883.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/arch/mips/pci/pci-rt3883.c b/arch/mips/pci/pci-rt3883.c
index adeff2b..72919ae 100644
--- a/arch/mips/pci/pci-rt3883.c
+++ b/arch/mips/pci/pci-rt3883.c
@@ -436,9 +436,6 @@ static int rt3883_pci_probe(struct platform_device *pdev)
 		return -ENOMEM;
 
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	if (!res)
-		return -EINVAL;
-
 	rpc->base = devm_ioremap_resource(dev, res);
 	if (IS_ERR(rpc->base))
 		return PTR_ERR(rpc->base);
-- 
1.8.5.1

Re: [PATCH 1/7] arch/mips/lantiq/xway: don't check resource with devm_ioremap_resource

[John Crispin]

Hi Wolfgang,

should we take 1/7 and 6/7 via the mips tree ?

    John


On 14/01/2014 12:58, Wolfram Sang wrote:
> devm_ioremap_resource does sanity checks on the given resource. No need to
> duplicate this in the driver.
>
> Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
> Acked-by: John Crispin <blogic@openwrt.org>
> ---
>
> Should go via subsystem tree
>
>  arch/mips/lantiq/xway/dma.c | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/arch/mips/lantiq/xway/dma.c b/arch/mips/lantiq/xway/dma.c
> index 08f7ebd..78a91fa 100644
> --- a/arch/mips/lantiq/xway/dma.c
> +++ b/arch/mips/lantiq/xway/dma.c
> @@ -220,10 +220,6 @@ ltq_dma_init(struct platform_device *pdev)
>  	int i;
>  
>  	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	if (!res)
> -		panic("Failed to get dma resource");
> -
> -	/* remap dma register range */
>  	ltq_dma_membase = devm_ioremap_resource(&pdev->dev, res);
>  	if (IS_ERR(ltq_dma_membase))
>  		panic("Failed to remap dma resource");

Re: [PATCH 1/7] arch/mips/lantiq/xway: don't check resource with devm_ioremap_resource

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 216 bytes --]

Hi,

On Tue, Jan 14, 2014 at 01:03:34PM +0100, John Crispin wrote:
> Hi Wolfgang,

Wolfram, please...

> should we take 1/7 and 6/7 via the mips tree ?

> > Should go via subsystem tree

Yes :)

Thanks,

   Wolfram


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH 1/7] arch/mips/lantiq/xway: don't check resource with devm_ioremap_resource

[John Crispin]

[-- Attachment #1: Type: text/plain, Size: 325 bytes --]

Hi Wolfram,

>> > Hi Wolfgang,
> Wolfram, please...

-EFAIL .... i was on the phone with a Wolfgang for several hours today :)
i know you are called Wolfram ... sorry

>> > should we take 1/7 and 6/7 via the mips tree ?
>>> > > Should go via subsystem tree
> Yes :)
>

OK, I'll pull them into my mips-next tree now

    John

[-- Attachment #2: Type: text/html, Size: 1736 bytes --]