* [RFC V2][PATCH] MIPS: BCM47XX: Add new file for device specific workarounds
@ 2014-02-01 20:32 Rafał Miłecki
2014-03-02 16:34 ` Hauke Mehrtens
2014-03-21 9:08 ` [PATCH V3] " Rafał Miłecki
0 siblings, 2 replies; 3+ messages in thread
From: Rafał Miłecki @ 2014-02-01 20:32 UTC (permalink / raw)
To: linux-mips, Ralf Baechle; +Cc: Hauke Mehrtens, Rafał Miłecki
---
V2: Drop pr_debug for devices we don't need workarounds for. It was too
load and not useful at all.
---
arch/mips/bcm47xx/Makefile | 2 +-
arch/mips/bcm47xx/bcm47xx_private.h | 3 +++
arch/mips/bcm47xx/setup.c | 1 +
arch/mips/bcm47xx/workarounds.c | 25 +++++++++++++++++++++++++
4 files changed, 30 insertions(+), 1 deletion(-)
create mode 100644 arch/mips/bcm47xx/workarounds.c
diff --git a/arch/mips/bcm47xx/Makefile b/arch/mips/bcm47xx/Makefile
index 4688b6a..d58c51b 100644
--- a/arch/mips/bcm47xx/Makefile
+++ b/arch/mips/bcm47xx/Makefile
@@ -4,4 +4,4 @@
#
obj-y += irq.o nvram.o prom.o serial.o setup.o time.o sprom.o
-obj-y += board.o buttons.o leds.o
+obj-y += board.o buttons.o leds.o workarounds.o
diff --git a/arch/mips/bcm47xx/bcm47xx_private.h b/arch/mips/bcm47xx/bcm47xx_private.h
index 5c94ace..0194c3b 100644
--- a/arch/mips/bcm47xx/bcm47xx_private.h
+++ b/arch/mips/bcm47xx/bcm47xx_private.h
@@ -9,4 +9,7 @@ int __init bcm47xx_buttons_register(void);
/* leds.c */
void __init bcm47xx_leds_register(void);
+/* workarounds.c */
+void __init bcm47xx_workarounds(void);
+
#endif
diff --git a/arch/mips/bcm47xx/setup.c b/arch/mips/bcm47xx/setup.c
index 12d77e9..fdd9692 100644
--- a/arch/mips/bcm47xx/setup.c
+++ b/arch/mips/bcm47xx/setup.c
@@ -273,6 +273,7 @@ static int __init bcm47xx_register_bus_complete(void)
}
bcm47xx_buttons_register();
bcm47xx_leds_register();
+ bcm47xx_workarounds();
return 0;
}
diff --git a/arch/mips/bcm47xx/workarounds.c b/arch/mips/bcm47xx/workarounds.c
new file mode 100644
index 0000000..24b850c
--- /dev/null
+++ b/arch/mips/bcm47xx/workarounds.c
@@ -0,0 +1,25 @@
+#include "bcm47xx_private.h"
+
+#include <linux/gpio.h>
+#include <bcm47xx_board.h>
+#include <bcm47xx.h>
+
+static void __init bcm47xx_workarounds_netgear_wnr3500l(void)
+{
+ /* Set GPIO 12 to 1 to pass power to the USB port */
+ gpio_set_value(12, 1);
+}
+
+void __init bcm47xx_workarounds(void)
+{
+ enum bcm47xx_board board = bcm47xx_board_get();
+
+ switch (board) {
+ case BCM47XX_BOARD_NETGEAR_WNR3500L:
+ bcm47xx_workarounds_netgear_wnr3500l();
+ break;
+ default:
+ /* No workaround(s) needed */
+ break;
+ }
+}
--
1.8.4.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [RFC V2][PATCH] MIPS: BCM47XX: Add new file for device specific workarounds
2014-02-01 20:32 [RFC V2][PATCH] MIPS: BCM47XX: Add new file for device specific workarounds Rafał Miłecki
@ 2014-03-02 16:34 ` Hauke Mehrtens
2014-03-21 9:08 ` [PATCH V3] " Rafał Miłecki
1 sibling, 0 replies; 3+ messages in thread
From: Hauke Mehrtens @ 2014-03-02 16:34 UTC (permalink / raw)
To: Rafał Miłecki; +Cc: linux-mips, Ralf Baechle
On 02/01/2014 09:32 PM, Rafał Miłecki wrote:
> ---
> V2: Drop pr_debug for devices we don't need workarounds for. It was too
> load and not useful at all.
> ---
This looks good to me, feel free to add my Acked-By. You have to send it
with a Signed-off-by line.
Hauke
> arch/mips/bcm47xx/Makefile | 2 +-
> arch/mips/bcm47xx/bcm47xx_private.h | 3 +++
> arch/mips/bcm47xx/setup.c | 1 +
> arch/mips/bcm47xx/workarounds.c | 25 +++++++++++++++++++++++++
> 4 files changed, 30 insertions(+), 1 deletion(-)
> create mode 100644 arch/mips/bcm47xx/workarounds.c
>
> diff --git a/arch/mips/bcm47xx/Makefile b/arch/mips/bcm47xx/Makefile
> index 4688b6a..d58c51b 100644
> --- a/arch/mips/bcm47xx/Makefile
> +++ b/arch/mips/bcm47xx/Makefile
> @@ -4,4 +4,4 @@
> #
>
> obj-y += irq.o nvram.o prom.o serial.o setup.o time.o sprom.o
> -obj-y += board.o buttons.o leds.o
> +obj-y += board.o buttons.o leds.o workarounds.o
> diff --git a/arch/mips/bcm47xx/bcm47xx_private.h b/arch/mips/bcm47xx/bcm47xx_private.h
> index 5c94ace..0194c3b 100644
> --- a/arch/mips/bcm47xx/bcm47xx_private.h
> +++ b/arch/mips/bcm47xx/bcm47xx_private.h
> @@ -9,4 +9,7 @@ int __init bcm47xx_buttons_register(void);
> /* leds.c */
> void __init bcm47xx_leds_register(void);
>
> +/* workarounds.c */
> +void __init bcm47xx_workarounds(void);
> +
> #endif
> diff --git a/arch/mips/bcm47xx/setup.c b/arch/mips/bcm47xx/setup.c
> index 12d77e9..fdd9692 100644
> --- a/arch/mips/bcm47xx/setup.c
> +++ b/arch/mips/bcm47xx/setup.c
> @@ -273,6 +273,7 @@ static int __init bcm47xx_register_bus_complete(void)
> }
> bcm47xx_buttons_register();
> bcm47xx_leds_register();
> + bcm47xx_workarounds();
>
> return 0;
> }
> diff --git a/arch/mips/bcm47xx/workarounds.c b/arch/mips/bcm47xx/workarounds.c
> new file mode 100644
> index 0000000..24b850c
> --- /dev/null
> +++ b/arch/mips/bcm47xx/workarounds.c
> @@ -0,0 +1,25 @@
> +#include "bcm47xx_private.h"
> +
> +#include <linux/gpio.h>
> +#include <bcm47xx_board.h>
> +#include <bcm47xx.h>
> +
> +static void __init bcm47xx_workarounds_netgear_wnr3500l(void)
> +{
> + /* Set GPIO 12 to 1 to pass power to the USB port */
> + gpio_set_value(12, 1);
> +}
> +
> +void __init bcm47xx_workarounds(void)
> +{
> + enum bcm47xx_board board = bcm47xx_board_get();
> +
> + switch (board) {
> + case BCM47XX_BOARD_NETGEAR_WNR3500L:
> + bcm47xx_workarounds_netgear_wnr3500l();
> + break;
> + default:
> + /* No workaround(s) needed */
> + break;
> + }
> +}
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH V3] MIPS: BCM47XX: Add new file for device specific workarounds
2014-02-01 20:32 [RFC V2][PATCH] MIPS: BCM47XX: Add new file for device specific workarounds Rafał Miłecki
2014-03-02 16:34 ` Hauke Mehrtens
@ 2014-03-21 9:08 ` Rafał Miłecki
1 sibling, 0 replies; 3+ messages in thread
From: Rafał Miłecki @ 2014-03-21 9:08 UTC (permalink / raw)
To: linux-mips, Ralf Baechle; +Cc: Hauke Mehrtens, Rafał Miłecki
Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
---
V2: Drop pr_debug for devices we don't need workarounds for. It was too
load and not useful at all.
V3: Use gpio_request_one in WNR3500L workaround. In V2 we were directly
calling gpio_set_value, which doesn't guarantee GPIO to be in OUT
direction.
Hauke: does V3 still get your ack?
---
arch/mips/bcm47xx/Makefile | 2 +-
arch/mips/bcm47xx/bcm47xx_private.h | 3 +++
arch/mips/bcm47xx/setup.c | 1 +
arch/mips/bcm47xx/workarounds.c | 31 +++++++++++++++++++++++++++++++
4 files changed, 36 insertions(+), 1 deletion(-)
create mode 100644 arch/mips/bcm47xx/workarounds.c
diff --git a/arch/mips/bcm47xx/Makefile b/arch/mips/bcm47xx/Makefile
index 4688b6a..d58c51b 100644
--- a/arch/mips/bcm47xx/Makefile
+++ b/arch/mips/bcm47xx/Makefile
@@ -4,4 +4,4 @@
#
obj-y += irq.o nvram.o prom.o serial.o setup.o time.o sprom.o
-obj-y += board.o buttons.o leds.o
+obj-y += board.o buttons.o leds.o workarounds.o
diff --git a/arch/mips/bcm47xx/bcm47xx_private.h b/arch/mips/bcm47xx/bcm47xx_private.h
index 5c94ace..0194c3b 100644
--- a/arch/mips/bcm47xx/bcm47xx_private.h
+++ b/arch/mips/bcm47xx/bcm47xx_private.h
@@ -9,4 +9,7 @@ int __init bcm47xx_buttons_register(void);
/* leds.c */
void __init bcm47xx_leds_register(void);
+/* workarounds.c */
+void __init bcm47xx_workarounds(void);
+
#endif
diff --git a/arch/mips/bcm47xx/setup.c b/arch/mips/bcm47xx/setup.c
index b847d03..63a4b0e 100644
--- a/arch/mips/bcm47xx/setup.c
+++ b/arch/mips/bcm47xx/setup.c
@@ -282,6 +282,7 @@ static int __init bcm47xx_register_bus_complete(void)
}
bcm47xx_buttons_register();
bcm47xx_leds_register();
+ bcm47xx_workarounds();
fixed_phy_add(PHY_POLL, 0, &bcm47xx_fixed_phy_status);
return 0;
diff --git a/arch/mips/bcm47xx/workarounds.c b/arch/mips/bcm47xx/workarounds.c
new file mode 100644
index 0000000..e81ce46
--- /dev/null
+++ b/arch/mips/bcm47xx/workarounds.c
@@ -0,0 +1,31 @@
+#include "bcm47xx_private.h"
+
+#include <linux/gpio.h>
+#include <bcm47xx_board.h>
+#include <bcm47xx.h>
+
+static void __init bcm47xx_workarounds_netgear_wnr3500l(void)
+{
+ const int usb_power = 12;
+ int err;
+
+ err = gpio_request_one(usb_power, GPIOF_OUT_INIT_HIGH, "usb_power");
+ if (err)
+ pr_err("Failed to request USB power gpio: %d\n", err);
+ else
+ gpio_free(usb_power);
+}
+
+void __init bcm47xx_workarounds(void)
+{
+ enum bcm47xx_board board = bcm47xx_board_get();
+
+ switch (board) {
+ case BCM47XX_BOARD_NETGEAR_WNR3500L:
+ bcm47xx_workarounds_netgear_wnr3500l();
+ break;
+ default:
+ /* No workaround(s) needed */
+ break;
+ }
+}
--
1.8.4.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-03-21 9:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-01 20:32 [RFC V2][PATCH] MIPS: BCM47XX: Add new file for device specific workarounds Rafał Miłecki
2014-03-02 16:34 ` Hauke Mehrtens
2014-03-21 9:08 ` [PATCH V3] " Rafał Miłecki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox