Re: [PATCH v2] MIPS: Fix syscall tracing interface

[Markos Chandras <Markos.Chandras@imgtec.com>]

Hi Lars,

On 03/17/2014 11:14 AM, Lars Persson wrote:
> Fix pointer computation for stack-based arguments.
>
> Signed-off-by: Lars Persson <larper@axis.com>
> ---
>   arch/mips/include/asm/syscall.h |    4 ++--
>   1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/mips/include/asm/syscall.h b/arch/mips/include/asm/syscall.h
> index c71e40a..6c488c8 100644
> --- a/arch/mips/include/asm/syscall.h
> +++ b/arch/mips/include/asm/syscall.h
> @@ -51,14 +51,14 @@ static inline unsigned long mips_get_syscall_arg(unsigned long *arg,
>
>   #ifdef CONFIG_32BIT
>   	case 4: case 5: case 6: case 7:
> -		return get_user(*arg, (int *)usp + 4 * n);
> +		return get_user(*arg, (int *)usp + n);
>   #endif
>
>   #ifdef CONFIG_64BIT
>   	case 4: case 5: case 6: case 7:
>   #ifdef CONFIG_MIPS32_O32
>   		if (test_thread_flag(TIF_32BIT_REGS))
> -			return get_user(*arg, (int *)usp + 4 * n);
> +			return get_user(*arg, (int *)usp + n);
>   		else
>   #endif
>   			*arg = regs->regs[4 + n];
>

Thanks for the v2.

It looks good to me but I haven't tested it.

Reviewed-by: Markos Chandras <markos.chandras@imgtec.com>

-- 
markos