From: David Daney <ddaney@caviumnetworks.com>
To: <Wei.Yang@windriver.com>
Cc: <david.daney@cavium.com>, <ralf@linux-mips.org>,
<linux-mips@linux-mips.org>,
Andreas Herrmann <andreas.herrmann@caviumnetworks.com>
Subject: Re: [PATCH] mips/octeon_3xxx: Fix a warning on octeon_3xxx
Date: Mon, 17 Mar 2014 13:37:35 -0700 [thread overview]
Message-ID: <53275D0F.8030106@caviumnetworks.com> (raw)
In-Reply-To: <1395036414-20581-1-git-send-email-Wei.Yang@windriver.com>
On 03/16/2014 11:06 PM, Wei.Yang@windriver.com wrote:
> From: Yang Wei <Wei.Yang@windriver.com>
>
> Since the xlate of interrupts property of GPIO on octeon 3xxx
> does not success, so the following warning would be triggerred
> while invoking of_device_alloc to create platform device.
> So we need to remove it to avoid the warning.
>
> WARNING: CPU: 1 PID: 1 at drivers/of/platform.c:173 of_device_alloc+0x294/0x2a0()
> Modules linked in:
> CPU: 1 PID: 1 Comm: swapper/0 Not tainted 3.14.0-rc6- #11
> Stack : ffffffff81a20000 0000000000000001 0000000000000004 ffffffff81b50000
> 0000000000000001 0000000000000000 0000000000000000 ffffffff8119e878
> ffffffff81a20000 ffffffff8119ee98 0000000000000000 0000000000000000
> ffffffff81b30000 ffffffff81b20000 ffffffff81932900 ffffffff81a11077
> ffffffff81b27a08 800000041f8704a8 0000000000000001 0000000000000001
> 0000000000000000 800000041fbf7438 0000000000000001 ffffffff81800d90
> 800000041f85fa68 ffffffff8114a60c 0000000000000000 ffffffff811a0838
> 800000041f870000 800000041f85f980 0000000000000001 ffffffff81805080
> 0000000000000000 0000000000000000 0000000000000000 0000000000000000
> 0000000000000000 ffffffff81122620 0000000000000000 0000000000000000
> ...
> Call Trace:
> [<ffffffff81122620>] show_stack+0xc0/0xe0
> [<ffffffff81805080>] dump_stack+0x8c/0xe0
> [<ffffffff8114a7ac>] warn_slowpath_common+0x94/0xc8
> [<ffffffff81693b1c>] of_device_alloc+0x294/0x2a0
> [<ffffffff81693b74>] of_platform_device_create_pdata+0x4c/0xf0
> [<ffffffff81693d58>] of_platform_bus_create+0x128/0x1a8
> [<ffffffff81693da0>] of_platform_bus_create+0x170/0x1a8
> [<ffffffff81693e8c>] of_platform_bus_probe+0xb4/0x110
> [<ffffffff81100598>] do_one_initcall+0xe8/0x130
> [<ffffffff81a92c5c>] kernel_init_freeable+0x1d4/0x2bc
> [<ffffffff817fe140>] kernel_init+0x20/0x118
> [<ffffffff8111d024>] ret_from_kernel_thread+0x14/0x1c
>
> Signed-off-by: Yang Wei <Wei.Yang@windriver.com>
NACK!
> ---
> arch/mips/cavium-octeon/octeon_3xxx.dts | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/arch/mips/cavium-octeon/octeon_3xxx.dts b/arch/mips/cavium-octeon/octeon_3xxx.dts
> index fa33115..9fe94d5 100644
> --- a/arch/mips/cavium-octeon/octeon_3xxx.dts
> +++ b/arch/mips/cavium-octeon/octeon_3xxx.dts
> @@ -43,11 +43,6 @@
> */
> interrupt-controller;
> #interrupt-cells = <2>;
> - /* The GPIO pin connect to 16 consecutive CUI bits */
> - interrupts = <0 16>, <0 17>, <0 18>, <0 19>,
> - <0 20>, <0 21>, <0 22>, <0 23>,
> - <0 24>, <0 25>, <0 26>, <0 27>,
> - <0 28>, <0 29>, <0 30>, <0 31>;
On many boards, the device tree is supplied by the bootloader. So
changing the in-kernel device tree that is only used with old "legacy"
bootloaders, will not correct the problem for boards with newer bootloaders.
I think the proper fix is to modify octeon-irq.c so that it doesn't try
to reserve these numbers. We may work on a patch that takes this approach.
David Daney
> };
>
> smi0: mdio@1180000001800 {
>
WARNING: multiple messages have this Message-ID (diff)
From: David Daney <ddaney@caviumnetworks.com>
To: Wei.Yang@windriver.com
Cc: david.daney@cavium.com, ralf@linux-mips.org,
linux-mips@linux-mips.org,
Andreas Herrmann <andreas.herrmann@caviumnetworks.com>
Subject: Re: [PATCH] mips/octeon_3xxx: Fix a warning on octeon_3xxx
Date: Mon, 17 Mar 2014 13:37:35 -0700 [thread overview]
Message-ID: <53275D0F.8030106@caviumnetworks.com> (raw)
Message-ID: <20140317203735.w872iB3ER9OsxUy2MEkMfsin9zkNzwtv0svfwvnclMs@z> (raw)
In-Reply-To: <1395036414-20581-1-git-send-email-Wei.Yang@windriver.com>
On 03/16/2014 11:06 PM, Wei.Yang@windriver.com wrote:
> From: Yang Wei <Wei.Yang@windriver.com>
>
> Since the xlate of interrupts property of GPIO on octeon 3xxx
> does not success, so the following warning would be triggerred
> while invoking of_device_alloc to create platform device.
> So we need to remove it to avoid the warning.
>
> WARNING: CPU: 1 PID: 1 at drivers/of/platform.c:173 of_device_alloc+0x294/0x2a0()
> Modules linked in:
> CPU: 1 PID: 1 Comm: swapper/0 Not tainted 3.14.0-rc6- #11
> Stack : ffffffff81a20000 0000000000000001 0000000000000004 ffffffff81b50000
> 0000000000000001 0000000000000000 0000000000000000 ffffffff8119e878
> ffffffff81a20000 ffffffff8119ee98 0000000000000000 0000000000000000
> ffffffff81b30000 ffffffff81b20000 ffffffff81932900 ffffffff81a11077
> ffffffff81b27a08 800000041f8704a8 0000000000000001 0000000000000001
> 0000000000000000 800000041fbf7438 0000000000000001 ffffffff81800d90
> 800000041f85fa68 ffffffff8114a60c 0000000000000000 ffffffff811a0838
> 800000041f870000 800000041f85f980 0000000000000001 ffffffff81805080
> 0000000000000000 0000000000000000 0000000000000000 0000000000000000
> 0000000000000000 ffffffff81122620 0000000000000000 0000000000000000
> ...
> Call Trace:
> [<ffffffff81122620>] show_stack+0xc0/0xe0
> [<ffffffff81805080>] dump_stack+0x8c/0xe0
> [<ffffffff8114a7ac>] warn_slowpath_common+0x94/0xc8
> [<ffffffff81693b1c>] of_device_alloc+0x294/0x2a0
> [<ffffffff81693b74>] of_platform_device_create_pdata+0x4c/0xf0
> [<ffffffff81693d58>] of_platform_bus_create+0x128/0x1a8
> [<ffffffff81693da0>] of_platform_bus_create+0x170/0x1a8
> [<ffffffff81693e8c>] of_platform_bus_probe+0xb4/0x110
> [<ffffffff81100598>] do_one_initcall+0xe8/0x130
> [<ffffffff81a92c5c>] kernel_init_freeable+0x1d4/0x2bc
> [<ffffffff817fe140>] kernel_init+0x20/0x118
> [<ffffffff8111d024>] ret_from_kernel_thread+0x14/0x1c
>
> Signed-off-by: Yang Wei <Wei.Yang@windriver.com>
NACK!
> ---
> arch/mips/cavium-octeon/octeon_3xxx.dts | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/arch/mips/cavium-octeon/octeon_3xxx.dts b/arch/mips/cavium-octeon/octeon_3xxx.dts
> index fa33115..9fe94d5 100644
> --- a/arch/mips/cavium-octeon/octeon_3xxx.dts
> +++ b/arch/mips/cavium-octeon/octeon_3xxx.dts
> @@ -43,11 +43,6 @@
> */
> interrupt-controller;
> #interrupt-cells = <2>;
> - /* The GPIO pin connect to 16 consecutive CUI bits */
> - interrupts = <0 16>, <0 17>, <0 18>, <0 19>,
> - <0 20>, <0 21>, <0 22>, <0 23>,
> - <0 24>, <0 25>, <0 26>, <0 27>,
> - <0 28>, <0 29>, <0 30>, <0 31>;
On many boards, the device tree is supplied by the bootloader. So
changing the in-kernel device tree that is only used with old "legacy"
bootloaders, will not correct the problem for boards with newer bootloaders.
I think the proper fix is to modify octeon-irq.c so that it doesn't try
to reserve these numbers. We may work on a patch that takes this approach.
David Daney
> };
>
> smi0: mdio@1180000001800 {
>
next prev parent reply other threads:[~2014-03-17 20:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-17 6:06 [PATCH] mips/octeon_3xxx: Fix a warning on octeon_3xxx Wei.Yang
2014-03-17 6:06 ` Wei.Yang
2014-03-17 20:37 ` David Daney [this message]
2014-03-17 20:37 ` David Daney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53275D0F.8030106@caviumnetworks.com \
--to=ddaney@caviumnetworks.com \
--cc=Wei.Yang@windriver.com \
--cc=andreas.herrmann@caviumnetworks.com \
--cc=david.daney@cavium.com \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox