From: Markos Chandras <Markos.Chandras@imgtec.com>
To: Jeffrey Deans <jeffrey.deans@imgtec.com>,
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
<linux-mips@linux-mips.org>
Subject: Re: [PATCH 7/7] MIPS: GIC: Fix GICBIS macro
Date: Fri, 18 Jul 2014 11:05:40 +0100 [thread overview]
Message-ID: <53C8F174.70603@imgtec.com> (raw)
In-Reply-To: <53C8D2AE.3020300@imgtec.com>
On 07/18/2014 08:54 AM, Jeffrey Deans wrote:
>
>>
>>> + data &= ~(mask); \
>>> + data |= ((bits) & (mask)); \
>>
>> Outer () not needed.
>
> Agreed.
>
Thanks for the review. This is a minor fix and I see no reason for v2.
Ralf could you please remove the outer () when you get to apply this patch?
Thanks!
--
markos
WARNING: multiple messages have this Message-ID (diff)
From: Markos Chandras <Markos.Chandras@imgtec.com>
To: Jeffrey Deans <jeffrey.deans@imgtec.com>,
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
linux-mips@linux-mips.org
Subject: Re: [PATCH 7/7] MIPS: GIC: Fix GICBIS macro
Date: Fri, 18 Jul 2014 11:05:40 +0100 [thread overview]
Message-ID: <53C8F174.70603@imgtec.com> (raw)
Message-ID: <20140718100540.ut-lOfcFriorcqFMdbFr63A_32BRdQaNdNFvcYsQf1I@z> (raw)
In-Reply-To: <53C8D2AE.3020300@imgtec.com>
On 07/18/2014 08:54 AM, Jeffrey Deans wrote:
>
>>
>>> + data &= ~(mask); \
>>> + data |= ((bits) & (mask)); \
>>
>> Outer () not needed.
>
> Agreed.
>
Thanks for the review. This is a minor fix and I see no reason for v2.
Ralf could you please remove the outer () when you get to apply this patch?
Thanks!
--
markos
next prev parent reply other threads:[~2014-07-18 10:05 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-17 8:20 [PATCH 0/7] Misc GIC fixes Markos Chandras
2014-07-17 8:20 ` Markos Chandras
2014-07-17 8:20 ` [PATCH 1/7] MIPS: GIC: move GIC interrupt bitmap declarations Markos Chandras
2014-07-17 8:20 ` Markos Chandras
2014-07-17 8:20 ` [PATCH 2/7] MIPS: GIC: Move GIC_NUM_INTRS into platform irq.h Markos Chandras
2014-07-17 8:20 ` Markos Chandras
2014-07-17 8:20 ` [PATCH 3/7] MIPS: GIC: Remove GIC_FLAG_IPI Markos Chandras
2014-07-17 8:20 ` Markos Chandras
2014-07-17 8:20 ` [PATCH 4/7] MIPS: GIC: Prevent array overrun Markos Chandras
2014-07-17 8:20 ` Markos Chandras
2014-07-17 8:20 ` [PATCH 5/7] MIPS: GIC: Generalise check for pending interrupts Markos Chandras
2014-07-17 8:20 ` Markos Chandras
2014-07-17 8:20 ` [PATCH 6/7] MIPS: Malta: Fix dispatching of GIC interrupts Markos Chandras
2014-07-17 8:20 ` Markos Chandras
2014-08-04 22:57 ` Florian Fainelli
2014-07-17 8:20 ` [PATCH 7/7] MIPS: GIC: Fix GICBIS macro Markos Chandras
2014-07-17 8:20 ` Markos Chandras
2014-07-17 12:47 ` Sergei Shtylyov
2014-07-18 7:54 ` Jeffrey Deans
2014-07-18 7:54 ` Jeffrey Deans
2014-07-18 10:05 ` Markos Chandras [this message]
2014-07-18 10:05 ` Markos Chandras
2014-07-18 18:05 ` Sergei Shtylyov
2014-08-07 22:20 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53C8F174.70603@imgtec.com \
--to=markos.chandras@imgtec.com \
--cc=jeffrey.deans@imgtec.com \
--cc=linux-mips@linux-mips.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox