From: Markos Chandras <Markos.Chandras@imgtec.com>
To: Rob Kendrick <rob.kendrick@codethink.co.uk>
Cc: <linux-mips@linux-mips.org>, Ralf Baechle <ralf@linux-mips.org>
Subject: Re: EdgeRouter Pro supported? Strange FP problems
Date: Wed, 23 Jul 2014 10:06:38 +0100 [thread overview]
Message-ID: <53CF7B1E.9040903@imgtec.com> (raw)
In-Reply-To: <20140723090357.GN30723@humdrum>
On 07/23/2014 10:03 AM, Rob Kendrick wrote:
> On Tue, Jul 22, 2014 at 04:38:24PM +0100, Markos Chandras wrote:
>> a quick bisect between v3.15 and v3.16-rc1, which is the first tag with
>> all the new FPU changes, leads to the following bad commit:
>>
>> 08a07904e182895e1205f399465a3d622c0115b8
>> MIPS: math-emu: Remove most ifdefery.
>
> This appears to fix the problem:
>
> diff --git a/arch/mips/math-emu/cp1emu.c b/arch/mips/math-emu/cp1emu.c
> index 736c17a..bf0fc6b 100644
> --- a/arch/mips/math-emu/cp1emu.c
> +++ b/arch/mips/math-emu/cp1emu.c
> @@ -1827,7 +1827,7 @@ dcopuop:
> case -1:
>
> if (cpu_has_mips_4_5_r)
> - cbit = fpucondbit[MIPSInst_RT(ir) >> 2];
> + cbit = fpucondbit[MIPSInst_FD(ir) >> 2];
> else
> cbit = FPU_CSR_COND;
> if (rv.w)
>
> Sadly I am totally ignorant of kernel patch processes. What would be
> approach to having this properly submitted?
>
Hi Rob,
The patch looks correct. See this document for the process
https://www.kernel.org/doc/Documentation/SubmittingPatches
So in general, you need to create a patch using git-format-patch
and use git-send-email to send it to this mailing list.
--
markos
WARNING: multiple messages have this Message-ID (diff)
From: Markos Chandras <Markos.Chandras@imgtec.com>
To: Rob Kendrick <rob.kendrick@codethink.co.uk>
Cc: linux-mips@linux-mips.org, Ralf Baechle <ralf@linux-mips.org>
Subject: Re: EdgeRouter Pro supported? Strange FP problems
Date: Wed, 23 Jul 2014 10:06:38 +0100 [thread overview]
Message-ID: <53CF7B1E.9040903@imgtec.com> (raw)
Message-ID: <20140723090638.FGVftKG8_LqOVZoneEhsNrN2czjTFPSRLBSWBwyJZA0@z> (raw)
In-Reply-To: <20140723090357.GN30723@humdrum>
On 07/23/2014 10:03 AM, Rob Kendrick wrote:
> On Tue, Jul 22, 2014 at 04:38:24PM +0100, Markos Chandras wrote:
>> a quick bisect between v3.15 and v3.16-rc1, which is the first tag with
>> all the new FPU changes, leads to the following bad commit:
>>
>> 08a07904e182895e1205f399465a3d622c0115b8
>> MIPS: math-emu: Remove most ifdefery.
>
> This appears to fix the problem:
>
> diff --git a/arch/mips/math-emu/cp1emu.c b/arch/mips/math-emu/cp1emu.c
> index 736c17a..bf0fc6b 100644
> --- a/arch/mips/math-emu/cp1emu.c
> +++ b/arch/mips/math-emu/cp1emu.c
> @@ -1827,7 +1827,7 @@ dcopuop:
> case -1:
>
> if (cpu_has_mips_4_5_r)
> - cbit = fpucondbit[MIPSInst_RT(ir) >> 2];
> + cbit = fpucondbit[MIPSInst_FD(ir) >> 2];
> else
> cbit = FPU_CSR_COND;
> if (rv.w)
>
> Sadly I am totally ignorant of kernel patch processes. What would be
> approach to having this properly submitted?
>
Hi Rob,
The patch looks correct. See this document for the process
https://www.kernel.org/doc/Documentation/SubmittingPatches
So in general, you need to create a patch using git-format-patch
and use git-send-email to send it to this mailing list.
--
markos
next prev parent reply other threads:[~2014-07-23 9:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-22 13:06 EdgeRouter Pro supported? Strange FP problems Rob Kendrick
2014-07-22 14:21 ` Markos Chandras
2014-07-22 14:21 ` Markos Chandras
2014-07-22 14:33 ` Rob Kendrick
2014-07-22 15:38 ` Markos Chandras
2014-07-22 15:38 ` Markos Chandras
2014-07-22 15:49 ` Rob Kendrick
2014-07-22 18:41 ` Aaro Koskinen
2014-07-23 9:03 ` Rob Kendrick
2014-07-23 9:06 ` Markos Chandras [this message]
2014-07-23 9:06 ` Markos Chandras
2014-07-22 15:26 ` John Crispin
2014-07-23 7:03 ` Rob Kendrick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53CF7B1E.9040903@imgtec.com \
--to=markos.chandras@imgtec.com \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=rob.kendrick@codethink.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox