[PATCH 1/5] mips: Set CONFIG_NET=y in defconfigs

Linux MIPS Architecture development
 help / color / mirror / Atom feed

* [PATCH 1/5] mips: Set CONFIG_NET=y in defconfigs
       [not found] <54218AEF.5090200@suse.cz>
@ 2014-09-23 15:44 ` Michal Marek
  2014-09-23 16:02   ` David Miller
  0 siblings, 1 reply; 3+ messages in thread
From: Michal Marek @ 2014-09-23 15:44 UTC (permalink / raw)
  To: sfr, rdunlap, davem
  Cc: netdev, linux-next, linux-kernel, linux-kbuild, linux-mips

Commit 5d6be6a5 ("scsi_netlink : Make SCSI_NETLINK dependent on NET
instead of selecting NET") removed what happened to be the only instance
of 'select NET'. Defconfigs that were relying on the select now lack
networking support.

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linux-mips@linux-mips.org
Signed-off-by: Michal Marek <mmarek@suse.cz>
---
 arch/mips/configs/gpr_defconfig             | 1 +
 arch/mips/configs/ip27_defconfig            | 1 +
 arch/mips/configs/jazz_defconfig            | 1 +
 arch/mips/configs/loongson3_defconfig       | 1 +
 arch/mips/configs/malta_defconfig           | 1 +
 arch/mips/configs/malta_kvm_defconfig       | 1 +
 arch/mips/configs/malta_kvm_guest_defconfig | 1 +
 arch/mips/configs/mtx1_defconfig            | 1 +
 arch/mips/configs/rm200_defconfig           | 1 +
 9 files changed, 9 insertions(+)

diff --git a/arch/mips/configs/gpr_defconfig b/arch/mips/configs/gpr_defconfig
index 8f219da..e24feb06 100644
--- a/arch/mips/configs/gpr_defconfig
+++ b/arch/mips/configs/gpr_defconfig
@@ -19,6 +19,7 @@ CONFIG_MODULE_UNLOAD=y
 # CONFIG_BLK_DEV_BSG is not set
 CONFIG_PCI=y
 CONFIG_BINFMT_MISC=m
+CONFIG_NET=y
 CONFIG_PACKET=y
 CONFIG_UNIX=y
 CONFIG_INET=y
diff --git a/arch/mips/configs/ip27_defconfig b/arch/mips/configs/ip27_defconfig
index cc07560..48e16d9 100644
--- a/arch/mips/configs/ip27_defconfig
+++ b/arch/mips/configs/ip27_defconfig
@@ -28,6 +28,7 @@ CONFIG_MIPS32_COMPAT=y
 CONFIG_MIPS32_O32=y
 CONFIG_MIPS32_N32=y
 CONFIG_PM=y
+CONFIG_NET=y
 CONFIG_PACKET=y
 CONFIG_UNIX=y
 CONFIG_XFRM_USER=m
diff --git a/arch/mips/configs/jazz_defconfig b/arch/mips/configs/jazz_defconfig
index 2575302..4f37a59 100644
--- a/arch/mips/configs/jazz_defconfig
+++ b/arch/mips/configs/jazz_defconfig
@@ -18,6 +18,7 @@ CONFIG_MODULE_UNLOAD=y
 CONFIG_MODVERSIONS=y
 CONFIG_BINFMT_MISC=m
 CONFIG_PM=y
+CONFIG_NET=y
 CONFIG_PACKET=m
 CONFIG_UNIX=y
 CONFIG_NET_KEY=m
diff --git a/arch/mips/configs/loongson3_defconfig b/arch/mips/configs/loongson3_defconfig
index 4cb787f..1c6191e 100644
--- a/arch/mips/configs/loongson3_defconfig
+++ b/arch/mips/configs/loongson3_defconfig
@@ -59,6 +59,7 @@ CONFIG_MIPS32_COMPAT=y
 CONFIG_MIPS32_O32=y
 CONFIG_MIPS32_N32=y
 CONFIG_PM_RUNTIME=y
+CONFIG_NET=y
 CONFIG_PACKET=y
 CONFIG_UNIX=y
 CONFIG_XFRM_USER=y
diff --git a/arch/mips/configs/malta_defconfig b/arch/mips/configs/malta_defconfig
index e18741e..f57b96d 100644
--- a/arch/mips/configs/malta_defconfig
+++ b/arch/mips/configs/malta_defconfig
@@ -19,6 +19,7 @@ CONFIG_MODULE_UNLOAD=y
 CONFIG_MODVERSIONS=y
 CONFIG_MODULE_SRCVERSION_ALL=y
 CONFIG_PCI=y
+CONFIG_NET=y
 CONFIG_PACKET=y
 CONFIG_UNIX=y
 CONFIG_XFRM_USER=m
diff --git a/arch/mips/configs/malta_kvm_defconfig b/arch/mips/configs/malta_kvm_defconfig
index cf0e01f..d41742d 100644
--- a/arch/mips/configs/malta_kvm_defconfig
+++ b/arch/mips/configs/malta_kvm_defconfig
@@ -20,6 +20,7 @@ CONFIG_MODULE_UNLOAD=y
 CONFIG_MODVERSIONS=y
 CONFIG_MODULE_SRCVERSION_ALL=y
 CONFIG_PCI=y
+CONFIG_NET=y
 CONFIG_PACKET=y
 CONFIG_UNIX=y
 CONFIG_XFRM_USER=m
diff --git a/arch/mips/configs/malta_kvm_guest_defconfig b/arch/mips/configs/malta_kvm_guest_defconfig
index edd9ec9..a7806e8 100644
--- a/arch/mips/configs/malta_kvm_guest_defconfig
+++ b/arch/mips/configs/malta_kvm_guest_defconfig
@@ -19,6 +19,7 @@ CONFIG_MODULE_UNLOAD=y
 CONFIG_MODVERSIONS=y
 CONFIG_MODULE_SRCVERSION_ALL=y
 CONFIG_PCI=y
+CONFIG_NET=y
 CONFIG_PACKET=y
 CONFIG_UNIX=y
 CONFIG_XFRM_USER=m
diff --git a/arch/mips/configs/mtx1_defconfig b/arch/mips/configs/mtx1_defconfig
index d269a53..9b6926d 100644
--- a/arch/mips/configs/mtx1_defconfig
+++ b/arch/mips/configs/mtx1_defconfig
@@ -27,6 +27,7 @@ CONFIG_PD6729=m
 CONFIG_I82092=m
 CONFIG_BINFMT_MISC=m
 CONFIG_PM=y
+CONFIG_NET=y
 CONFIG_PACKET=m
 CONFIG_UNIX=y
 CONFIG_XFRM_USER=m
diff --git a/arch/mips/configs/rm200_defconfig b/arch/mips/configs/rm200_defconfig
index 29d79ae..db029f4 100644
--- a/arch/mips/configs/rm200_defconfig
+++ b/arch/mips/configs/rm200_defconfig
@@ -20,6 +20,7 @@ CONFIG_MODVERSIONS=y
 CONFIG_PCI=y
 CONFIG_BINFMT_MISC=m
 CONFIG_PM=y
+CONFIG_NET=y
 CONFIG_PACKET=m
 CONFIG_UNIX=y
 CONFIG_NET_KEY=m
-- 
1.8.4.5

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/5] mips: Set CONFIG_NET=y in defconfigs
  2014-09-23 15:44 ` [PATCH 1/5] mips: Set CONFIG_NET=y in defconfigs Michal Marek
@ 2014-09-23 16:02   ` David Miller
  2014-09-23 16:06     ` Michal Marek
  0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2014-09-23 16:02 UTC (permalink / raw)
  To: mmarek
  Cc: sfr, rdunlap, netdev, linux-next, linux-kernel, linux-kbuild,
	linux-mips

From: Michal Marek <mmarek@suse.cz>
Date: Tue, 23 Sep 2014 17:44:00 +0200

> Commit 5d6be6a5 ("scsi_netlink : Make SCSI_NETLINK dependent on NET
> instead of selecting NET") removed what happened to be the only instance
> of 'select NET'. Defconfigs that were relying on the select now lack
> networking support.
> 
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Cc: linux-mips@linux-mips.org
> Signed-off-by: Michal Marek <mmarek@suse.cz>

On the contrary, since NET was being selected for them indirectly
previously, weren't they depending instead upon NET being enabled?

Likewise for SCSI_NETLINK, SCSI_FC_ATTRS, and whatever was triggering
the select upon them?

I'll remember this as yet another why 'select' is to be avoided at
just about all costs.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/5] mips: Set CONFIG_NET=y in defconfigs
  2014-09-23 16:02   ` David Miller
@ 2014-09-23 16:06     ` Michal Marek
  0 siblings, 0 replies; 3+ messages in thread
From: Michal Marek @ 2014-09-23 16:06 UTC (permalink / raw)
  To: David Miller
  Cc: sfr, rdunlap, netdev, linux-next, linux-kernel, linux-kbuild,
	linux-mips

On 2014-09-23 18:02, David Miller wrote:
> From: Michal Marek <mmarek@suse.cz>
> Date: Tue, 23 Sep 2014 17:44:00 +0200
> 
>> Commit 5d6be6a5 ("scsi_netlink : Make SCSI_NETLINK dependent on NET
>> instead of selecting NET") removed what happened to be the only instance
>> of 'select NET'. Defconfigs that were relying on the select now lack
>> networking support.
>>
>> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
>> Cc: linux-mips@linux-mips.org
>> Signed-off-by: Michal Marek <mmarek@suse.cz>
> 
> On the contrary, since NET was being selected for them indirectly
> previously, weren't they depending instead upon NET being enabled?
> 
> Likewise for SCSI_NETLINK, SCSI_FC_ATTRS, and whatever was triggering
> the select upon them?

They have SCSI_FC_ATTRS=y/m and were relying on the select statements
turning this into SCSI_NETLINK=y and CONFIG_NET=y.

Michal

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-09-23 16:06 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <54218AEF.5090200@suse.cz>
2014-09-23 15:44 ` [PATCH 1/5] mips: Set CONFIG_NET=y in defconfigs Michal Marek
2014-09-23 16:02   ` David Miller
2014-09-23 16:06     ` Michal Marek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox