Re: [PATCH] MIPS: IP22/IP32: Add missing ifdefs to Platform files

[Markos Chandras <Markos.Chandras@imgtec.com>]

On 10/08/2014 02:43 AM, Joshua Kinard wrote:
> In arch/mips/sgi-ip22/Platform and arch/mips/sgi-ip32/Platform, ifdefs for
> CONFIG_SGI_IP22 and CONFIG_SGI_IP32 are missing, which can cause the
> definitions for these platforms to get included in builds for other platforms.
>  This patch adds these missing ifdefs, which matches IP27's Platform file.
> 
> Signed-off-by: Joshua Kinard <kumba@gentoo.org>
> ---
>  arch/mips/sgi-ip22/Platform |    8 +++++---
>  arch/mips/sgi-ip32/Platform |    9 ++++++---
>  2 files changed, 11 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/mips/sgi-ip22/Platform b/arch/mips/sgi-ip22/Platform
> index b7a4b7e..5fa3c7a 100644
> --- a/arch/mips/sgi-ip22/Platform
> +++ b/arch/mips/sgi-ip22/Platform
> @@ -7,7 +7,8 @@
>  # current variable will break so for 64-bit kernels we have to raise the start
>  # address by 8kb.
>  #
> -platform-$(CONFIG_SGI_IP22)		+= sgi-ip22/
> +ifdef CONFIG_SGI_IP22
> +platform-$(CONFIG_SGI_IP22)	+= sgi-ip22/
>  cflags-$(CONFIG_SGI_IP22)	+= -I$(srctree)/arch/mips/include/asm/mach-ip22
>  ifdef CONFIG_32BIT
>  load-$(CONFIG_SGI_IP22)		+= 0xffffffff88002000
> @@ -15,6 +16,7 @@ endif
>  ifdef CONFIG_64BIT
>  load-$(CONFIG_SGI_IP22)		+= 0xffffffff88004000
>  endif
> +endif
>  

I could be wrong but isn't that functionally the same thing? As in, if
CONFIG_SGI_IP22 is not enabled, the sgi-ip22 etc are not included.
That's the same thing as the original code was doing no? Why do you need
to hide all the $FOO-$(CONFIG_SGI_IP22) in a separate #ifdef block. What
problem are you trying to solve?

-- 
markos