Re: [RFC PATCH V2] MIPS: fix build with binutils 2.24.51+

[Markos Chandras <Markos.Chandras@imgtec.com>]

On 08/25/2014 08:29 PM, Manuel Lauss wrote:
> On Mon, Aug 25, 2014 at 4:27 PM, Maciej W. Rozycki <macro@linux-mips.org> wrote:
> 
>> 1. Determine whether `-Wa,-msoft-float' and `.set hardfloat' are available
>>    (a single check will do, they were added to GAS both at the same time)
>>    and only enable them if supported by binutils being used to build the
>>    kernel, e.g. (for the `.set' part):
>>
>> #ifdef GAS_HAS_SET_HARDFLOAT
>> #define SET_HARDFLOAT .set      hardfloat
>> #else
>> #define SET_HARDFLOAT
>> #endif
>>
>>    Otherwise we'd have to bump the binutils requirement up to 2.19; this
> 
> Do people really update their toolchain so rarely?
> 
> 
>> 2. Use `.set hardfloat' only around the places that really require it,
>>    i.e.:
>>
>>         .set    push
>>         SET_HARDFLOAT
>> # Do the FP stuff.
>>         .set    pop
>>
>>    (so the arch/mips/kernel/r4k_fpu.S piece is good except for maybe using
>>    a macro, depending on the outcome of #1 above, but the other ones are
>>    not).
> 
> I'll update the patch.
> 
> Thank you!
>         Manuel
> 
Hi Manual,

Just wanted to ping you about this patch. Do you intend to submit a new
version including all the feedback from Ralf, Maciej and Matthew?

-- 
markos