From: Markos Chandras <Markos.Chandras@imgtec.com>
To: <linux-mips@linux-mips.org>
Subject: Re: [PATCH] MIPS: ath79: fix compilation error when CONFIG_PCI is disabled
Date: Mon, 20 Oct 2014 14:19:18 +0100 [thread overview]
Message-ID: <54450BD6.1000806@imgtec.com> (raw)
In-Reply-To: <1413810699-44465-1-git-send-email-stefan.hengelein@fau.de>
On 10/20/2014 02:11 PM, Stefan Hengelein wrote:
> When CONFIG_PCI is disabled, 'db120_pci_init()' had a different
> signature than when was enabled. Therefore, compilation failed when
> CONFIG_PCI was not present.
>
> arch/mips/ath79/mach-db120.c:132: error: too many arguments to function 'db120_pci_init'
>
> This error was found with vampyr.
>
> Signed-off-by: Stefan Hengelein <stefan.hengelein@fau.de>
>
> ---
> Changelog:
> v2: fix prototype instead of removing the caller
> ---
> arch/mips/ath79/mach-db120.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/ath79/mach-db120.c b/arch/mips/ath79/mach-db120.c
> index 4d661a1..9423f5a 100644
> --- a/arch/mips/ath79/mach-db120.c
> +++ b/arch/mips/ath79/mach-db120.c
> @@ -113,7 +113,7 @@ static void __init db120_pci_init(u8 *eeprom)
> ath79_register_pci();
> }
> #else
> -static inline void db120_pci_init(void) {}
> +static inline void db120_pci_init(u8 *eeprom) {}
> #endif /* CONFIG_PCI */
>
> static void __init db120_setup(void)
>
Reviewed-by: Markos Chandras <markos.chandras@imgtec.com>
--
markos
WARNING: multiple messages have this Message-ID (diff)
From: Markos Chandras <Markos.Chandras@imgtec.com>
To: linux-mips@linux-mips.org
Subject: Re: [PATCH] MIPS: ath79: fix compilation error when CONFIG_PCI is disabled
Date: Mon, 20 Oct 2014 14:19:18 +0100 [thread overview]
Message-ID: <54450BD6.1000806@imgtec.com> (raw)
Message-ID: <20141020131918.VPvZ_yNmM2VeCYQ52El8Pc61lavre9t9jMS5UCUKJDQ@z> (raw)
In-Reply-To: <1413810699-44465-1-git-send-email-stefan.hengelein@fau.de>
On 10/20/2014 02:11 PM, Stefan Hengelein wrote:
> When CONFIG_PCI is disabled, 'db120_pci_init()' had a different
> signature than when was enabled. Therefore, compilation failed when
> CONFIG_PCI was not present.
>
> arch/mips/ath79/mach-db120.c:132: error: too many arguments to function 'db120_pci_init'
>
> This error was found with vampyr.
>
> Signed-off-by: Stefan Hengelein <stefan.hengelein@fau.de>
>
> ---
> Changelog:
> v2: fix prototype instead of removing the caller
> ---
> arch/mips/ath79/mach-db120.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/ath79/mach-db120.c b/arch/mips/ath79/mach-db120.c
> index 4d661a1..9423f5a 100644
> --- a/arch/mips/ath79/mach-db120.c
> +++ b/arch/mips/ath79/mach-db120.c
> @@ -113,7 +113,7 @@ static void __init db120_pci_init(u8 *eeprom)
> ath79_register_pci();
> }
> #else
> -static inline void db120_pci_init(void) {}
> +static inline void db120_pci_init(u8 *eeprom) {}
> #endif /* CONFIG_PCI */
>
> static void __init db120_setup(void)
>
Reviewed-by: Markos Chandras <markos.chandras@imgtec.com>
--
markos
next prev parent reply other threads:[~2014-10-20 13:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-19 17:43 [PATCH] MIPS: ath79: fix compilation error when CONFIG_PCI is disabled Stefan Hengelein
2014-10-20 7:18 ` Geert Uytterhoeven
2014-10-20 13:11 ` Stefan Hengelein
2014-10-20 13:19 ` Markos Chandras [this message]
2014-10-20 13:19 ` Markos Chandras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54450BD6.1000806@imgtec.com \
--to=markos.chandras@imgtec.com \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox