From: John Crispin <blogic@openwrt.org>
To: Sergey Ryazanov <ryazanov.s.a@gmail.com>,
Ralf Baechle <ralf@linux-mips.org>
Cc: Linux MIPS <linux-mips@linux-mips.org>
Subject: Re: [PATCH v2 04/13] MIPS: ath25: add interrupts handling routines
Date: Wed, 22 Oct 2014 10:49:40 +0200 [thread overview]
Message-ID: <54476FA4.4040303@openwrt.org> (raw)
In-Reply-To: <1413932631-12866-5-git-send-email-ryazanov.s.a@gmail.com>
Hi,
just stumbled across this aswell ->
On 22/10/2014 01:03, Sergey Ryazanov wrote:
> +static void ar2315_misc_irq_handler(unsigned irq, struct irq_desc
> *desc) +{ + u32 pending = ath25_read_reg(AR2315_ISR) &
> ath25_read_reg(AR2315_IMR); + unsigned base =
> ar2315_misc_irq_base; + + if (pending & AR2315_ISR_SPI) +
> generic_handle_irq(base + AR2315_MISC_IRQ_SPI); + else if (pending
> & AR2315_ISR_TIMER) + generic_handle_irq(base +
> AR2315_MISC_IRQ_TIMER); + else if (pending & AR2315_ISR_AHB) +
> generic_handle_irq(base + AR2315_MISC_IRQ_AHB); + else if (pending
> & AR2315_ISR_GPIO) { + ath25_write_reg(AR2315_ISR,
> AR2315_ISR_GPIO); + generic_handle_irq(base +
> AR2315_MISC_IRQ_GPIO); + } else if (pending & AR2315_ISR_UART0) +
> generic_handle_irq(base + AR2315_MISC_IRQ_UART0); + else if
> (pending & AR2315_ISR_WD) { + ath25_write_reg(AR2315_ISR,
> AR2315_ISR_WD); + generic_handle_irq(base +
> AR2315_MISC_IRQ_WATCHDOG); + } else + spurious_interrupt(); +} +
please use {} for all or none of the blocks. in this case it needs to
be for all as there are 2 multi-line blocks
looking forward to V3, i think we are getting close now and i can
already see this in 3.19 :)
John
next prev parent reply other threads:[~2014-10-22 8:49 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-21 23:03 [PATCH v2 00/13] MIPS: support for the Atheros AR231X SoCs Sergey Ryazanov
2014-10-21 23:03 ` [PATCH v2 01/13] MIPS: ath25: add common parts Sergey Ryazanov
2014-10-21 23:36 ` John Crispin
2014-10-22 12:40 ` Sergey Ryazanov
2014-10-22 8:31 ` John Crispin
2014-10-22 13:06 ` Sergey Ryazanov
2014-10-22 13:09 ` John Crispin
2014-10-21 23:03 ` [PATCH v2 02/13] MIPS: ath25: add basic AR5312 SoC support Sergey Ryazanov
2014-10-21 23:48 ` John Crispin
2014-10-22 0:03 ` John Crispin
2014-10-22 14:11 ` Sergey Ryazanov
2014-10-21 23:03 ` [PATCH v2 03/13] MIPS: ath25: add basic AR2315 " Sergey Ryazanov
2014-10-21 23:03 ` [PATCH v2 04/13] MIPS: ath25: add interrupts handling routines Sergey Ryazanov
2014-10-22 8:26 ` John Crispin
2014-10-22 14:51 ` Sergey Ryazanov
2014-10-22 8:49 ` John Crispin [this message]
2014-10-21 23:03 ` [PATCH v2 05/13] MIPS: ath25: add early printk support Sergey Ryazanov
2014-10-21 23:03 ` [PATCH v2 06/13] MIPS: ath25: add UART support Sergey Ryazanov
2014-10-21 23:03 ` [PATCH v2 07/13] MIPS: ath25: add board configuration detection Sergey Ryazanov
2014-10-21 23:03 ` [PATCH v2 08/13] MIPS: ath25: add SoC type detection Sergey Ryazanov
2014-10-21 23:03 ` [PATCH v2 09/13] MIPS: ath25: register various chip devices Sergey Ryazanov
2014-10-22 8:39 ` John Crispin
2014-10-22 15:22 ` Sergey Ryazanov
2014-10-21 23:03 ` [PATCH v2 10/13] MIPS: ath25: add AR2315 PCI host controller driver Sergey Ryazanov
2014-10-22 8:47 ` John Crispin
2014-10-22 15:25 ` Sergey Ryazanov
2014-10-21 23:03 ` [PATCH v2 11/13] ath5k: revert AHB bus support removing Sergey Ryazanov
2014-10-22 12:18 ` Bob Copeland
2014-10-22 12:37 ` Sergey Ryazanov
2014-10-27 18:04 ` John W. Linville
2014-10-28 7:08 ` Sergey Ryazanov
2014-10-28 13:48 ` John W. Linville
2014-10-21 23:03 ` [PATCH v2 12/13] ath5k: update dependencies Sergey Ryazanov
2014-10-27 18:05 ` John W. Linville
2014-10-21 23:03 ` [PATCH v2 13/13] MIPS: ath25: add Wireless device support Sergey Ryazanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54476FA4.4040303@openwrt.org \
--to=blogic@openwrt.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=ryazanov.s.a@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox