From: Markos Chandras <Markos.Chandras@imgtec.com>
To: David Daney <ddaney.cavm@gmail.com>
Cc: <linux-mips@linux-mips.org>
Subject: Re: [PATCH 1/3] MIPS: kernel: traps: Replace printk with pr_info for MC exceptions
Date: Tue, 11 Nov 2014 09:42:35 +0000 [thread overview]
Message-ID: <5461DA0B.2050505@imgtec.com> (raw)
In-Reply-To: <5460EAFC.8020004@gmail.com>
On 11/10/2014 04:42 PM, David Daney wrote:
> On 11/10/2014 08:20 AM, Markos Chandras wrote:
>> printk should not be used without a KERN_ facility level
>>
>> Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
>> ---
>> arch/mips/kernel/traps.c | 12 ++++++------
>> 1 file changed, 6 insertions(+), 6 deletions(-)
>>
>> diff --git a/arch/mips/kernel/traps.c b/arch/mips/kernel/traps.c
>> index 22b19c275044..51fa5c3aa4fe 100644
>> --- a/arch/mips/kernel/traps.c
>> +++ b/arch/mips/kernel/traps.c
>> @@ -1380,12 +1380,12 @@ asmlinkage void do_mcheck(struct pt_regs *regs)
>> show_regs(regs);
>>
>> if (multi_match) {
>> - printk("Index : %0x\n", read_c0_index());
>> - printk("Pagemask: %0x\n", read_c0_pagemask());
>> - printk("EntryHi : %0*lx\n", field, read_c0_entryhi());
>> - printk("EntryLo0: %0*lx\n", field, read_c0_entrylo0());
>> - printk("EntryLo1: %0*lx\n", field, read_c0_entrylo1());
>> - printk("\n");
>> + pr_info("Index : %0x\n", read_c0_index());
>> + pr_info("Pagemask: %0x\n", read_c0_pagemask());
>> + pr_info("EntryHi : %0*lx\n", field, read_c0_entryhi());
>> + pr_info("EntryLo0: %0*lx\n", field, read_c0_entrylo0());
>> + pr_info("EntryLo1: %0*lx\n", field, read_c0_entrylo1());
>> + pr_info("\n");
>
> MachineCheck is a serious problem, If we change this at all, I would
> suggest pr_err() instead.
>
> David Daney
Hi,
Ok I will change all of them to pr_err().
--
markos
WARNING: multiple messages have this Message-ID (diff)
From: Markos Chandras <Markos.Chandras@imgtec.com>
To: David Daney <ddaney.cavm@gmail.com>
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH 1/3] MIPS: kernel: traps: Replace printk with pr_info for MC exceptions
Date: Tue, 11 Nov 2014 09:42:35 +0000 [thread overview]
Message-ID: <5461DA0B.2050505@imgtec.com> (raw)
Message-ID: <20141111094235.blZxpxA6xNVoT2rn2mLE4dm1wyXCDcjnjYWdfx_AyjQ@z> (raw)
In-Reply-To: <5460EAFC.8020004@gmail.com>
On 11/10/2014 04:42 PM, David Daney wrote:
> On 11/10/2014 08:20 AM, Markos Chandras wrote:
>> printk should not be used without a KERN_ facility level
>>
>> Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
>> ---
>> arch/mips/kernel/traps.c | 12 ++++++------
>> 1 file changed, 6 insertions(+), 6 deletions(-)
>>
>> diff --git a/arch/mips/kernel/traps.c b/arch/mips/kernel/traps.c
>> index 22b19c275044..51fa5c3aa4fe 100644
>> --- a/arch/mips/kernel/traps.c
>> +++ b/arch/mips/kernel/traps.c
>> @@ -1380,12 +1380,12 @@ asmlinkage void do_mcheck(struct pt_regs *regs)
>> show_regs(regs);
>>
>> if (multi_match) {
>> - printk("Index : %0x\n", read_c0_index());
>> - printk("Pagemask: %0x\n", read_c0_pagemask());
>> - printk("EntryHi : %0*lx\n", field, read_c0_entryhi());
>> - printk("EntryLo0: %0*lx\n", field, read_c0_entrylo0());
>> - printk("EntryLo1: %0*lx\n", field, read_c0_entrylo1());
>> - printk("\n");
>> + pr_info("Index : %0x\n", read_c0_index());
>> + pr_info("Pagemask: %0x\n", read_c0_pagemask());
>> + pr_info("EntryHi : %0*lx\n", field, read_c0_entryhi());
>> + pr_info("EntryLo0: %0*lx\n", field, read_c0_entrylo0());
>> + pr_info("EntryLo1: %0*lx\n", field, read_c0_entrylo1());
>> + pr_info("\n");
>
> MachineCheck is a serious problem, If we change this at all, I would
> suggest pr_err() instead.
>
> David Daney
Hi,
Ok I will change all of them to pr_err().
--
markos
next prev parent reply other threads:[~2014-11-11 9:42 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-10 16:20 [PATCH 0/3] Machine Check exception improvements Markos Chandras
2014-11-10 16:20 ` Markos Chandras
2014-11-10 16:20 ` [PATCH 1/3] MIPS: kernel: traps: Replace printk with pr_info for MC exceptions Markos Chandras
2014-11-10 16:20 ` Markos Chandras
2014-11-10 16:42 ` David Daney
2014-11-11 9:42 ` Markos Chandras [this message]
2014-11-11 9:42 ` Markos Chandras
2014-11-12 9:22 ` [PATCH v2 1/3] MIPS: kernel: traps: Replace printk with pr_err " Markos Chandras
2014-11-12 9:22 ` Markos Chandras
2014-11-10 16:20 ` [PATCH 2/3] MIPS: kernel: traps: Dump the HTW registers on a MC exception Markos Chandras
2014-11-10 16:20 ` Markos Chandras
2014-11-12 9:22 ` [PATCH v2 " Markos Chandras
2014-11-12 9:22 ` Markos Chandras
2014-11-10 16:20 ` [PATCH 3/3] MIPS: kernel: traps: Dump the PageGrain and Wired registers on MC Markos Chandras
2014-11-10 16:20 ` Markos Chandras
2014-11-12 9:23 ` [PATCH v2 " Markos Chandras
2014-11-12 9:23 ` Markos Chandras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5461DA0B.2050505@imgtec.com \
--to=markos.chandras@imgtec.com \
--cc=ddaney.cavm@gmail.com \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox