Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: "Steven J. Hill" <Steven.Hill@imgtec.com>
To: "Maciej W. Rozycki" <macro@codesourcery.com>
Cc: <linux-mips@linux-mips.org>
Subject: Re: [PATCH 0/7] MIPS: Assorted microMIPS fixes
Date: Mon, 17 Nov 2014 10:37:57 -0600	[thread overview]
Message-ID: <546A2465.4030103@imgtec.com> (raw)
In-Reply-To: <alpine.DEB.1.10.1411140122420.2881@tp.orcam.me.uk>

On 11/15/2014 04:06 PM, Maciej W. Rozycki wrote:
> Hi,
> 
>  In an attempt to build a kernel that supports microMIPS userland and 
> runs on QEMU I came across the problem that, due to apparently arbitrary 
> decisions made sometime in the past, there is no such combination 
> possible.
> 
>  I went ahead and fixed our configuration to support that, but in the 
> course of doing that I came across numerous problems that I decided to 
> address at the same time.  This mini patch series the result.  Most of 
> the changes are actually independent of one another, although there is a 
> syntactical overlap between 5/7 and 7/7, so these have to be applied in 
> order.
> 
>  Of course I had to draw a line somewhere so as not to get distracted 
> too much from the actual purpose I have the need to run such a 
> configuration, so I left some further bugs I spotted for the next 
> occasion.
> 
>  Ralf, please backport these fixes to stable branches as applicable; I 
> can supply you with a 3.17 equivalent of 5/7 as this piece has changed 
> significantly recently and I actually had to forward-port the original 
> change that I made to address the issue.
> 
>   Maciej
> 
Maciej,

This whole patchset looks really good. I went through all of them and
just made a few comments during review.

Steve


Reviewed-by: Steven J. Hill <Steven.Hill@imgtec.com>

WARNING: multiple messages have this Message-ID (diff)
From: "Steven J. Hill" <Steven.Hill@imgtec.com>
To: "Maciej W. Rozycki" <macro@codesourcery.com>
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH 0/7] MIPS: Assorted microMIPS fixes
Date: Mon, 17 Nov 2014 10:37:57 -0600	[thread overview]
Message-ID: <546A2465.4030103@imgtec.com> (raw)
Message-ID: <20141117163757.MV8-9NuD0ycJjPLGnmIGHRwCKu7LUWqrqftGV9R9sVc@z> (raw)
In-Reply-To: <alpine.DEB.1.10.1411140122420.2881@tp.orcam.me.uk>

On 11/15/2014 04:06 PM, Maciej W. Rozycki wrote:
> Hi,
> 
>  In an attempt to build a kernel that supports microMIPS userland and 
> runs on QEMU I came across the problem that, due to apparently arbitrary 
> decisions made sometime in the past, there is no such combination 
> possible.
> 
>  I went ahead and fixed our configuration to support that, but in the 
> course of doing that I came across numerous problems that I decided to 
> address at the same time.  This mini patch series the result.  Most of 
> the changes are actually independent of one another, although there is a 
> syntactical overlap between 5/7 and 7/7, so these have to be applied in 
> order.
> 
>  Of course I had to draw a line somewhere so as not to get distracted 
> too much from the actual purpose I have the need to run such a 
> configuration, so I left some further bugs I spotted for the next 
> occasion.
> 
>  Ralf, please backport these fixes to stable branches as applicable; I 
> can supply you with a 3.17 equivalent of 5/7 as this piece has changed 
> significantly recently and I actually had to forward-port the original 
> change that I made to address the issue.
> 
>   Maciej
> 
Maciej,

This whole patchset looks really good. I went through all of them and
just made a few comments during review.

Steve


Reviewed-by: Steven J. Hill <Steven.Hill@imgtec.com>

  parent reply	other threads:[~2014-11-17 16:38 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-15 22:06 [PATCH 0/7] MIPS: Assorted microMIPS fixes Maciej W. Rozycki
2014-11-15 22:06 ` Maciej W. Rozycki
2014-11-15 22:07 ` [PATCH 1/7] MIPS: Kconfig: Enable microMIPS support for Malta Maciej W. Rozycki
2014-11-15 22:07   ` Maciej W. Rozycki
2014-11-17 16:38   ` Steven J. Hill
2014-11-17 16:38     ` Steven J. Hill
2014-11-15 22:07 ` [PATCH 2/7] MIPS: mm: Only build one microassembler that is suitable Maciej W. Rozycki
2014-11-15 22:07   ` Maciej W. Rozycki
2014-11-15 22:08 ` [PATCH 3/7] MIPS: signal.c: Fix an invalid cast in ISA mode bit handling Maciej W. Rozycki
2014-11-15 22:08   ` Maciej W. Rozycki
2014-11-15 22:08 ` [PATCH 4/7] MIPS: Kconfig: Only allow 32-bit microMIPS builds Maciej W. Rozycki
2014-11-15 22:08   ` Maciej W. Rozycki
2014-11-15 22:08 ` [PATCH 5/7] MIPS: Fix microMIPS LL/SC immediate offsets Maciej W. Rozycki
2014-11-15 22:08   ` Maciej W. Rozycki
2014-11-17 16:38   ` Steven J. Hill
2014-11-17 16:38     ` Steven J. Hill
2014-11-15 22:09 ` [PATCH 6/7] MIPS: Apply `.insn' to fixup labels throughout Maciej W. Rozycki
2014-11-15 22:09   ` Maciej W. Rozycki
2014-11-17 16:38   ` Steven J. Hill
2014-11-17 16:38     ` Steven J. Hill
2014-11-17 16:57     ` Maciej W. Rozycki
2014-11-17 16:57       ` Maciej W. Rozycki
2014-11-15 22:09 ` [PATCH 7/7] MIPS: atomic.h: Reformat to fit in 79 columns Maciej W. Rozycki
2014-11-15 22:09   ` Maciej W. Rozycki
2014-11-17 16:37 ` Steven J. Hill [this message]
2014-11-17 16:37   ` [PATCH 0/7] MIPS: Assorted microMIPS fixes Steven J. Hill

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=546A2465.4030103@imgtec.com \
    --to=steven.hill@imgtec.com \
    --cc=linux-mips@linux-mips.org \
    --cc=macro@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox