From: Leonid Yegoshin <Leonid.Yegoshin@imgtec.com>
To: "Maciej W. Rozycki" <macro@codesourcery.com>
Cc: Ralf Baechle <ralf@linux-mips.org>, <linux-mips@linux-mips.org>
Subject: Re: MIPS: c-r4k.c: Fix the 74K D-cache alias erratum workaround
Date: Mon, 17 Nov 2014 12:12:57 -0800 [thread overview]
Message-ID: <546A56C9.4060608@imgtec.com> (raw)
> Fix the 74K D-cache alias erratum workaround so that it actually works.
> Our current code sets MIPS_CACHE_VTAG for the D-cache, but that flag
> only has any effect for the I-cache. Additionally MIPS_CACHE_PINDEX is
> set for the D-cache if CP0.Config7.AR is also set for an affected
> processor, leading to confusing information in the bootstrap log (the
> flag isn't used beyond that).
> So delete the setting of MIPS_CACHE_VTAG and rely on MIPS_CACHE_ALIASES,
> set in a common place, removing I-cache coherency issues seen in GDB
> testing with software breakpoints, gdbserver and ptrace(2), on affected
> systems.
> While at it add a little piece of explanation of what CP0.Config6.SYND
> is so that people do not have to chase documentation.
This shift to MIPS_CACHE_ALIASES is not needed, a use of MIPS_CACHE_VTAG
in dcache is actually a way how to prevent some very specific situations
in 74K(E77)/1074K(E17) cache handling. It is not a case of cache
aliasing and name VTAG is used because it is related with virtual
address conversion tagging. I reused MIPS_CACHE_VTAG just to save some
spare bits in cpu_info.options and because D-cache never had virtual
tagging like I-cache.
The setting d-cache aliases then CPU hasn't it is a significant
performance loss and should be avoided.
Please don't use this patch.
- Leonid.
WARNING: multiple messages have this Message-ID (diff)
From: Leonid Yegoshin <Leonid.Yegoshin@imgtec.com>
To: "Maciej W. Rozycki" <macro@codesourcery.com>
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org
Subject: Re: MIPS: c-r4k.c: Fix the 74K D-cache alias erratum workaround
Date: Mon, 17 Nov 2014 12:12:57 -0800 [thread overview]
Message-ID: <546A56C9.4060608@imgtec.com> (raw)
Message-ID: <20141117201257.bf0xLm_9z_aV3zi7sy1cEW5EfNTlsUqwK97kNUqzBsk@z> (raw)
> Fix the 74K D-cache alias erratum workaround so that it actually works.
> Our current code sets MIPS_CACHE_VTAG for the D-cache, but that flag
> only has any effect for the I-cache. Additionally MIPS_CACHE_PINDEX is
> set for the D-cache if CP0.Config7.AR is also set for an affected
> processor, leading to confusing information in the bootstrap log (the
> flag isn't used beyond that).
> So delete the setting of MIPS_CACHE_VTAG and rely on MIPS_CACHE_ALIASES,
> set in a common place, removing I-cache coherency issues seen in GDB
> testing with software breakpoints, gdbserver and ptrace(2), on affected
> systems.
> While at it add a little piece of explanation of what CP0.Config6.SYND
> is so that people do not have to chase documentation.
This shift to MIPS_CACHE_ALIASES is not needed, a use of MIPS_CACHE_VTAG
in dcache is actually a way how to prevent some very specific situations
in 74K(E77)/1074K(E17) cache handling. It is not a case of cache
aliasing and name VTAG is used because it is related with virtual
address conversion tagging. I reused MIPS_CACHE_VTAG just to save some
spare bits in cpu_info.options and because D-cache never had virtual
tagging like I-cache.
The setting d-cache aliases then CPU hasn't it is a significant
performance loss and should be avoided.
Please don't use this patch.
- Leonid.
next reply other threads:[~2014-11-17 20:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-17 20:12 Leonid Yegoshin [this message]
2014-11-17 20:12 ` MIPS: c-r4k.c: Fix the 74K D-cache alias erratum workaround Leonid Yegoshin
2014-11-17 23:29 ` Maciej W. Rozycki
2014-11-17 23:29 ` Maciej W. Rozycki
2014-11-18 0:11 ` Leonid Yegoshin
2014-11-18 0:11 ` Leonid Yegoshin
2014-11-18 1:16 ` Maciej W. Rozycki
2014-11-18 1:16 ` Maciej W. Rozycki
2014-11-18 3:56 ` Leonid Yegoshin
2014-11-18 3:56 ` Leonid Yegoshin
2014-11-18 4:56 ` Maciej W. Rozycki
2014-11-18 4:56 ` Maciej W. Rozycki
2014-11-18 19:17 ` Leonid Yegoshin
2014-11-18 19:17 ` Leonid Yegoshin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=546A56C9.4060608@imgtec.com \
--to=leonid.yegoshin@imgtec.com \
--cc=linux-mips@linux-mips.org \
--cc=macro@codesourcery.com \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox