Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: Florian Fainelli <florian@openwrt.org>
To: linux-mips@linux-mips.org
Cc: "Steven J. Hill" <sjhill@mips.com>, ralf@linux-mips.org
Subject: Re: [PATCH 00/33] Cleanup firmware support across multiple platforms.
Date: Tue, 26 Jun 2012 11:25:51 +0200	[thread overview]
Message-ID: <5495290.ISdeCM85M9@flexo> (raw)
In-Reply-To: <1340685708-14408-1-git-send-email-sjhill@mips.com>

Hi Steven,

On Monday 25 June 2012 23:41:15 Steven J. Hill wrote:
> From: "Steven J. Hill" <sjhill@mips.com>
> 
> This is actually the second version of the firmware cleanup. It is two
> patches less than first after incorporating all the review comments
> and changes requested. The original patch set is now rejected.

One of the comment to your initial serie was to make sure the cleanups and 
functionnal changes were splitted in two separate patch series.

Sergei also expressed concerned about your checkpatch changes adding MTI 
copyright to the concerned files. I share that concern and do not think that it 
is worth adding it for such minor changes, or if you do, better do it in the 
"Cleanup firmware" patch instead.

> 
> Steven J. Hill (33):
>   MIPS: Add environment variable processing code to firmware library.
>   MIPS: Alchemy: Cleanup firmware support for Alchemy platforms.
>   MIPS: Alchemy: Cleanup files effected by firmware changes.
>   MIPS: AR7: Cleanup firmware support for the AR7 platform.
>   MIPS: AR7: Cleanup files effected by firmware changes.
>   MIPS: ath79: Cleanup firmware support for the ath79 platform.
>   MIPS: Cobalt: Cleanup firmware support for the Cobalt platform.
>   MIPS: Cobalt: Cleanup files effected by firmware changes.
>   MIPS: Emma: Cleanup firmware support for the Emma platform.
>   MIPS: Emma: Cleanup files effected by firmware changes.
>   MIPS: jz4740: Cleanup firmware support for the JZ4740 platform.
>   MIPS: jz4740: Cleanup files effected by firmware changes.
>   MIPS: lantiq: Cleanup firmware support for the lantiq platform.
>   MIPS: lantiq: Cleanup files effected by firmware changes.
>   MIPS: Lasat: Cleanup firmware support for the Lasat platform.
>   MIPS: Lasat: Cleanup files effected by firmware changes.
>   MIPS: Loongson: Cleanup firmware support for the Loongson platform.
>   MIPS: Loongson: Cleanup files effected by firmware changes.
>   MIPS: Malta: Cleanup firmware support for the Malta platform.
>   MIPS: Malta: Cleanup files effected by firmware changes.
>   MIPS: Netlogic: Cleanup firmware support for the XLR platform.
>   MIPS: MSP71xx, Yosemite: Cleanup firmware support for PMC platforms.
>   MIPS: MSP71xx, Yosemite: Cleanup files effected by firmware changes.
>   MIPS: PNX83xx, PNX8550: Cleanup firmware support for PNX platforms.
>   MIPS: PNX83xx, PNX8550: Cleanup files effected by firmware changes.
>   MIPS: PowerTV: Cleanup firmware support for PowerTV platform.
>   MIPS: PowerTV: Cleanup files effected by firmware changes.
>   MIPS: RB532: Cleanup firmware support for RB532 platform.
>   MIPS: RB532: Cleanup files effected by firmware changes.
>   MIPS: txx9: Cleanup firmware support for txx9 platforms.
>   MIPS: txx9: Cleanup files effected by firmware changes.
>   MIPS: vr41xx: Cleanup firmware support for vr41xx platforms.
>   MIPS: vr41xx: Cleanup files effected by firmware changes.
> 
>  arch/mips/alchemy/board-gpr.c                      |   45 ++---
>  arch/mips/alchemy/board-mtx1.c                     |   45 ++---
>  arch/mips/alchemy/board-xxs1500.c                  |   44 ++---
>  arch/mips/alchemy/common/platform.c                |   30 ++-
>  arch/mips/alchemy/common/prom.c                    |   73 +------
>  arch/mips/alchemy/devboards/db1000.c               |    1 -
>  arch/mips/alchemy/devboards/db1300.c               |    1 -
>  arch/mips/alchemy/devboards/db1550.c               |    1 -
>  arch/mips/alchemy/devboards/pb1100.c               |    1 -
>  arch/mips/alchemy/devboards/pb1500.c               |    1 -
>  arch/mips/alchemy/devboards/prom.c                 |   53 ++---
>  arch/mips/ar7/memory.c                             |   21 +-
>  arch/mips/ar7/platform.c                           |   63 +++---
>  arch/mips/ar7/prom.c                               |   59 ++----
>  arch/mips/ar7/setup.c                              |   23 +--
>  arch/mips/ath79/prom.c                             |   38 ++--
>  arch/mips/cobalt/setup.c                           |   42 ++--
>  arch/mips/emma/common/prom.c                       |   42 +---
>  arch/mips/fw/lib/Makefile                          |    2 +
>  arch/mips/fw/lib/cmdline.c                         |  101 ++++++++++
>  arch/mips/include/asm/fw/fw.h                      |   47 +++++
>  arch/mips/include/asm/mach-ar7/prom.h              |   25 ---
>  arch/mips/include/asm/mach-au1x00/au1xxx_eth.h     |    1 +
>  arch/mips/include/asm/mach-au1x00/prom.h           |   12 --
>  arch/mips/include/asm/mach-loongson/loongson.h     |   54 +++---
>  arch/mips/include/asm/mips-boards/generic.h        |   30 +--
>  arch/mips/include/asm/mips-boards/prom.h           |   47 -----
>  .../mips/include/asm/pmc-sierra/msp71xx/msp_prom.h |   46 +----
>  arch/mips/include/asm/txx9/generic.h               |    1 -
>  arch/mips/jz4740/prom.c                            |   48 +----
>  arch/mips/lantiq/prom.c                            |   31 +--
>  arch/mips/lasat/prom.c                             |   20 +-
>  arch/mips/loongson/common/Makefile                 |    2 +-
>  arch/mips/loongson/common/cmdline.c                |   48 -----
>  arch/mips/loongson/common/env.c                    |   40 ++--
>  arch/mips/loongson/common/init.c                   |   16 +-
>  arch/mips/mti-malta/Makefile                       |    2 +-
>  arch/mips/mti-malta/malta-cmdline.c                |   59 ------
>  arch/mips/mti-malta/malta-display.c                |   40 ++--
>  arch/mips/mti-malta/malta-init.c                   |  153 +++------------
>  arch/mips/mti-malta/malta-memory.c                 |  106 ++++------
>  arch/mips/mti-malta/malta-setup.c                  |   58 ++----
>  arch/mips/mti-malta/malta-time.c                   |   66 +++----
>  arch/mips/netlogic/xlr/setup.c                     |   48 +----
>  arch/mips/pmc-sierra/msp71xx/msp_prom.c            |  205 
+++++---------------
>  arch/mips/pmc-sierra/msp71xx/msp_serial.c          |   68 +++----
>  arch/mips/pmc-sierra/msp71xx/msp_setup.c           |   43 ++--
>  arch/mips/pmc-sierra/msp71xx/msp_time.c            |   67 ++-----
>  arch/mips/pmc-sierra/msp71xx/msp_usb.c             |   42 +---
>  arch/mips/pmc-sierra/yosemite/prom.c               |   45 +----
>  arch/mips/pnx833x/common/Makefile                  |    2 +-
>  arch/mips/pnx833x/common/prom.c                    |   64 ------
>  arch/mips/pnx833x/common/setup.c                   |   36 ++--
>  arch/mips/pnx833x/stb22x/board.c                   |   68 +++----
>  arch/mips/pnx8550/common/Makefile                  |    2 +-
>  arch/mips/pnx8550/common/prom.c                    |  128 ------------
>  arch/mips/pnx8550/common/setup.c                   |   66 +++----
>  arch/mips/pnx8550/jbs/init.c                       |   43 +---
>  arch/mips/pnx8550/stb810/prom_init.c               |   34 +---
>  arch/mips/powertv/asic/asic_int.c                  |   43 +---
>  arch/mips/powertv/init.c                           |   81 ++------
>  arch/mips/powertv/memory.c                         |   36 +---
>  arch/mips/powertv/powertv_setup.c                  |   24 +--
>  arch/mips/rb532/prom.c                             |   67 +++----
>  arch/mips/txx9/generic/setup.c                     |   84 ++------
>  arch/mips/vr41xx/common/init.c                     |   36 +---
>  drivers/mtd/maps/pmcmsp-flash.c                    |   57 ++----
>  drivers/net/ethernet/amd/au1000_eth.c              |    1 -
>  68 files changed, 854 insertions(+), 2174 deletions(-)
>  create mode 100644 arch/mips/fw/lib/cmdline.c
>  create mode 100644 arch/mips/include/asm/fw/fw.h
>  delete mode 100644 arch/mips/include/asm/mach-ar7/prom.h
>  delete mode 100644 arch/mips/include/asm/mach-au1x00/prom.h
>  delete mode 100644 arch/mips/include/asm/mips-boards/prom.h
>  delete mode 100644 arch/mips/loongson/common/cmdline.c
>  delete mode 100644 arch/mips/mti-malta/malta-cmdline.c
>  delete mode 100644 arch/mips/pnx833x/common/prom.c
>  delete mode 100644 arch/mips/pnx8550/common/prom.c
> 
> -- 
> 1.7.10.3
> 
> 

  parent reply	other threads:[~2012-06-26  9:28 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-26  4:41 [PATCH 00/33] Cleanup firmware support across multiple platforms Steven J. Hill
2012-06-26  4:41 ` [PATCH 01/33] MIPS: Add environment variable processing code to firmware library Steven J. Hill
2012-06-26 18:47   ` Hill, Steven
2012-06-26  4:41 ` [PATCH 02/33] MIPS: Alchemy: Cleanup firmware support for Alchemy platforms Steven J. Hill
2012-06-26  4:41 ` [PATCH 03/33] MIPS: Alchemy: Cleanup files effected by firmware changes Steven J. Hill
2012-06-26  4:41 ` [PATCH 04/33] MIPS: AR7: Cleanup firmware support for the AR7 platform Steven J. Hill
2012-06-26  4:41 ` [PATCH 05/33] MIPS: AR7: Cleanup files effected by firmware changes Steven J. Hill
2012-06-26 14:29   ` Florian Fainelli
2012-06-28  6:45     ` Imre Kaloz
2012-06-28 14:06       ` Hill, Steven
2012-06-26  4:41 ` [PATCH 06/33] MIPS: ath79: Cleanup firmware support for the ath79 platform Steven J. Hill
2012-06-26  4:41 ` [PATCH 07/33] MIPS: Cobalt: Cleanup firmware support for the Cobalt platform Steven J. Hill
2012-06-26  4:41 ` [PATCH 08/33] MIPS: Cobalt: Cleanup files effected by firmware changes Steven J. Hill
2012-06-26  4:41 ` [PATCH 09/33] MIPS: Emma: Cleanup firmware support for the Emma platform Steven J. Hill
2012-06-26  4:41 ` [PATCH 10/33] MIPS: Emma: Cleanup files effected by firmware changes Steven J. Hill
2012-06-26  4:41 ` [PATCH 11/33] MIPS: jz4740: Cleanup firmware support for the JZ4740 platform Steven J. Hill
2012-06-26  4:41 ` [PATCH 12/33] MIPS: jz4740: Cleanup files effected by firmware changes Steven J. Hill
2012-06-26  4:41 ` [PATCH 13/33] MIPS: lantiq: Cleanup firmware support for the lantiq platform Steven J. Hill
2012-06-26  4:41 ` [PATCH 14/33] MIPS: lantiq: Cleanup files effected by firmware changes Steven J. Hill
2012-06-26  4:41 ` [PATCH 15/33] MIPS: Lasat: Cleanup firmware support for the Lasat platform Steven J. Hill
2012-06-26  4:41 ` [PATCH 16/33] MIPS: Lasat: Cleanup files effected by firmware changes Steven J. Hill
2012-06-26  4:41 ` [PATCH 17/33] MIPS: Loongson: Cleanup firmware support for the Loongson platform Steven J. Hill
2012-06-26  4:41 ` [PATCH 18/33] MIPS: Loongson: Cleanup files effected by firmware changes Steven J. Hill
2012-06-26  4:41 ` [PATCH 19/33] MIPS: Malta: Cleanup firmware support for the Malta platform Steven J. Hill
2012-06-26  4:41 ` [PATCH 20/33] MIPS: Malta: Cleanup files effected by firmware changes Steven J. Hill
2012-06-26  4:41 ` [PATCH 21/33] MIPS: Netlogic: Cleanup firmware support for the XLR platform Steven J. Hill
2012-06-26  4:41 ` [PATCH 22/33] MIPS: MSP71xx, Yosemite: Cleanup firmware support for PMC platforms Steven J. Hill
2012-06-26  4:41 ` [PATCH 23/33] MIPS: MSP71xx, Yosemite: Cleanup files effected by firmware changes Steven J. Hill
2012-06-26  4:41 ` [PATCH 24/33] MIPS: PNX83xx, PNX8550: Cleanup firmware support for PNX platforms Steven J. Hill
2012-06-26  4:41 ` [PATCH 25/33] MIPS: PNX83xx, PNX8550: Cleanup files effected by firmware changes Steven J. Hill
2012-06-26  4:41 ` [PATCH 26/33] MIPS: PowerTV: Cleanup firmware support for PowerTV platform Steven J. Hill
2012-06-26  4:41 ` [PATCH 27/33] MIPS: PowerTV: Cleanup files effected by firmware changes Steven J. Hill
2012-06-26  4:41 ` [PATCH 28/33] MIPS: RB532: Cleanup firmware support for RB532 platform Steven J. Hill
2012-06-26  4:41 ` [PATCH 29/33] MIPS: RB532: Cleanup files effected by firmware changes Steven J. Hill
2012-06-26  4:41 ` [PATCH 30/33] MIPS: txx9: Cleanup firmware support for txx9 platforms Steven J. Hill
2012-06-26  4:41 ` [PATCH 31/33] MIPS: txx9: Cleanup files effected by firmware changes Steven J. Hill
2012-06-26  4:41 ` [PATCH 32/33] MIPS: vr41xx: Cleanup firmware support for vr41xx platforms Steven J. Hill
2012-06-26  4:41 ` [PATCH 33/33] MIPS: vr41xx: Cleanup files effected by firmware changes Steven J. Hill
2012-06-26  9:25 ` Florian Fainelli [this message]
2012-06-26 15:11 ` [PATCH 00/33] Cleanup firmware support across multiple platforms Jonas Gorski
2012-06-26 18:34   ` Hill, Steven
2012-06-26 18:41     ` David Daney
2012-06-26 19:35       ` Hill, Steven
2012-06-26 18:47     ` Jonas Gorski
2012-06-26 18:52       ` Hill, Steven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5495290.ISdeCM85M9@flexo \
    --to=florian@openwrt.org \
    --cc=linux-mips@linux-mips.org \
    --cc=ralf@linux-mips.org \
    --cc=sjhill@mips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox