From: "Imre Kaloz" <kaloz@openwrt.org>
To: linux-mips@linux-mips.org, "Florian Fainelli" <florian@openwrt.org>
Cc: "Steven J. Hill" <sjhill@mips.com>, ralf@linux-mips.org
Subject: Re: [PATCH 05/33] MIPS: AR7: Cleanup files effected by firmware changes.
Date: Thu, 28 Jun 2012 08:45:35 +0200 [thread overview]
Message-ID: <op.wglo19ee2s3iss@ecaz> (raw)
In-Reply-To: <2501952.67ymQ30y5z@flexo>
On Tue, 26 Jun 2012 16:29:08 +0200, Florian Fainelli <florian@openwrt.org>
wrote:
> On Monday 25 June 2012 23:41:20 Steven J. Hill wrote:
>> From: "Steven J. Hill" <sjhill@mips.com>
>>
>> Make headers consistent across the files and make changes based on
>> running the checkpatch script.
>>
>> Signed-off-by: Steven J. Hill <sjhill@mips.com>
>> ---
>> arch/mips/ar7/memory.c | 18 ++++------------
>> arch/mips/ar7/platform.c | 53
> ++++++++++++++++++----------------------------
> [snip]
>> */
>> #include <linux/bootmem.h>
>> #include <linux/init.h>
>> diff --git a/arch/mips/ar7/platform.c b/arch/mips/ar7/platform.c
>> index 284b86a..921e42c 100644
>> --- a/arch/mips/ar7/platform.c
>> +++ b/arch/mips/ar7/platform.c
>> @@ -1,22 +1,12 @@
>> /*
>> + * This file is subject to the terms and conditions of the GNU General
> Public
>> + * License. See the file "COPYING" in the main directory of this
>> archive
>> + * for more details.
>> + *
>> * Copyright (C) 2006,2007 Felix Fietkau <nbd@openwrt.org>
>> * Copyright (C) 2006,2007 Eugene Konev <ejka@openwrt.org>
>> - *
>> - * This program is free software; you can redistribute it and/or modify
>> - * it under the terms of the GNU General Public License as published by
>> - * the Free Software Foundation; either version 2 of the License, or
>> - * (at your option) any later version.
>> - *
>> - * This program is distributed in the hope that it will be useful,
>> - * but WITHOUT ANY WARRANTY; without even the implied warranty of
>> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
>> - * GNU General Public License for more details.
>> - *
>> - * You should have received a copy of the GNU General Public License
>> - * along with this program; if not, write to the Free Software
>> - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA
>> 02110-1301
> USA
>> + * Copyright (C) 2012 MIPS Technologies, Inc. All rights reserved.
>
> You are adding MTI's Copyright back here, which I assume is a left-over
> from
> your first submission.
I don't even see a reason to touch said headers. Specially because with
some files you are actually changing the license (in this case, GPLv2+ ->
GPLv2), which is leagally wrong. In other cases your change "only" removes
the GPL version number, which can cause issues if the file will be moved
out.
So in files under my copyright, NAK.
Imre
next prev parent reply other threads:[~2012-06-28 6:45 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-26 4:41 [PATCH 00/33] Cleanup firmware support across multiple platforms Steven J. Hill
2012-06-26 4:41 ` [PATCH 01/33] MIPS: Add environment variable processing code to firmware library Steven J. Hill
2012-06-26 18:47 ` Hill, Steven
2012-06-26 4:41 ` [PATCH 02/33] MIPS: Alchemy: Cleanup firmware support for Alchemy platforms Steven J. Hill
2012-06-26 4:41 ` [PATCH 03/33] MIPS: Alchemy: Cleanup files effected by firmware changes Steven J. Hill
2012-06-26 4:41 ` [PATCH 04/33] MIPS: AR7: Cleanup firmware support for the AR7 platform Steven J. Hill
2012-06-26 4:41 ` [PATCH 05/33] MIPS: AR7: Cleanup files effected by firmware changes Steven J. Hill
2012-06-26 14:29 ` Florian Fainelli
2012-06-28 6:45 ` Imre Kaloz [this message]
2012-06-28 14:06 ` Hill, Steven
2012-06-26 4:41 ` [PATCH 06/33] MIPS: ath79: Cleanup firmware support for the ath79 platform Steven J. Hill
2012-06-26 4:41 ` [PATCH 07/33] MIPS: Cobalt: Cleanup firmware support for the Cobalt platform Steven J. Hill
2012-06-26 4:41 ` [PATCH 08/33] MIPS: Cobalt: Cleanup files effected by firmware changes Steven J. Hill
2012-06-26 4:41 ` [PATCH 09/33] MIPS: Emma: Cleanup firmware support for the Emma platform Steven J. Hill
2012-06-26 4:41 ` [PATCH 10/33] MIPS: Emma: Cleanup files effected by firmware changes Steven J. Hill
2012-06-26 4:41 ` [PATCH 11/33] MIPS: jz4740: Cleanup firmware support for the JZ4740 platform Steven J. Hill
2012-06-26 4:41 ` [PATCH 12/33] MIPS: jz4740: Cleanup files effected by firmware changes Steven J. Hill
2012-06-26 4:41 ` [PATCH 13/33] MIPS: lantiq: Cleanup firmware support for the lantiq platform Steven J. Hill
2012-06-26 4:41 ` [PATCH 14/33] MIPS: lantiq: Cleanup files effected by firmware changes Steven J. Hill
2012-06-26 4:41 ` [PATCH 15/33] MIPS: Lasat: Cleanup firmware support for the Lasat platform Steven J. Hill
2012-06-26 4:41 ` [PATCH 16/33] MIPS: Lasat: Cleanup files effected by firmware changes Steven J. Hill
2012-06-26 4:41 ` [PATCH 17/33] MIPS: Loongson: Cleanup firmware support for the Loongson platform Steven J. Hill
2012-06-26 4:41 ` [PATCH 18/33] MIPS: Loongson: Cleanup files effected by firmware changes Steven J. Hill
2012-06-26 4:41 ` [PATCH 19/33] MIPS: Malta: Cleanup firmware support for the Malta platform Steven J. Hill
2012-06-26 4:41 ` [PATCH 20/33] MIPS: Malta: Cleanup files effected by firmware changes Steven J. Hill
2012-06-26 4:41 ` [PATCH 21/33] MIPS: Netlogic: Cleanup firmware support for the XLR platform Steven J. Hill
2012-06-26 4:41 ` [PATCH 22/33] MIPS: MSP71xx, Yosemite: Cleanup firmware support for PMC platforms Steven J. Hill
2012-06-26 4:41 ` [PATCH 23/33] MIPS: MSP71xx, Yosemite: Cleanup files effected by firmware changes Steven J. Hill
2012-06-26 4:41 ` [PATCH 24/33] MIPS: PNX83xx, PNX8550: Cleanup firmware support for PNX platforms Steven J. Hill
2012-06-26 4:41 ` [PATCH 25/33] MIPS: PNX83xx, PNX8550: Cleanup files effected by firmware changes Steven J. Hill
2012-06-26 4:41 ` [PATCH 26/33] MIPS: PowerTV: Cleanup firmware support for PowerTV platform Steven J. Hill
2012-06-26 4:41 ` [PATCH 27/33] MIPS: PowerTV: Cleanup files effected by firmware changes Steven J. Hill
2012-06-26 4:41 ` [PATCH 28/33] MIPS: RB532: Cleanup firmware support for RB532 platform Steven J. Hill
2012-06-26 4:41 ` [PATCH 29/33] MIPS: RB532: Cleanup files effected by firmware changes Steven J. Hill
2012-06-26 4:41 ` [PATCH 30/33] MIPS: txx9: Cleanup firmware support for txx9 platforms Steven J. Hill
2012-06-26 4:41 ` [PATCH 31/33] MIPS: txx9: Cleanup files effected by firmware changes Steven J. Hill
2012-06-26 4:41 ` [PATCH 32/33] MIPS: vr41xx: Cleanup firmware support for vr41xx platforms Steven J. Hill
2012-06-26 4:41 ` [PATCH 33/33] MIPS: vr41xx: Cleanup files effected by firmware changes Steven J. Hill
2012-06-26 9:25 ` [PATCH 00/33] Cleanup firmware support across multiple platforms Florian Fainelli
2012-06-26 15:11 ` Jonas Gorski
2012-06-26 18:34 ` Hill, Steven
2012-06-26 18:41 ` David Daney
2012-06-26 19:35 ` Hill, Steven
2012-06-26 18:47 ` Jonas Gorski
2012-06-26 18:52 ` Hill, Steven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=op.wglo19ee2s3iss@ecaz \
--to=kaloz@openwrt.org \
--cc=florian@openwrt.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=sjhill@mips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox