From: Markos Chandras <Markos.Chandras@imgtec.com>
To: Paul Burton <paul.burton@imgtec.com>,
David Daney <ddaney.cavm@gmail.com>
Cc: <linux-mips@linux-mips.org>,
"Maciej W. Rozycki" <macro@linux-mips.org>,
<stable@vger.kernel.org>
Subject: Re: [PATCH] MIPS: kernel: cps-vec: Replace "addi" with "addiu"
Date: Thu, 22 Jan 2015 08:54:04 +0000 [thread overview]
Message-ID: <54C0BAAC.8020702@imgtec.com> (raw)
In-Reply-To: <20150121180200.GC15278@NP-P-BURTON>
On 01/21/2015 06:02 PM, Paul Burton wrote:
> On Wed, Jan 21, 2015 at 09:59:59AM -0800, David Daney wrote:
>> On 01/21/2015 07:27 AM, Markos Chandras wrote:
>>> The "addi" instruction will trap on overflows which is not something
>>> we need in this code, so we replace that with "addiu".
>>>
>>> Link: http://www.linux-mips.org/archives/linux-mips/2015-01/msg00430.html
>>> Cc: Maciej W. Rozycki <macro@linux-mips.org>
>>> Cc: <stable@vger.kernel.org> # v3.15+
>>> Cc: Paul Burton <paul.burton@imgtec.com>
>>> Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
>>
>> Acked-by: David Daney <david.daney@cavium.com>
>>
>> Same comment about the stable thing. Is it needed for anything other than
>> follow-on MIPS r6 Patches?
>
> In both this & the MSA asmmacro.h cases, the additions should never
> cause overflow. So I agree, backporting to stable seems like overkill.
>
> Paul
>
Maciej suggested to backport it to stable branches. I personally don't mind.
--
markos
WARNING: multiple messages have this Message-ID (diff)
From: Markos Chandras <Markos.Chandras@imgtec.com>
To: Paul Burton <paul.burton@imgtec.com>,
David Daney <ddaney.cavm@gmail.com>
Cc: linux-mips@linux-mips.org,
"Maciej W. Rozycki" <macro@linux-mips.org>,
stable@vger.kernel.org
Subject: Re: [PATCH] MIPS: kernel: cps-vec: Replace "addi" with "addiu"
Date: Thu, 22 Jan 2015 08:54:04 +0000 [thread overview]
Message-ID: <54C0BAAC.8020702@imgtec.com> (raw)
Message-ID: <20150122085404.M_u1Llz6ai1TRtcI5B-uCrOAZShJ2pDTG43lNsUxz5c@z> (raw)
In-Reply-To: <20150121180200.GC15278@NP-P-BURTON>
On 01/21/2015 06:02 PM, Paul Burton wrote:
> On Wed, Jan 21, 2015 at 09:59:59AM -0800, David Daney wrote:
>> On 01/21/2015 07:27 AM, Markos Chandras wrote:
>>> The "addi" instruction will trap on overflows which is not something
>>> we need in this code, so we replace that with "addiu".
>>>
>>> Link: http://www.linux-mips.org/archives/linux-mips/2015-01/msg00430.html
>>> Cc: Maciej W. Rozycki <macro@linux-mips.org>
>>> Cc: <stable@vger.kernel.org> # v3.15+
>>> Cc: Paul Burton <paul.burton@imgtec.com>
>>> Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
>>
>> Acked-by: David Daney <david.daney@cavium.com>
>>
>> Same comment about the stable thing. Is it needed for anything other than
>> follow-on MIPS r6 Patches?
>
> In both this & the MSA asmmacro.h cases, the additions should never
> cause overflow. So I agree, backporting to stable seems like overkill.
>
> Paul
>
Maciej suggested to backport it to stable branches. I personally don't mind.
--
markos
next prev parent reply other threads:[~2015-01-22 8:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-21 15:27 [PATCH] MIPS: kernel: cps-vec: Replace "addi" with "addiu" Markos Chandras
2015-01-21 15:27 ` Markos Chandras
2015-01-21 17:59 ` David Daney
2015-01-21 18:02 ` Paul Burton
2015-01-21 18:02 ` Paul Burton
2015-01-22 8:54 ` Markos Chandras [this message]
2015-01-22 8:54 ` Markos Chandras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54C0BAAC.8020702@imgtec.com \
--to=markos.chandras@imgtec.com \
--cc=ddaney.cavm@gmail.com \
--cc=linux-mips@linux-mips.org \
--cc=macro@linux-mips.org \
--cc=paul.burton@imgtec.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox