* [PATCH] MIPS: Loongson-3: Add IRQF_NO_SUSPEND to Cascade irqaction
@ 2015-03-12 3:51 Huacai Chen
2015-03-12 3:51 ` Huacai Chen
2015-03-12 11:59 ` Sergei Shtylyov
0 siblings, 2 replies; 3+ messages in thread
From: Huacai Chen @ 2015-03-12 3:51 UTC (permalink / raw)
To: Ralf Baechle
Cc: Steven J. Hill, linux-mips, Fuxin Zhang, Zhangjin Wu, Huacai Chen,
stable
HPET irq is routed to i8259 and then to MIPS CPU irq (cascade). After
commit a3e6c1eff5 (MIPS: IRQ: Fix disable_irq on CPU IRQs), if without
IRQF_NO_SUSPEND in cascade_irqaction, HPET interrupts will lost during
suspend. The result is machine cannot be waken up.
Cc: <stable@vger.kernel.org>
Signed-off-by: Huacai Chen <chenhc@lemote.com>
---
arch/mips/loongson/loongson-3/irq.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/mips/loongson/loongson-3/irq.c b/arch/mips/loongson/loongson-3/irq.c
index 21221ed..0f75b6b 100644
--- a/arch/mips/loongson/loongson-3/irq.c
+++ b/arch/mips/loongson/loongson-3/irq.c
@@ -44,6 +44,7 @@ void mach_irq_dispatch(unsigned int pending)
static struct irqaction cascade_irqaction = {
.handler = no_action,
+ .flags = IRQF_NO_SUSPEND,
.name = "cascade",
};
--
1.7.7.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] MIPS: Loongson-3: Add IRQF_NO_SUSPEND to Cascade irqaction
2015-03-12 3:51 [PATCH] MIPS: Loongson-3: Add IRQF_NO_SUSPEND to Cascade irqaction Huacai Chen
@ 2015-03-12 3:51 ` Huacai Chen
2015-03-12 11:59 ` Sergei Shtylyov
1 sibling, 0 replies; 3+ messages in thread
From: Huacai Chen @ 2015-03-12 3:51 UTC (permalink / raw)
To: Ralf Baechle
Cc: Steven J. Hill, linux-mips, Fuxin Zhang, Zhangjin Wu, Huacai Chen,
stable
HPET irq is routed to i8259 and then to MIPS CPU irq (cascade). After
commit a3e6c1eff5 (MIPS: IRQ: Fix disable_irq on CPU IRQs), if without
IRQF_NO_SUSPEND in cascade_irqaction, HPET interrupts will lost during
suspend. The result is machine cannot be waken up.
Cc: <stable@vger.kernel.org>
Signed-off-by: Huacai Chen <chenhc@lemote.com>
---
arch/mips/loongson/loongson-3/irq.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/mips/loongson/loongson-3/irq.c b/arch/mips/loongson/loongson-3/irq.c
index 21221ed..0f75b6b 100644
--- a/arch/mips/loongson/loongson-3/irq.c
+++ b/arch/mips/loongson/loongson-3/irq.c
@@ -44,6 +44,7 @@ void mach_irq_dispatch(unsigned int pending)
static struct irqaction cascade_irqaction = {
.handler = no_action,
+ .flags = IRQF_NO_SUSPEND,
.name = "cascade",
};
--
1.7.7.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] MIPS: Loongson-3: Add IRQF_NO_SUSPEND to Cascade irqaction
2015-03-12 3:51 [PATCH] MIPS: Loongson-3: Add IRQF_NO_SUSPEND to Cascade irqaction Huacai Chen
2015-03-12 3:51 ` Huacai Chen
@ 2015-03-12 11:59 ` Sergei Shtylyov
1 sibling, 0 replies; 3+ messages in thread
From: Sergei Shtylyov @ 2015-03-12 11:59 UTC (permalink / raw)
To: Huacai Chen, Ralf Baechle
Cc: Steven J. Hill, linux-mips, Fuxin Zhang, Zhangjin Wu, stable
Hello.
On 3/12/2015 6:51 AM, Huacai Chen wrote:
> HPET irq is routed to i8259 and then to MIPS CPU irq (cascade). After
IRQ.
> commit a3e6c1eff5 (MIPS: IRQ: Fix disable_irq on CPU IRQs), if without
"If" not needed, I think.
> IRQF_NO_SUSPEND in cascade_irqaction, HPET interrupts will lost during
Will be lost.
> suspend. The result is machine cannot be waken up.
Woken up.
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Huacai Chen <chenhc@lemote.com>
Perhaps Ralf could fix these when applying...
WBR, Sergei
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-03-12 11:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-12 3:51 [PATCH] MIPS: Loongson-3: Add IRQF_NO_SUSPEND to Cascade irqaction Huacai Chen
2015-03-12 3:51 ` Huacai Chen
2015-03-12 11:59 ` Sergei Shtylyov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox