Re: [PATCH 2/3] MIPS: OCTEON: Add mach-cavium-octeon/mangle-port.h

[Aleksey Makarov <aleksey.makarov@auriga.com>]

> On Fri, Mar 20, 2015 at 07:11:57PM +0300, Aleksey Makarov wrote:
>> From: David Daney <david.daney@cavium.com>
>> 
>> Needed for little-endian ioport access.
>> This fixes NOR flash in little-endian mode
>> 
>> Signed-off-by: David Daney <david.daney@cavium.com>
>> Signed-off-by: Aleksey Makarov <aleksey.makarov@auriga.com>
>> ---
>>  .../include/asm/mach-cavium-octeon/mangle-port.h   | 74 
>> ++++++++++++++++++++++
> 
> This seems to be a new header file that's not used anywhere else.

arch/mips/include/asm/io.h:#include <mangle-port.h>

Also note the compiler flags:

-I./arch/mips/include/asm/mach-cavium-octeon -I./arch/mips/include/asm/mach-generic 

> I get the feeling that there should be at least another three patches
> in this series which have been omitted.
> 
> Certainly, the Octeon peripherals won't work with just the three part
> patch set presented here.

With these patches the cn7000 board boots in little-endian mode with 
all peripherials supported on this board working fine.  The peripherials
on other boards should probably be fixed separately.

> PS. Don't forget the missing htons() in drivers/staging/octeon/ethernet-tx.c

Thanks.  A patch would be appreciated.

Thanks
Aleksey Makarov