Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: "Rafał Miłecki" <zajec5@gmail.com>,
	linux-mips@linux-mips.org, "Ralf Baechle" <ralf@linux-mips.org>
Cc: Hauke Mehrtens <hauke@hauke-m.de>
Subject: Re: [PATCH 1/3] MIPS: BCM47XX: Include io.h directly and fix brace indent
Date: Wed, 01 Apr 2015 14:15:07 +0300	[thread overview]
Message-ID: <551BD33B.5030707@cogentembedded.com> (raw)
In-Reply-To: <1427869385-23333-1-git-send-email-zajec5@gmail.com>

Hello.

On 4/1/2015 9:23 AM, Rafał Miłecki wrote:

> We use IO functions like readl & ioremap_nocache, so include linux/io.h

> Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
> ---
>   arch/mips/bcm47xx/nvram.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)

> diff --git a/arch/mips/bcm47xx/nvram.c b/arch/mips/bcm47xx/nvram.c
> index 6a97732..2357ea3 100644
> --- a/arch/mips/bcm47xx/nvram.c
> +++ b/arch/mips/bcm47xx/nvram.c
[...]
> @@ -203,7 +204,7 @@ int bcm47xx_nvram_getenv(const char *name, char *val, size_t val_len)
>   		if (eq - var == strlen(name) &&
>   		    strncmp(var, name, eq - var) == 0)
>   			return snprintf(val, val_len, "%s", value);
> -		}
> +	}

    Unrelated (and undescribed) change.

[...]

WBR, Sergei

  parent reply	other threads:[~2015-04-01 11:15 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-01  6:23 [PATCH 1/3] MIPS: BCM47XX: Include io.h directly and fix brace indent Rafał Miłecki
2015-04-01  6:23 ` [PATCH 2/3] MIPS: BCM47XX: Increase NVRAM buffer size to 64 KiB Rafał Miłecki
2015-04-01  6:23 ` [PATCH 3/3] MIPS: BCM47XX: Don't try guessing NVRAM size on MTD partition Rafał Miłecki
2015-04-01 11:15 ` Sergei Shtylyov [this message]
2015-04-01 11:20   ` [PATCH 1/3] MIPS: BCM47XX: Include io.h directly and fix brace indent Rafał Miłecki
2015-04-01 11:23     ` Sergei Shtylyov
2015-04-01 11:28       ` Rafał Miłecki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=551BD33B.5030707@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=hauke@hauke-m.de \
    --cc=linux-mips@linux-mips.org \
    --cc=ralf@linux-mips.org \
    --cc=zajec5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox