Re: [PATCH 1/3] MIPS: BCM47XX: Include io.h directly and fix brace indent

[Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>]

Hello.

On 4/1/2015 2:20 PM, Rafał Miłecki wrote:

>>> We use IO functions like readl & ioremap_nocache, so include linux/io.h

>>> Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
>>> ---
>>>    arch/mips/bcm47xx/nvram.c | 3 ++-
>>>    1 file changed, 2 insertions(+), 1 deletion(-)

>>> diff --git a/arch/mips/bcm47xx/nvram.c b/arch/mips/bcm47xx/nvram.c
>>> index 6a97732..2357ea3 100644
>>> --- a/arch/mips/bcm47xx/nvram.c
>>> +++ b/arch/mips/bcm47xx/nvram.c
>> [...]
>>> @@ -203,7 +204,7 @@ int bcm47xx_nvram_getenv(const char *name, char *val,
>>> size_t val_len)
>>>                  if (eq - var == strlen(name) &&
>>>                      strncmp(var, name, eq - var) == 0)
>>>                          return snprintf(val, val_len, "%s", value);
>>> -               }
>>> +       }

>>     Unrelated (and undescribed) change.

> Described in the commit message, skipped in the description.

    Ah, sorry, missed you summary...

> I was feeling a bit unsure about sending two so trivial patches: one
 > for single-line include, second for single-line indent. So I merged
 > them.

    No need to be unsure about this. Doing one thing per patch is perfectly 
legal and certainly better than doing 2 unrelated things. :-)

WBR, Sergei