From: Ezequiel Garcia <ezequiel.garcia@imgtec.com>
To: Andrew Bresticker <abrestic@chromium.org>
Cc: Linux-MIPS <linux-mips@linux-mips.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Mike Turquette <mturquette@linaro.org>,
Stephen Boyd <sboyd@codeaurora.org>,
James Hartley <james.hartley@imgtec.com>,
Govindraj Raja <Govindraj.Raja@imgtec.com>,
Damien Horsley <Damien.Horsley@imgtec.com>,
Kevin Cernekee <cernekee@chromium.org>,
James Hogan <james.hogan@imgtec.com>
Subject: Re: [PATCH 9/9] clk: pistachio: Correct critical clock list
Date: Fri, 22 May 2015 14:54:01 -0300 [thread overview]
Message-ID: <555F6D39.1050005@imgtec.com> (raw)
In-Reply-To: <CAL1qeaFJBtjzDGqqa-qRb=+5_36QCyssGAKAZk2A2Tos3xK5LQ@mail.gmail.com>
On 05/22/2015 02:56 PM, Andrew Bresticker wrote:
> On Thu, May 21, 2015 at 4:57 PM, Ezequiel Garcia
> <ezequiel.garcia@imgtec.com> wrote:
>> From: Damien Horsley <Damien.Horsley@imgtec.com>
>>
>> Correct the critical clock list. The current one is wrong, and may
>> fail under some circumstances.
>>
>> Signed-off-by: Damien Horsley <Damien.Horsley@imgtec.com>
>> Signed-off-by: Ezequiel Garcia <ezequiel.garcia@imgtec.com>
>
> The commit message could be more descriptive, e.g. explaining which
> additional clocks must be enabled at all times and why, especially
> since forcing on clocks form the clock driver is very much frowned
> upon unless absolutely necessary. Otherwise,
>
> Reviewed-by: Andrew Bresticker <abrestic@chromium.org>
>
OK, I'll explain this in detail.
Thanks for the review,
--
Ezequiel
prev parent reply other threads:[~2015-05-22 17:57 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-21 23:57 [PATCH 0/9] clk: pistachio: Assorted changes Ezequiel Garcia
2015-05-21 23:57 ` Ezequiel Garcia
2015-05-21 23:57 ` [PATCH 1/9] clk: pistachio: Add a pll_lock() helper for clarity Ezequiel Garcia
2015-05-21 23:57 ` Ezequiel Garcia
2015-05-21 23:57 ` [PATCH 2/9] clk: pistachio: Lock the PLL when enabled upon rate change Ezequiel Garcia
2015-05-21 23:57 ` Ezequiel Garcia
2015-05-21 23:57 ` [PATCH 3/9] clk: pistachio: Implement PLL rate adjustment Ezequiel Garcia
2015-05-21 23:57 ` Ezequiel Garcia
2015-05-22 17:04 ` Andrew Bresticker
2015-05-21 23:57 ` [PATCH 4/9] clk: pistachio: Extend DIV_F to pass clk_flags as well Ezequiel Garcia
2015-05-21 23:57 ` Ezequiel Garcia
2015-05-22 17:05 ` Andrew Bresticker
2015-05-21 23:57 ` [PATCH 5/9] clk: pistachio: Add a MUX_F macro to pass clk_flags Ezequiel Garcia
2015-05-21 23:57 ` Ezequiel Garcia
2015-05-22 17:07 ` Andrew Bresticker
2015-05-21 23:57 ` [PATCH 6/9] clk: pistachio: Propagate rate changes in the MIPS PLL clock sub-tree Ezequiel Garcia
2015-05-21 23:57 ` Ezequiel Garcia
2015-05-22 17:42 ` Andrew Bresticker
2015-05-22 17:52 ` Ezequiel Garcia
2015-05-22 18:07 ` Andrew Bresticker
2015-05-21 23:57 ` [PATCH 7/9] clk: pistachio: Add a rate table for the MIPS PLL Ezequiel Garcia
2015-05-21 23:57 ` Ezequiel Garcia
2015-05-22 17:45 ` Andrew Bresticker
2015-05-22 17:45 ` Ezequiel Garcia
2015-05-21 23:57 ` [PATCH 8/9] clk: pistachio: Add sanity checks on PLL configuration Ezequiel Garcia
2015-05-21 23:57 ` Ezequiel Garcia
2015-05-22 17:48 ` Andrew Bresticker
2015-05-21 23:57 ` [PATCH 9/9] clk: pistachio: Correct critical clock list Ezequiel Garcia
2015-05-21 23:57 ` Ezequiel Garcia
2015-05-22 17:56 ` Andrew Bresticker
2015-05-22 17:54 ` Ezequiel Garcia [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=555F6D39.1050005@imgtec.com \
--to=ezequiel.garcia@imgtec.com \
--cc=Damien.Horsley@imgtec.com \
--cc=Govindraj.Raja@imgtec.com \
--cc=abrestic@chromium.org \
--cc=cernekee@chromium.org \
--cc=james.hartley@imgtec.com \
--cc=james.hogan@imgtec.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=mturquette@linaro.org \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox