From: Markos Chandras <Markos.Chandras@imgtec.com>
To: Aurelien Jarno <aurelien@aurel32.net>, <linux-mips@linux-mips.org>
Cc: Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH 2/2 for-4.3] MIPS: BPF: Fix build on pre-R2 little endian CPUs
Date: Mon, 7 Sep 2015 10:33:48 +0100 [thread overview]
Message-ID: <55ED59FC.4070505@imgtec.com> (raw)
In-Reply-To: <1441471618-5613-2-git-send-email-aurelien@aurel32.net>
On 09/05/2015 05:46 PM, Aurelien Jarno wrote:
> The rotr, seh and wsbh instructions have been introduced with the R2
> ISA. Thus the current BPF code fails to build on pre-R2 little endian
> CPUs:
>
> CC arch/mips/net/bpf_jit.o
> AS arch/mips/net/bpf_jit_asm.o
> /home/aurel32/linux-4.2/arch/mips/net/bpf_jit_asm.S: Assembler messages:
> /home/aurel32/linux-4.2/arch/mips/net/bpf_jit_asm.S:67: Error: opcode not supported on this processor: mips32 (mips32) `wsbh $8,$19'
> /home/aurel32/linux-4.2/arch/mips/net/bpf_jit_asm.S:68: Error: opcode not supported on this processor: mips32 (mips32) `rotr $19,$8,16'
> /home/aurel32/linux-4.2/arch/mips/net/bpf_jit_asm.S:83: Error: opcode not supported on this processor: mips32 (mips32) `wsbh $8,$19'
> /home/aurel32/linux-4.2/arch/mips/net/bpf_jit_asm.S:84: Error: opcode not supported on this processor: mips32 (mips32) `seh $19,$8'
> /home/aurel32/linux-4.2/arch/mips/net/bpf_jit_asm.S:151: Error: opcode not supported on this processor: mips32 (mips32) `wsbh $8,$12'
> /home/aurel32/linux-4.2/arch/mips/net/bpf_jit_asm.S:153: Error: opcode not supported on this processor: mips32 (mips32) `rotr $19,$8,16'
> /home/aurel32/linux-4.2/arch/mips/net/bpf_jit_asm.S:164: Error: opcode not supported on this processor: mips32 (mips32) `wsbh $19,$12'
> /home/aurel32/linux-4.2/scripts/Makefile.build:294: recipe for target 'arch/mips/net/bpf_jit_asm.o' failed
>
> Fix that by providing equivalent code for these CPUs.
>
> Cc: Ralf Baechle <ralf@linux-mips.org>
> Cc: Markos Chandras <markos.chandras@imgtec.com>
> Cc: stable@vger.kernel.org # v4.2+
> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> ---
Reviewed-by: Markos Chandras <markos.chandras@imgtec.com>
--
markos
WARNING: multiple messages have this Message-ID (diff)
From: Markos Chandras <Markos.Chandras@imgtec.com>
To: Aurelien Jarno <aurelien@aurel32.net>, linux-mips@linux-mips.org
Cc: Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH 2/2 for-4.3] MIPS: BPF: Fix build on pre-R2 little endian CPUs
Date: Mon, 7 Sep 2015 10:33:48 +0100 [thread overview]
Message-ID: <55ED59FC.4070505@imgtec.com> (raw)
Message-ID: <20150907093348.YdchXvbdNUYKPqE4S9Jl9O47PtEOrCDErXuCvNKTut0@z> (raw)
In-Reply-To: <1441471618-5613-2-git-send-email-aurelien@aurel32.net>
On 09/05/2015 05:46 PM, Aurelien Jarno wrote:
> The rotr, seh and wsbh instructions have been introduced with the R2
> ISA. Thus the current BPF code fails to build on pre-R2 little endian
> CPUs:
>
> CC arch/mips/net/bpf_jit.o
> AS arch/mips/net/bpf_jit_asm.o
> /home/aurel32/linux-4.2/arch/mips/net/bpf_jit_asm.S: Assembler messages:
> /home/aurel32/linux-4.2/arch/mips/net/bpf_jit_asm.S:67: Error: opcode not supported on this processor: mips32 (mips32) `wsbh $8,$19'
> /home/aurel32/linux-4.2/arch/mips/net/bpf_jit_asm.S:68: Error: opcode not supported on this processor: mips32 (mips32) `rotr $19,$8,16'
> /home/aurel32/linux-4.2/arch/mips/net/bpf_jit_asm.S:83: Error: opcode not supported on this processor: mips32 (mips32) `wsbh $8,$19'
> /home/aurel32/linux-4.2/arch/mips/net/bpf_jit_asm.S:84: Error: opcode not supported on this processor: mips32 (mips32) `seh $19,$8'
> /home/aurel32/linux-4.2/arch/mips/net/bpf_jit_asm.S:151: Error: opcode not supported on this processor: mips32 (mips32) `wsbh $8,$12'
> /home/aurel32/linux-4.2/arch/mips/net/bpf_jit_asm.S:153: Error: opcode not supported on this processor: mips32 (mips32) `rotr $19,$8,16'
> /home/aurel32/linux-4.2/arch/mips/net/bpf_jit_asm.S:164: Error: opcode not supported on this processor: mips32 (mips32) `wsbh $19,$12'
> /home/aurel32/linux-4.2/scripts/Makefile.build:294: recipe for target 'arch/mips/net/bpf_jit_asm.o' failed
>
> Fix that by providing equivalent code for these CPUs.
>
> Cc: Ralf Baechle <ralf@linux-mips.org>
> Cc: Markos Chandras <markos.chandras@imgtec.com>
> Cc: stable@vger.kernel.org # v4.2+
> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> ---
Reviewed-by: Markos Chandras <markos.chandras@imgtec.com>
--
markos
next prev parent reply other threads:[~2015-09-07 9:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-05 16:46 [PATCH 1/2 for-4.3] MIPS: BPF: Avoid unreachable code on little endian Aurelien Jarno
2015-09-05 16:46 ` [PATCH 2/2 for-4.3] MIPS: BPF: Fix build on pre-R2 little endian CPUs Aurelien Jarno
2015-09-07 9:33 ` Markos Chandras [this message]
2015-09-07 9:33 ` Markos Chandras
2015-09-07 8:29 ` [PATCH 1/2 for-4.3] MIPS: BPF: Avoid unreachable code on little endian Markos Chandras
2015-09-07 8:29 ` Markos Chandras
2015-09-07 9:48 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55ED59FC.4070505@imgtec.com \
--to=markos.chandras@imgtec.com \
--cc=aurelien@aurel32.net \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox