From: David Daney <ddaney@caviumnetworks.com>
To: Aaro Koskinen <aaro.koskinen@iki.fi>
Cc: "Steven J. Hill" <steven.hill@cavium.com>,
David Daney <david.daney@cavium.com>,
Ralf Baechle <ralf@linux-mips.org>, <linux-mips@linux-mips.org>
Subject: Re: [PATCH] MIPS: OCTEON: Changes to support readq()/writeq() usage.
Date: Fri, 12 Aug 2016 15:36:19 -0700 [thread overview]
Message-ID: <57AE4F63.4010506@caviumnetworks.com> (raw)
In-Reply-To: <20160812213801.GC10648@raspberrypi.musicnaut.iki.fi>
On 08/12/2016 02:38 PM, Aaro Koskinen wrote:
> Hi,
>
> On Fri, Jul 08, 2016 at 09:45:01PM -0500, Steven J. Hill wrote:
>> Update OCTEON port mangling code to support readq() and
>> writeq() functions to allow driver code to be more portable.
>> Updates also for word and long function pairs. We also
>> remove SWAP_IO_SPACE for OCTEON platforms as the function
>> macros are redundant with the new mangling code.
>>
>> Signed-off-by: Steven J. Hill <steven.hill@cavium.com>
>> Acked-by: David Daney <david.daney@cavium.com>
>
> [...]
>
>> +static inline bool __should_swizzle_bits(volatile void *a)
>> +{
>> + extern const bool octeon_should_swizzle_table[];
>> +
>> + unsigned long did = ((unsigned long)a >> 40) & 0xff;
>> + return octeon_should_swizzle_table[did];
>> +}
>
> v4.8-rc1 OCTEON build is now broken with GCC 6.1 when support for 32-bit
> ABIs is enabled:
I don't get it. The kernel is always 64-bit, so unsigned long will have
a width of 64.
What kernel config are you using?
>
> CC arch/mips/vdso/gettimeofday-o32.o
> In file included from /home/aaro/los/work/shared/linux-v4.8-rc1/arch/mips/includ
> e/asm/io.h:32:0,
> from /home/aaro/los/work/shared/linux-v4.8-rc1/arch/mips/includ
> e/asm/page.h:194,
> from /home/aaro/los/work/shared/linux-v4.8-rc1/arch/mips/vdso/v
> dso.h:26,
> from /home/aaro/los/work/shared/linux-v4.8-rc1/arch/mips/vdso/g
> ettimeofday.c:11:
> /home/aaro/los/work/shared/linux-v4.8-rc1/arch/mips/include/asm/mach-cavium-octe
> on/mangle-port.h: In function '__should_swizzle_bits':
> /home/aaro/los/work/shared/linux-v4.8-rc1/arch/mips/include/asm/mach-cavium-octe
> on/mangle-port.h:19:40: error: right shift count >= width of type [-Werror=shift
> -count-overflow]
> unsigned long did = ((unsigned long)a >> 40) & 0xff;
>
> A.
>
WARNING: multiple messages have this Message-ID (diff)
From: David Daney <ddaney@caviumnetworks.com>
To: Aaro Koskinen <aaro.koskinen@iki.fi>
Cc: "Steven J. Hill" <steven.hill@cavium.com>,
David Daney <david.daney@cavium.com>,
Ralf Baechle <ralf@linux-mips.org>,
linux-mips@linux-mips.org
Subject: Re: [PATCH] MIPS: OCTEON: Changes to support readq()/writeq() usage.
Date: Fri, 12 Aug 2016 15:36:19 -0700 [thread overview]
Message-ID: <57AE4F63.4010506@caviumnetworks.com> (raw)
Message-ID: <20160812223619.m6PLxuKy-UG050ewkQLFjyFkaQxNFJoWUEBFwSXoJus@z> (raw)
In-Reply-To: <20160812213801.GC10648@raspberrypi.musicnaut.iki.fi>
On 08/12/2016 02:38 PM, Aaro Koskinen wrote:
> Hi,
>
> On Fri, Jul 08, 2016 at 09:45:01PM -0500, Steven J. Hill wrote:
>> Update OCTEON port mangling code to support readq() and
>> writeq() functions to allow driver code to be more portable.
>> Updates also for word and long function pairs. We also
>> remove SWAP_IO_SPACE for OCTEON platforms as the function
>> macros are redundant with the new mangling code.
>>
>> Signed-off-by: Steven J. Hill <steven.hill@cavium.com>
>> Acked-by: David Daney <david.daney@cavium.com>
>
> [...]
>
>> +static inline bool __should_swizzle_bits(volatile void *a)
>> +{
>> + extern const bool octeon_should_swizzle_table[];
>> +
>> + unsigned long did = ((unsigned long)a >> 40) & 0xff;
>> + return octeon_should_swizzle_table[did];
>> +}
>
> v4.8-rc1 OCTEON build is now broken with GCC 6.1 when support for 32-bit
> ABIs is enabled:
I don't get it. The kernel is always 64-bit, so unsigned long will have
a width of 64.
What kernel config are you using?
>
> CC arch/mips/vdso/gettimeofday-o32.o
> In file included from /home/aaro/los/work/shared/linux-v4.8-rc1/arch/mips/includ
> e/asm/io.h:32:0,
> from /home/aaro/los/work/shared/linux-v4.8-rc1/arch/mips/includ
> e/asm/page.h:194,
> from /home/aaro/los/work/shared/linux-v4.8-rc1/arch/mips/vdso/v
> dso.h:26,
> from /home/aaro/los/work/shared/linux-v4.8-rc1/arch/mips/vdso/g
> ettimeofday.c:11:
> /home/aaro/los/work/shared/linux-v4.8-rc1/arch/mips/include/asm/mach-cavium-octe
> on/mangle-port.h: In function '__should_swizzle_bits':
> /home/aaro/los/work/shared/linux-v4.8-rc1/arch/mips/include/asm/mach-cavium-octe
> on/mangle-port.h:19:40: error: right shift count >= width of type [-Werror=shift
> -count-overflow]
> unsigned long did = ((unsigned long)a >> 40) & 0xff;
>
> A.
>
next prev parent reply other threads:[~2016-08-12 22:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-09 2:45 [PATCH] MIPS: OCTEON: Changes to support readq()/writeq() usage Steven J. Hill
2016-07-11 16:01 ` Ralf Baechle
2016-08-12 21:38 ` Aaro Koskinen
2016-08-12 22:36 ` David Daney [this message]
2016-08-12 22:36 ` David Daney
2016-08-13 0:03 ` Aaro Koskinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57AE4F63.4010506@caviumnetworks.com \
--to=ddaney@caviumnetworks.com \
--cc=aaro.koskinen@iki.fi \
--cc=david.daney@cavium.com \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=steven.hill@cavium.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox