* Re: Re: [PATCH] MIPS: remove USB_EHCI_BIG_ENDIAN_{DESC,MMIO} depends on architecture symbol
@ 2013-05-02 9:27 EUNBONG SONG
2013-05-02 9:57 ` Jonas Gorski
0 siblings, 1 reply; 2+ messages in thread
From: EUNBONG SONG @ 2013-05-02 9:27 UTC (permalink / raw)
To: Jonas Gorski
Cc: ralf@linux-mips.org, linux-mips@linux-mips.org,
florian@openwrt.org, linux-kernel@vger.kernel.org
>These are selects and don't prevent anyone else from also selecting
> them. If you look at your referenced commit, you see it removed the
>/depends/, not the selects. It actually added selects to several
> platforms. Platforms are supposed to select them if they need them.
Hello.
Every time i config with arch/mips/configs/cavium_octeon_defconfig, the following warning messages
are showed.
warning: (MIPS_SEAD3 && PMC_MSP && CPU_CAVIUM_OCTEON) selects USB_EHCI_BIG_ENDIAN_MMIO which has unmet direct dependencies (USB_SUPPORT && USB && USB_EHCI_HCD)
warning: (MIPS_SEAD3 && PMC_MSP && CPU_CAVIUM_OCTEON) selects USB_EHCI_BIG_ENDIAN_MMIO which has unmet direct dependencies (USB_SUPPORT && USB && USB_EHCI_HCD)
And after applying this patch, the warning messages were disappeared.
> Jonas
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Re: [PATCH] MIPS: remove USB_EHCI_BIG_ENDIAN_{DESC,MMIO} depends on architecture symbol
2013-05-02 9:27 Re: [PATCH] MIPS: remove USB_EHCI_BIG_ENDIAN_{DESC,MMIO} depends on architecture symbol EUNBONG SONG
@ 2013-05-02 9:57 ` Jonas Gorski
0 siblings, 0 replies; 2+ messages in thread
From: Jonas Gorski @ 2013-05-02 9:57 UTC (permalink / raw)
To: eunb.song
Cc: ralf@linux-mips.org, linux-mips@linux-mips.org,
florian@openwrt.org, linux-kernel@vger.kernel.org,
Greg Kroah-Hartman
On Thu, May 2, 2013 at 11:27 AM, EUNBONG SONG <eunb.song@samsung.com> wrote:
>
>>These are selects and don't prevent anyone else from also selecting
>> them. If you look at your referenced commit, you see it removed the
>>/depends/, not the selects. It actually added selects to several
>> platforms. Platforms are supposed to select them if they need them.
>
> Hello.
> Every time i config with arch/mips/configs/cavium_octeon_defconfig, the following warning messages
> are showed.
> warning: (MIPS_SEAD3 && PMC_MSP && CPU_CAVIUM_OCTEON) selects USB_EHCI_BIG_ENDIAN_MMIO which has unmet direct dependencies (USB_SUPPORT && USB && USB_EHCI_HCD)
> warning: (MIPS_SEAD3 && PMC_MSP && CPU_CAVIUM_OCTEON) selects USB_EHCI_BIG_ENDIAN_MMIO which has unmet direct dependencies (USB_SUPPORT && USB && USB_EHCI_HCD)
>
> And after applying this patch, the warning messages were disappeared.
But after this patch likely EHCI is also broken on these platforms.
The solution is to either guard the USB_EHCI_BIG_ENDIAN_MMIO/DESC
selects with if USB_EHCI_HCD etc, or make
USB_EHCI_BIG_ENDIAN_MMIO/DESC not depend on USB_EHCI_HCD etc.
As far as I can tell, USB_EHCI_BIG_ENDIAN_MMIO/DESC only have any
effect on the ehci_hcd code anyway, so removing the dependencies of
these symbols should be fine and without any side effects, thus allow
platforms/drivers to select them unconditionally.
Greg, what do you think?
Jonas
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-05-02 9:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-02 9:27 Re: [PATCH] MIPS: remove USB_EHCI_BIG_ENDIAN_{DESC,MMIO} depends on architecture symbol EUNBONG SONG
2013-05-02 9:57 ` Jonas Gorski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox