From: Kalle Valo <kvalo@codeaurora.org>
To: Matt Redfearn <matt.redfearn@mips.com>
Cc: <zajec5@gmail.com>, <linux-wireless@vger.kernel.org>,
<linux-mips@linux-mips.org>, <jhogan@kernel.org>
Subject: Re: [PATCH v2] bcma: Prevent build of PCI host features in module
Date: Thu, 01 Mar 2018 12:45:57 +0200 [thread overview]
Message-ID: <87lgfcnkey.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1519898292-12155-1-git-send-email-matt.redfearn@mips.com> (Matt Redfearn's message of "Thu, 1 Mar 2018 09:58:12 +0000")
Matt Redfearn <matt.redfearn@mips.com> writes:
> Attempting to build bcma.ko with BCMA_DRIVER_PCI_HOSTMODE=y results in
> a build error due to use of symbols not exported from vmlinux:
>
> ERROR: "pcibios_enable_device" [drivers/bcma/bcma.ko] undefined!
> ERROR: "register_pci_controller" [drivers/bcma/bcma.ko] undefined!
> make[1]: *** [scripts/Makefile.modpost:92: __modpost] Error 1
>
> To prevent this, don't allow the host mode feature to be built if
> CONFIG_BCMA=m
>
> Signed-off-by: Matt Redfearn <matt.redfearn@mips.com>
>
> ---
>
> Changes in v2:
> Rebase on v4.16-rc1
>
> drivers/bcma/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/bcma/Kconfig b/drivers/bcma/Kconfig
> index ba8acca036df..cb0f1aad20b7 100644
> --- a/drivers/bcma/Kconfig
> +++ b/drivers/bcma/Kconfig
> @@ -55,7 +55,7 @@ config BCMA_DRIVER_PCI
>
> config BCMA_DRIVER_PCI_HOSTMODE
> bool "Driver for PCI core working in hostmode"
> - depends on MIPS && BCMA_DRIVER_PCI && PCI_DRIVERS_LEGACY
> + depends on MIPS && BCMA_DRIVER_PCI && PCI_DRIVERS_LEGACY && BCMA = y
Due to the recent regression in bcma I would prefer extra careful review
before I apply this. So does this look ok to everyone?
--
Kalle Valo
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: Matt Redfearn <matt.redfearn@mips.com>
Cc: zajec5@gmail.com, linux-wireless@vger.kernel.org,
linux-mips@linux-mips.org, jhogan@kernel.org
Subject: Re: [PATCH v2] bcma: Prevent build of PCI host features in module
Date: Thu, 01 Mar 2018 12:45:57 +0200 [thread overview]
Message-ID: <87lgfcnkey.fsf@kamboji.qca.qualcomm.com> (raw)
Message-ID: <20180301104557.32Xe-Ea8r84SZC1sOboqZzFDmQK4TO5fzTqH3eHRjEo@z> (raw)
In-Reply-To: <1519898292-12155-1-git-send-email-matt.redfearn@mips.com> (Matt Redfearn's message of "Thu, 1 Mar 2018 09:58:12 +0000")
Matt Redfearn <matt.redfearn@mips.com> writes:
> Attempting to build bcma.ko with BCMA_DRIVER_PCI_HOSTMODE=y results in
> a build error due to use of symbols not exported from vmlinux:
>
> ERROR: "pcibios_enable_device" [drivers/bcma/bcma.ko] undefined!
> ERROR: "register_pci_controller" [drivers/bcma/bcma.ko] undefined!
> make[1]: *** [scripts/Makefile.modpost:92: __modpost] Error 1
>
> To prevent this, don't allow the host mode feature to be built if
> CONFIG_BCMA=m
>
> Signed-off-by: Matt Redfearn <matt.redfearn@mips.com>
>
> ---
>
> Changes in v2:
> Rebase on v4.16-rc1
>
> drivers/bcma/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/bcma/Kconfig b/drivers/bcma/Kconfig
> index ba8acca036df..cb0f1aad20b7 100644
> --- a/drivers/bcma/Kconfig
> +++ b/drivers/bcma/Kconfig
> @@ -55,7 +55,7 @@ config BCMA_DRIVER_PCI
>
> config BCMA_DRIVER_PCI_HOSTMODE
> bool "Driver for PCI core working in hostmode"
> - depends on MIPS && BCMA_DRIVER_PCI && PCI_DRIVERS_LEGACY
> + depends on MIPS && BCMA_DRIVER_PCI && PCI_DRIVERS_LEGACY && BCMA = y
Due to the recent regression in bcma I would prefer extra careful review
before I apply this. So does this look ok to everyone?
--
Kalle Valo
next prev parent reply other threads:[~2018-03-01 10:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-01 9:58 [PATCH v2] bcma: Prevent build of PCI host features in module Matt Redfearn
2018-03-01 9:58 ` Matt Redfearn
2018-03-01 10:45 ` Kalle Valo [this message]
2018-03-01 10:45 ` Kalle Valo
2018-03-02 17:56 ` Larry Finger
2018-03-08 12:00 ` Matt Redfearn
2018-03-08 12:00 ` Matt Redfearn
2018-03-10 11:35 ` Jonas Gorski
2018-03-13 16:48 ` [v2] " Kalle Valo
2018-03-13 16:48 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lgfcnkey.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=jhogan@kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-wireless@vger.kernel.org \
--cc=matt.redfearn@mips.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox