Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: girish <girishvg@gmail.com>
To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Cc: "linux-mips@linux-mips.org" <linux-mips@linux-mips.org>,
	girish <girishvg@gmail.com>
Subject: Re: [PATCH] cleanup hardcoding __pa/__va macros etc. (take-2)
Date: Wed, 27 Sep 2006 00:20:30 +0900	[thread overview]
Message-ID: <C13F744E.72CB%girishvg@gmail.com> (raw)
In-Reply-To: <20060926.180240.109570923.nemoto@toshiba-tops.co.jp>


>> The idea is to differentiate the Kseg0/Kseg1 segments in the physical area.
>> Beyond these areas lies the mapped area (or the HIGHMEM). What complicates
>> this matter further is their overlapping nature. The __pa()/__va() treated
>> all addresses mapped into PAGE_OFFSET (8000_0000) area. The effort is to
>> correctly differentiate these areas.
> 
> Yes, __va() and __pa() are used to convert an physical address from/to
> an kernel logical address (i.e. low unmapped virtual address).
> 
> I think passing another sort of addresses to them is simply wrong.

Agreed. 

But, then again treating all addresses as above PAGE_OFFSET is also wrong :)
I looked at it just as a work around. These macros are called from so many
other places that if an access is made at say 4000_0000 the kernel will oops
telling it was C000_0000 access error. Now that confused me a lot! With this
change now kernel oops on 4000_0000 :)

Anyway, you may ignore __pa/__va macros.

Could you please look into other changes I proposed?


> 
> P.S.
> Please do not reply to git-commits@linux-mips.org.

I am sorry. It was a stupid mistake in creating address book entry.

  reply	other threads:[~2006-09-26 15:20 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-24  5:39 [PATCH] cleanup hardcoding __pa/__va macros etc girish
2006-09-24  7:15 ` [PATCH] cleanup hardcoding __pa/__va macros etc. (FWD) girish
2006-09-24 15:26 ` [PATCH] cleanup hardcoding __pa/__va macros etc Atsushi Nemoto
2006-09-25 14:51   ` [PATCH] cleanup hardcoding __pa/__va macros etc. (take-2) girish
2006-09-25 15:43     ` Atsushi Nemoto
     [not found]       ` <C13EBDF2.724C%girishvg@gmail.com>
2006-09-26  2:24         ` FW: " girish
2006-09-26  9:02         ` Atsushi Nemoto
2006-09-26 15:20           ` girish [this message]
2006-09-26 16:35             ` Atsushi Nemoto
2006-09-26 22:06               ` girish
2006-09-27 15:35                 ` Atsushi Nemoto
2006-09-27 16:58                   ` PATCH] cleanup hardcoding __pa/__va macros etc. (take-4) girish
2006-09-28 23:29                     ` Ralf Baechle
2006-09-29 14:45                       ` PATCH] cleanup hardcoding __pa/__va macros etc. (take-5) girish
2006-09-29 17:59                         ` Atsushi Nemoto
2006-09-29 18:33                           ` girish
2006-10-01 14:52                             ` Atsushi Nemoto
2006-10-01 14:57                               ` girish
2006-10-01 15:09                                 ` Atsushi Nemoto
2006-09-28 15:01           ` [PATCH] cleanup hardcoding __pa/__va macros etc. (take-2) Ralf Baechle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C13F744E.72CB%girishvg@gmail.com \
    --to=girishvg@gmail.com \
    --cc=anemo@mba.ocn.ne.jp \
    --cc=linux-mips@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox