Linux MIPS Architecture development
 help / color / mirror / Atom feed
* [PATCH 2.4] cpu-probe.c error
@ 2003-06-20 17:02 Brian Murphy
  2003-06-20 17:08 ` Pete Popov
  0 siblings, 1 reply; 3+ messages in thread
From: Brian Murphy @ 2003-06-20 17:02 UTC (permalink / raw)
  To: ralf; +Cc: linux-mips

Hi Ralf,
	the latest change to cpu-probe.c requires a mips_cpu
variable which no longer exists. I presume you meant the following.

/Brian

Index: arch/mips/kernel/cpu-probe.c
===================================================================
RCS file: /cvs/linux/arch/mips/kernel/cpu-probe.c,v
retrieving revision 1.1.2.21
diff -u -r1.1.2.21 cpu-probe.c
--- arch/mips/kernel/cpu-probe.c	15 Jun 2003 23:35:54 -0000	1.1.2.21
+++ arch/mips/kernel/cpu-probe.c	20 Jun 2003 16:59:16 -0000
@@ -498,21 +498,21 @@
 #endif
 			break;
 		default:
-			mips_cpu.cputype = CPU_UNKNOWN;
+			c->cputype = CPU_UNKNOWN;
 			break;
 		}
 		break;
 
 	case PRID_COMP_SANDCRAFT:
-		switch (mips_cpu.processor_id & 0xff00) {
+		switch (c->processor_id & 0xff00) {
 		case PRID_IMP_SR71000:
-			mips_cpu.cputype = CPU_SR71000;
-			mips_cpu.isa_level = MIPS_CPU_ISA_M64;
-			mips_cpu.options = MIPS_CPU_TLB | MIPS_CPU_4KEX |
+			c->cputype = CPU_SR71000;
+			c->isa_level = MIPS_CPU_ISA_M64;
+			c->options = MIPS_CPU_TLB | MIPS_CPU_4KEX |
                                            MIPS_CPU_4KTLB | MIPS_CPU_FPU |
 			                   MIPS_CPU_COUNTER | MIPS_CPU_MCHECK;
-			mips_cpu.scache.ways = 8;
-			mips_cpu.tlbsize = 64;
+			c->scache.ways = 8;
+			c->tlbsize = 64;
 			break;
 		default:
 			c->cputype = CPU_UNKNOWN;

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 2.4] cpu-probe.c error
  2003-06-20 17:02 [PATCH 2.4] cpu-probe.c error Brian Murphy
@ 2003-06-20 17:08 ` Pete Popov
  2003-06-21  9:06   ` Ladislav Michl
  0 siblings, 1 reply; 3+ messages in thread
From: Pete Popov @ 2003-06-20 17:08 UTC (permalink / raw)
  To: Brian Murphy; +Cc: Ralf Baechle, Linux MIPS mailing list


FYI, I had tried the same patch and it works fine on my boards. I think
mips64 may be broken as well, if I remember correctly.

Pete

On Fri, 2003-06-20 at 10:02, Brian Murphy wrote:
> Hi Ralf,
> 	the latest change to cpu-probe.c requires a mips_cpu
> variable which no longer exists. I presume you meant the following.
> 
> /Brian
> 
> Index: arch/mips/kernel/cpu-probe.c
> ===================================================================
> RCS file: /cvs/linux/arch/mips/kernel/cpu-probe.c,v
> retrieving revision 1.1.2.21
> diff -u -r1.1.2.21 cpu-probe.c
> --- arch/mips/kernel/cpu-probe.c	15 Jun 2003 23:35:54 -0000	1.1.2.21
> +++ arch/mips/kernel/cpu-probe.c	20 Jun 2003 16:59:16 -0000
> @@ -498,21 +498,21 @@
>  #endif
>  			break;
>  		default:
> -			mips_cpu.cputype = CPU_UNKNOWN;
> +			c->cputype = CPU_UNKNOWN;
>  			break;
>  		}
>  		break;
>  
>  	case PRID_COMP_SANDCRAFT:
> -		switch (mips_cpu.processor_id & 0xff00) {
> +		switch (c->processor_id & 0xff00) {
>  		case PRID_IMP_SR71000:
> -			mips_cpu.cputype = CPU_SR71000;
> -			mips_cpu.isa_level = MIPS_CPU_ISA_M64;
> -			mips_cpu.options = MIPS_CPU_TLB | MIPS_CPU_4KEX |
> +			c->cputype = CPU_SR71000;
> +			c->isa_level = MIPS_CPU_ISA_M64;
> +			c->options = MIPS_CPU_TLB | MIPS_CPU_4KEX |
>                                             MIPS_CPU_4KTLB | MIPS_CPU_FPU |
>  			                   MIPS_CPU_COUNTER | MIPS_CPU_MCHECK;
> -			mips_cpu.scache.ways = 8;
> -			mips_cpu.tlbsize = 64;
> +			c->scache.ways = 8;
> +			c->tlbsize = 64;
>  			break;
>  		default:
>  			c->cputype = CPU_UNKNOWN;
> 
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 2.4] cpu-probe.c error
  2003-06-20 17:08 ` Pete Popov
@ 2003-06-21  9:06   ` Ladislav Michl
  0 siblings, 0 replies; 3+ messages in thread
From: Ladislav Michl @ 2003-06-21  9:06 UTC (permalink / raw)
  To: Pete Popov; +Cc: Brian Murphy, Ralf Baechle, Linux MIPS mailing list

On Fri, Jun 20, 2003 at 10:08:25AM -0700, Pete Popov wrote:
> 
> FYI, I had tried the same patch and it works fine on my boards. I think
> mips64 may be broken as well, if I remember correctly.

FYI, I sent patch which fixes mips/mips64; 2.4/2.5 at Mon, 16 Jun 2003
16:13:07 +0200 with subject "[PATCH] cpu-probe compile fix" and
Message-ID: <20030616141307.GA16721@simek>
Ralf could you please apply that one?

	ladis

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2003-06-21  9:06 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-06-20 17:02 [PATCH 2.4] cpu-probe.c error Brian Murphy
2003-06-20 17:08 ` Pete Popov
2003-06-21  9:06   ` Ladislav Michl

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox