From: Jiaxun Yang <jiaxun.yang@flygoat.com>
To: Tiezhu Yang <yangtiezhu@loongson.cn>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Huacai Chen <chenhc@lemote.com>
Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
Xuefeng Li <lixuefeng@loongson.cn>
Subject: Re: [PATCH 1/2] MIPS: Loongson: Fix fatal error during GPU init
Date: Fri, 15 May 2020 11:17:58 +0800 [thread overview]
Message-ID: <F7BAD661-9D82-4063-B685-4A7192B7F172@flygoat.com> (raw)
In-Reply-To: <636ba812-3849-2667-d625-ab7e35d5ac36@loongson.cn>
于 2020年5月15日 GMT+08:00 上午11:09:56, Tiezhu Yang <yangtiezhu@loongson.cn> 写到:
>On 05/15/2020 10:33 AM, Jiaxun Yang wrote:
>>
>> 于 2020年5月15日 GMT+08:00 上午10:15:00, Tiezhu Yang <yangtiezhu@loongson.cn> 写到:
>>> When ATI Radeon graphics card has been compiled directly into the kernel
>>> instead of as a module, we should make sure the firmware for the model
>>> (check available ones in /lib/firmware/radeon) is built-in to the kernel
>>> as well, otherwise there exists the following fatal error during GPU init,
>>> change CONFIG_DRM_RADEON=y to CONFIG_DRM_RADEON=m to fix it.
>>>
>> The commit message looks shocking.
>>
>> You'd better reword it as "MIPS: Loongson64: Mark GPU driver as module in Kconfig"
>
>OK, I will modify the patch subject and send v2.
Sorry I meant defconfig not Kconfig.
>
>>
>> Thanks.
>
--
Jiaxun Yang
next prev parent reply other threads:[~2020-05-15 3:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-15 2:15 [PATCH 1/2] MIPS: Loongson: Fix fatal error during GPU init Tiezhu Yang
2020-05-15 2:15 ` [PATCH 2/2] MIPS: Fix build errors under CONFIG_HAVE_STD_PC_SERIAL_PORT Tiezhu Yang
2020-05-15 2:33 ` [PATCH 1/2] MIPS: Loongson: Fix fatal error during GPU init Jiaxun Yang
2020-05-15 3:09 ` Tiezhu Yang
2020-05-15 3:17 ` Jiaxun Yang [this message]
2020-05-15 8:51 ` Sergei Shtylyov
2020-05-15 8:58 ` Tiezhu Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F7BAD661-9D82-4063-B685-4A7192B7F172@flygoat.com \
--to=jiaxun.yang@flygoat.com \
--cc=chenhc@lemote.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=lixuefeng@loongson.cn \
--cc=tsbogend@alpha.franken.de \
--cc=yangtiezhu@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox