[PATCH] MIPS: OCTEON: warn only once if deprecated link status is being used

[PATCH] MIPS: OCTEON: warn only once if deprecated link status is being used

[Ladislav Michl]

From: Ladislav Michl <ladis@linux-mips.org>

Avoid flooding kernel log with warnings.

Fixes: 2c0756d306c2 ("MIPS: OCTEON: warn if deprecated link status is being used")
Signed-off-by: Ladislav Michl <ladis@linux-mips.org>
---
 arch/mips/cavium-octeon/executive/cvmx-helper-board.c | 2 +-
 arch/mips/cavium-octeon/executive/cvmx-helper.c       | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/mips/cavium-octeon/executive/cvmx-helper-board.c b/arch/mips/cavium-octeon/executive/cvmx-helper-board.c
index d09d0769f549..0fd9ac76eb74 100644
--- a/arch/mips/cavium-octeon/executive/cvmx-helper-board.c
+++ b/arch/mips/cavium-octeon/executive/cvmx-helper-board.c
@@ -211,7 +211,7 @@ union cvmx_helper_link_info __cvmx_helper_board_link_get(int ipd_port)
 {
 	union cvmx_helper_link_info result;
 
-	WARN(!octeon_is_simulation(),
+	WARN_ONCE(!octeon_is_simulation(),
 	     "Using deprecated link status - please update your DT");
 
 	/* Unless we fix it later, all links are defaulted to down */
diff --git a/arch/mips/cavium-octeon/executive/cvmx-helper.c b/arch/mips/cavium-octeon/executive/cvmx-helper.c
index 6f49fd9be1f3..9abfc4bf9bd8 100644
--- a/arch/mips/cavium-octeon/executive/cvmx-helper.c
+++ b/arch/mips/cavium-octeon/executive/cvmx-helper.c
@@ -1096,7 +1096,7 @@ union cvmx_helper_link_info cvmx_helper_link_get(int ipd_port)
 		if (index == 0)
 			result = __cvmx_helper_rgmii_link_get(ipd_port);
 		else {
-			WARN(1, "Using deprecated link status - please update your DT");
+			WARN_ONCE(1, "Using deprecated link status - please update your DT");
 			result.s.full_duplex = 1;
 			result.s.link_up = 1;
 			result.s.speed = 1000;
-- 
2.32.0

Re: [PATCH] MIPS: OCTEON: warn only once if deprecated link status is being used

[Philippe Mathieu-Daudé]

On 8/12/22 12:25, Ladislav Michl wrote:
> From: Ladislav Michl <ladis@linux-mips.org>
> 
> Avoid flooding kernel log with warnings.
> 
> Fixes: 2c0756d306c2 ("MIPS: OCTEON: warn if deprecated link status is being used")
> Signed-off-by: Ladislav Michl <ladis@linux-mips.org>
> ---
>   arch/mips/cavium-octeon/executive/cvmx-helper-board.c | 2 +-
>   arch/mips/cavium-octeon/executive/cvmx-helper.c       | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Re: [PATCH] MIPS: OCTEON: warn only once if deprecated link status is being used

[Thomas Bogendoerfer]

On Thu, Dec 08, 2022 at 12:25:57PM +0100, Ladislav Michl wrote:
> From: Ladislav Michl <ladis@linux-mips.org>
> 
> Avoid flooding kernel log with warnings.
> 
> Fixes: 2c0756d306c2 ("MIPS: OCTEON: warn if deprecated link status is being used")
> Signed-off-by: Ladislav Michl <ladis@linux-mips.org>
> ---
>  arch/mips/cavium-octeon/executive/cvmx-helper-board.c | 2 +-
>  arch/mips/cavium-octeon/executive/cvmx-helper.c       | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

applied to mips-next.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]