From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: WangYuli <wangyuli@uniontech.com>
Cc: "Maciej W. Rozycki" <macro@orcam.me.uk>,
chenlinxuan@uniontech.com, guanwentao@uniontech.com,
linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org,
niecheng1@uniontech.com, zhanjun@uniontech.com
Subject: Re: [PATCH 5/7] MIPS: dec: Remove dec_irq_dispatch()
Date: Mon, 3 Mar 2025 10:06:45 +0100 [thread overview]
Message-ID: <Z8VxJbTqHhIE-Q-w@alpha.franken.de> (raw)
In-Reply-To: <A1142BF8B63D5EC4+98768bf8-7bde-46ec-85fc-f077d67a1798@uniontech.com>
On Mon, Mar 03, 2025 at 12:23:13PM +0800, WangYuli wrote:
> Hi Maciej,
>
> On 2025/3/1 00:01, Maciej W. Rozycki wrote:
> > Up to commit 8f99a16265353 ("MIPS: Tracing: Add IRQENTRY_EXIT section for
> > MIPS") `do_IRQ' used to be a macro, that's why. At the time `do_IRQ' was
> > converted to a macro `dec_irq_dispatch' was created and previously this
> > place used to call `do_IRQ' too.
> >
> > It's always good finding out why things are as they are so as to make
> > sure you haven't been missing something. This cleanup should have been
> > made along with commit 8f99a16265353, so it's pretty old a technical debt
> > being sorted here.
> >
> > Please add these findings to your commit description in v2.
>
> Alright, thank you for the correction.
>
> I do see that this commit has already been applied to mips-next.
>
> If it's alright with you and Thomas, I'm happy to send a patch v2 to
> include these details soon.
I'll drop the applied patch and take your v2.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
next prev parent reply other threads:[~2025-03-03 9:42 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-18 12:51 [PATCH 0/7] MIPS: decstation_64_defconfig: Compile the kernel with warnings as errors WangYuli
2025-02-18 12:54 ` [PATCH 1/7] MIPS: dec: Declare which_prom() as static WangYuli
2025-02-27 10:00 ` Thomas Bogendoerfer
2025-02-18 12:56 ` [PATCH 2/7] MIPS: dec: Create reset.h WangYuli
2025-02-27 9:45 ` Thomas Bogendoerfer
2025-02-27 10:14 ` WangYuli
2025-02-18 12:57 ` [PATCH 3/7] MIPS: cevt-ds1287: Add missing ds1287.h include WangYuli
2025-02-27 10:00 ` Thomas Bogendoerfer
2025-02-18 12:57 ` [PATCH 4/7] MIPS: ds1287: Match ds1287_set_base_clock() function types WangYuli
2025-02-27 10:00 ` Thomas Bogendoerfer
2025-02-18 12:58 ` [PATCH 5/7] MIPS: dec: Remove dec_irq_dispatch() WangYuli
2025-02-27 10:01 ` Thomas Bogendoerfer
2025-02-28 16:01 ` Maciej W. Rozycki
2025-03-03 4:23 ` WangYuli
2025-03-03 9:06 ` Thomas Bogendoerfer [this message]
2025-02-18 13:00 ` [PATCH 6/7] MIPS: decstation_64_defconfig: Update configs dependencies WangYuli
2025-02-18 13:00 ` [PATCH 7/7] MIPS: decstation_64_defconfig: Compile the kernel with warnings as errors WangYuli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z8VxJbTqHhIE-Q-w@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=chenlinxuan@uniontech.com \
--cc=guanwentao@uniontech.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=macro@orcam.me.uk \
--cc=niecheng1@uniontech.com \
--cc=wangyuli@uniontech.com \
--cc=zhanjun@uniontech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox