Re: [PATCH 2/7] MIPS: dec: Create reset.h

[Thomas Bogendoerfer <tsbogend@alpha.franken.de>]

On Tue, Feb 18, 2025 at 08:56:33PM +0800, WangYuli wrote:
> Declare externally used functions in reset.c to resolve compilation
> warnings.
> [...] 
> -
> -extern void dec_machine_restart(char *command);
> -extern void dec_machine_halt(void);
> -extern void dec_machine_power_off(void);
> -extern irqreturn_t dec_intr_halt(int irq, void *dev_id);
> -
>  unsigned long dec_kn_slot_base, dec_kn_slot_size;
>  
>  EXPORT_SYMBOL(dec_kn_slot_base);
> diff --git a/arch/mips/include/asm/dec/reset.h b/arch/mips/include/asm/dec/reset.h
> new file mode 100644
> index 000000000000..5e7b27561fbe
> --- /dev/null
> +++ b/arch/mips/include/asm/dec/reset.h
> @@ -0,0 +1,17 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * Reset a DECstation machine.
> + *
> + * Copyright (C) 2025  WangYuli

I don't think this copyright is appropriate, you are only moving code
you haven't written.

Thomas.

> + */
> +
> +#ifndef __ASM_DEC_RESET_H
> +
> +#include <linux/interrupt.h>
> +
> +extern void __noreturn dec_machine_restart(char *command);
> +extern void __noreturn dec_machine_halt(void);
> +extern void __noreturn dec_machine_power_off(void);
> +extern irqreturn_t dec_intr_halt(int irq, void *dev_id);
> +
> +#endif /* __ASM_DEC_RESET_H */

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]